-
Notifications
You must be signed in to change notification settings - Fork 153
Closed
Labels
breaking-changeA change that breaks our public interfaceA change that breaks our public interfacedocumentationImprovements or additions to documentationImprovements or additions to documentationusabilityMake the library more comfortable to useMake the library more comfortable to use
Milestone
Description
What problem does this solve or what need does it fill?
The Taffy struct is not particularly descriptively named, especially now that taffy also has a low-level API and the Taffy struct doesn't represent the only API
What solution would you like?
Give the Taffy struct a better name. Suggestions:
DefaultTree/DefaultLayoutTreeSimpleTree/SimpleLayoutTreeTaffyTree/TaffyLayoutTree
We could also consider renaming the LayoutTree trait at the same time if that would help.
Additional context
We may also want to make the Taffy struct generic in future for two purposes:
- To allow for both
Send + Syncand non-Send + Syncmeasure functions. The former is required to allowTaffyinstances to be moved between threads, but the latter is necessary in contexts like WASM where measure functions from JS typically won't beSend. - To allow a context to be provided for passing into measure functions (which would effectively allow them to borrow from their environment.
Metadata
Metadata
Assignees
Labels
breaking-changeA change that breaks our public interfaceA change that breaks our public interfacedocumentationImprovements or additions to documentationImprovements or additions to documentationusabilityMake the library more comfortable to useMake the library more comfortable to use