Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ let package = Package(
]),
.testTarget(
name: "CodexSkillManagerTests",
dependencies: [],
dependencies: ["CodexSkillManager"],
path: "Tests/CodexSkillManagerTests",
swiftSettings: [
.unsafeFlags(["-strict-concurrency=complete"]),
Expand Down
8 changes: 6 additions & 2 deletions Sources/CodexSkillManager/Workers/SkillFileWorker.swift
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,16 @@ actor SkillFileWorker {

func scanSkills(at baseURL: URL, storageKey: String) throws -> [ScannedSkillData] {
let fileManager = FileManager.default
guard fileManager.fileExists(atPath: baseURL.path) else {

// Directory symlinks can fail URL-based enumeration on macOS.
let directoryURL = baseURL.resolvingSymlinksInPath()

guard fileManager.fileExists(atPath: directoryURL.path) else {
return []
}

let items = try fileManager.contentsOfDirectory(
at: baseURL,
at: directoryURL,
includingPropertiesForKeys: [.isDirectoryKey],
options: [.skipsHiddenFiles]
)
Expand Down
35 changes: 35 additions & 0 deletions Tests/CodexSkillManagerTests/SymlinkScanTests.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import Foundation
import Testing

@testable import CodexSkillManager

@Suite("Symlink Scan")
struct SymlinkScanTests {
@Test("scanSkills follows directory symlinks")
func scanSkillsFollowsDirectorySymlinks() async throws {
let fileManager = FileManager.default
let tempRoot = fileManager.temporaryDirectory.appendingPathComponent(UUID().uuidString)
defer { try? fileManager.removeItem(at: tempRoot) }

let realRoot = tempRoot.appendingPathComponent("real")
let symlinkRoot = tempRoot.appendingPathComponent("link")

try fileManager.createDirectory(at: realRoot, withIntermediateDirectories: true)

let skillRoot = realRoot.appendingPathComponent("my-skill")
try fileManager.createDirectory(at: skillRoot, withIntermediateDirectories: true)
try "# My Skill\n".write(
to: skillRoot.appendingPathComponent("SKILL.md"),
atomically: true,
encoding: .utf8
)

try fileManager.createSymbolicLink(at: symlinkRoot, withDestinationURL: realRoot)

let worker = SkillFileWorker()
let scanned = try await worker.scanSkills(at: symlinkRoot, storageKey: "test")

#expect(scanned.count == 1)
#expect(scanned.first?.name == "my-skill")
}
}