Employing Lua scripts to accelerate database retrieval #1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Difegue
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Overall I don't see any issues with the approach -- The fact it falls back to the prior code in case anything goes wrong is also quite helpful for now I think. We'll have to run this in nightlies for a bit and see how it works.
The only comments I really have are about cleaning up the incode comments -- I'll autoapply those and get this merged. Thanks for the work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to utilize Lua scripts to replace batch HGET requests. Based on my own testing, this optimization reduced the processing time from approximately 15s down to 2-3s.