fix nightly build #176
Merged
fix nightly build #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenextman
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last week's PR didn't take into account the scheduled builds on Monday that just test everything still builds properly. The important part about scheduled builds is that "inputs" aren't available, not even the default values, so we have to check for empty values in the preflight step. The build failed because of an empty list of packages to build. I modified the workflow to build an array of packages which is then converted to a string separated by commas, and if the list is empty, it just builds all packages. This also means that if you start a build with everything unchecked, it'll build everything, but I guess that's better than just failing.