-
Notifications
You must be signed in to change notification settings - Fork 3
Fix 25.1.3 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix 25.1.3 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert var to const/let for modern JavaScript - Implement cascading DropDownBoxes functionality - Add State and City dropdown filtering - Modernize function syntax and arrow functions - Add comprehensive data with states and cities - Maintain same functionality as original with modern patterns
…atterns - Enhanced app.component.ts with proper DxDataGridTypes typing - Added DxDataGridTypes.Column type for setStateValue method - Implemented proper DevExtreme Angular imports and type-only imports - Added app.service.ts with Employee, State, City interfaces - Added app.types.ts for EditCellInfo and CityDropDownInfo interfaces - Fixed all ESLint and TypeScript compilation issues - Updated app.module.ts with required DevExtreme Angular modules - Maintained cascading dropdown functionality with modern typing - Removed all orig_ files as per migration guidelines
… fixes - Migrated from Options API to Vue 3 Composition API with <script setup lang="ts"> - Restructured App.vue to standard Vite template with RouterView - Moved DataGrid implementation to HomeContent.vue component - Created TypeScript data.ts with Employee, State, City interfaces - Fixed critical cascading dropdown issues: * Added onInitNewRow handler to initialize StateID/CityID arrays * Fixed undefined value handling in dropdown components * Removed auto-updating watchers that caused premature dropdown closure * City dropdown now shows all cities when no state is selected - Enhanced TypeScript implementation with DevExtreme Vue types: * Used DxDataGridTypes for proper event and template typing * Added proper DevExtreme Vue component references and imports * Used framework-specific imports from devextreme-vue packages - Applied Vue 3 best practices: * Composition API with reactive refs and computed properties * Proper watch functions for prop synchronization * Type-safe component props and event handlers - Fixed all ESLint issues and code formatting - Maintained cascading dropdown functionality with Apply button pattern - Removed all orig_ files as per migration guidelines
Please correct the project and update this pull request by pushing a new commit.
|
Please correct the project and update this pull request by pushing a new commit.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.