Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

generator: update to account for embedded bootspec docs #141

Merged
merged 4 commits into from
May 18, 2022
Merged

generator: update to account for embedded bootspec docs #141

merged 4 commits into from
May 18, 2022

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented May 17, 2022

Description

Implementing this update: NixOS/rfcs#125 (comment)

Checklist
  • Built with cargo build
  • Formatted with cargo fmt
  • Linted with cargo clippy
  • Ran tests with cargo test
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)

@grahamc grahamc requested a review from cole-h May 17, 2022 22:16
@grahamc grahamc mentioned this pull request May 17, 2022
Merged
@grahamc grahamc marked this pull request as ready for review May 18, 2022 00:42
@grahamc grahamc requested a review from firestack May 18, 2022 14:16
firestack
firestack approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grahamc grahamc merged commit 02d8ac0 into main May 18, 2022
@grahamc grahamc deleted the rfc-embed-subs branch May 18, 2022 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@firestack firestack firestack approved these changes

@cole-h cole-h cole-h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grahamc @firestack @cole-h