add settings to disable each type of inlay hint #738
Merged
+85
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetachHead
force-pushed
the
inlay-hint-settings
branch
from
a964edf to
0627819
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy)
- Type of "sqrtdenest" is "(expr: Unknown, max_iter: int = 3) -> (Unknown | Mul | Pow | Order | Expr | Add | None)" (reportUnknownVariableType)
+ Type of "sqrtdenest" is "(expr: Unknown, max_iter: int = 3) -> Unknown" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/subscheck.py:385:22 - error: Type of "simplify" is unknown (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/subscheck.py:385:22 - error: Type of "simplify" is partially unknown
+ Type of "simplify" is "Unknown | ((**kwargs: Unknown) -> Unknown)" (reportUnknownMemberType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/ode/subscheck.py:385:37 - error: "simplify" is not a known attribute of "None" (reportOptionalMemberAccess)
- Type of "_" is "Unknown | Literal[False]" (reportUnknownVariableType)
+ Type of "_" is "Unknown | Any | Literal[False]" (reportUnknownVariableType)
- Type of "_" is "Unknown | Literal[False]" (reportUnknownVariableType)
+ Type of "_" is "Unknown | Any | Literal[False]" (reportUnknownVariableType)
- Type of "_" is "Unknown | Literal[False]" (reportUnknownVariableType)
+ Type of "_" is "Unknown | Any | Literal[False]" (reportUnknownVariableType)
- Type of "_" is "Unknown | Literal[False]" (reportUnknownVariableType)
+ Type of "_" is "Unknown | Any | Literal[False]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:501:5 - error: Type of "eqs" is partially unknown
- Type of "eqs" is "list[Unknown]" (reportUnknownVariableType)
- Argument type is "Unknown | _NotImplementedType" (reportUnknownArgumentType)
+ Argument type is "Unknown | Any | _NotImplementedType" (reportUnknownArgumentType)
- Type of "eqs" is "list[Unknown]" (reportUnknownVariableType)
+ Type of "eqs" is "list[Unknown | Any]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:505:16 - error: Argument type is unknown
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:505:16 - error: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "__init__" (reportUnknownArgumentType)
+ Argument corresponds to parameter "iterable" in function "__init__"
+ Argument type is "Unknown | Any" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:717:18 - error: Argument type is unknown
- Argument corresponds to parameter "f" in function "solve" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:1768:5 - error: Type of "eqs" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:1768:5 - error: Type of "eqs" is partially unknown
+ Type of "eqs" is "Unknown | Any" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:1769:18 - error: Argument type is unknown
- Argument corresponds to parameter "f" in function "solve" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_solvers.py:1770:18 - error: Argument type is unknown
- Argument corresponds to parameter "f" in function "solve" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/stats/tests/test_symbolic_multivariate.py:64:50 - error: Argument type is unknown
- Argument corresponds to parameter "expr" in function "__new__" (reportUnknownArgumentType)
- Type of "c" is "Unknown | _NotImplementedType" (reportUnknownVariableType)
+ Type of "c" is "Unknown | Any | _NotImplementedType" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_lambdify.py:634:29 - error: Argument type is unknown
- Argument corresponds to parameter "expr" in function "lambdify" (reportUnknownArgumentType)
- Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> Unknown" (reportUnknownMemberType)
+ Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> (Unknown | Any)" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/utilities/tests/test_wester.py:1313:24 - error: Argument type is unknown
- Argument corresponds to parameter "e" in function "expand" (reportUnknownArgumentType)
- Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> Unknown" (reportUnknownMemberType)
+ Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> (Unknown | Any)" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/vector/coordsysrect.py:289:25 - error: Argument type is unknown
- Argument corresponds to parameter "expr" in function "simplify" (reportUnknownArgumentType)
- Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> Unknown" (reportUnknownMemberType)
+ Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> (Unknown | Any)" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/vector/coordsysrect.py:289:55 - error: Argument type is unknown
- Argument corresponds to parameter "expr" in function "simplify" (reportUnknownArgumentType)
- Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> Unknown" (reportUnknownMemberType)
+ Type of "dot" is "(b: Unknown, hermitian: Unknown | None = None, conjugate_convention: Unknown | None = None) -> (Unknown | Any)" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/vector/coordsysrect.py:290:30 - error: Argument type is unknown
- Argument corresponds to parameter "expr" in function "simplify" (reportUnknownArgumentType)
- 597159 errors, 0 warnings, 0 notes
+ 597150 errors, 0 warnings, 0 notes
|
stevenlele
reviewed
Oct 3, 2024
Comment on lines
+26
to
+30
| /** | ||
| * pylance's version of this option supports 3 settings: `"all" | "partial" | "off"`. `"all"` shows inlay hints | ||
| * for positional only arguments which i think is dumb so we don't support it | ||
| */ | ||
| callArgumentNames: boolean; |
There was a problem hiding this comment.
oh true, i'll do that next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #542