-
-
Notifications
You must be signed in to change notification settings - Fork 648
Feature: Show weapon frame on weapon icons? #11576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
If you think folks can make use of this, that's OK. The main difference between this and the armor icons is that the armor icons are much more recognizable (and there are fewer of them) plus the frame icons include that big border that makes them hard to distinguish at small sizes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot for Ergo Sum in particular.
In the future it might be worth including e.g. crafted exotics' selected catalyst, but that's a different can of worms.
Also, it may be worth swapping tag/lock icon position with the frame/archetype position, to mirror how lock icons in D2 are top-right. Just a thought, would be interested to see how that looks.
Genuinely RFC, I could go either way, I will not feel bad if you think it's too much. Every concession to "giant pile of icons" has a cost. Don't mistake the below info for a spirited defense.
Absolutely true the stat icons are most recognizable. To many veterans though these are pretty recognizable too, since most of them have existed for at least 7 years and the newer handful are pretty self explanatory...
...and there's not as many as it feels like. More than 6, but if you remove the rarer newer niche ones, the main global frame types are approximately 7-8 icons, shared liberally across all weapon archetypes, usually 3-5 per weapon type. If you know what an Aggressive shotgun looks like, you also know what an Aggressive hand cannon, SMG, or fusion rifle looks like.
I've trimmed away all the transparent area here, and these could be zoomed even slightly more to trim away some of the background fill. Part of my thought with this was, it's finally a way to satisfy the "needs visible" requirement for the long, long-requested "sort by frame". Next to element, it's the other obvious sub-grouping within "weapon type" that puts similar-behaving weapons near each other. |
As long as we are now using this area to show an item's most salient piece of information?