Skip to content

Conversation

@andrewshaodev
Copy link

Dumb American who can't get used to 24 hour time. I added the option to change to 12 hour time as an extra configuration. 24 hour remains default.

Pull Request Checklist

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Did you make your Pull Request on the dev branch?
  • Does your submission pass tests? make test
  • Have you lint your code locally prior to submission? make lint
  • Could you build and run the docker images successfully? make images
  • Could you create a running executable? make executable
  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran manual tests with your changes locally?

Der-Henning and others added 4 commits April 27, 2025 12:52
- Add TimeFormat config option (24h or 12h) in [MAIN] section
- Update Item class to format pickup times based on time_format setting
- 12-hour format displays times with AM/PM (e.g., "07:00 PM - 07:30 PM")
- 24-hour format remains default (e.g., "19:00 - 19:30")
- Support both config.ini (TimeFormat) and environment variable (TIME_FORMAT)
- Add tests for both time format options
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.67%. Comparing base (78f4540) to head (2e24375).
⚠️ Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
tgtg_scanner/scanner.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #643      +/-   ##
==========================================
+ Coverage   64.58%   64.67%   +0.08%     
==========================================
  Files          27       27              
  Lines        2471     2477       +6     
==========================================
+ Hits         1596     1602       +6     
  Misses        875      875              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Der-Henning Der-Henning merged commit 57acf32 into Der-Henning:dev Nov 9, 2025
24 checks passed
@andrewshaodev andrewshaodev deleted the feature/12-hour-time branch November 15, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants