Update output.csv.map if pointing to lake.locs #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the v0 to v1 upgrade logic to handle CSV column map references that point to lake or reservoir locations, converting them to the new "reservoir_location__count" format.
- Adds handling for "lateral.river.lake.locs" and "lateral.river.reservoir.locs" map references in CSV output configuration
- Updates test data files to reflect the new mapping format
- Refactors code style by removing unnecessary
.keys()calls and using walrus operator
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hydromt_wflow/version_upgrade.py | Adds logic to convert lake/reservoir location maps to "reservoir_location__count" |
| tests/data/wflow_v0x/sbm/wflow_sbm_v1.toml | Updates test data with expected v1 format output |
| examples/data/wflow_upgrade/sbm/wflow_sbm_v0x.toml | Updates example data with v0 format input for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hboisgon
reviewed
Aug 26, 2025
Fixes #439 v0 to v1 upgrade now also checks for csv.column.map and updates it in the new output variable output.csv.column.map. "lateral.river.lake.locs" and "lateral.river.reservoir.locs" become "reservoir_location__count"
deltamarnix
force-pushed
the
fix/493-update-csv-map-locs
branch
from
0ff633a to
c6065ec
Compare
hboisgon
reviewed
Sep 1, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493
v0 to v1 upgrade now also checks for csv.column.map and updates it in the new output variable output.csv.column.map.
"lateral.river.lake.locs" and "lateral.river.reservoir.locs" become "reservoir_location__count"
Issue addressed
Fixes #
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.