-
Notifications
You must be signed in to change notification settings - Fork 22
Add support for inverse clipping #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating and updating the PR @JoostBuitink.
I like your solution too :)
Before merging, it would still be good to update the docstrings and also implement this to the clip_forcing method. Can you still do this? Else I'm happy to take over too, just let me know!
Ah forgot about the docstrings, will do that! Related to the clip_forcing, I understood that it uses the extent of the grid (staticmaps) to determine how the forcing should be clipped. So I don't think there are changes required there, is that right? I think the same holds for the clip_states function, but let me know if changes are needed in these functions as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course you are right for forcing! Sorry I forgot how it was working... So all good now!
I was hesitating to add this change in the version 1 release. What do you think? If version 1 then we need to wait before we can merge.
No problem! I think this can be merged now (since it is also a very minor code change), such that for v1 changes it will also be included. Or do I overlook something? |
* Add support for inverse clipping (removing upstream area from model) * precommit fix * add test * precommit * update docstring * consistent naming * update changelog --------- Co-authored-by: Sam Vente <[email protected]>
Issue addressed
Fixes #112
Explanation
With a flag, a user can specify if the clipping needs te be done "normally" (only saving all upstream area given a location), or "inversely" (removing the upstream area given a location). This is useful to link for example several separate wflow models, that together cover a large river basin.
Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.