unpin numpy and xarray #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hboisgon
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Thanks for investigating @DirkEilander! I agree in principle but I guess we need to wait for hydromt v0.10.1 to make the final updates in this branch and then merge.
This was referenced Feb 20, 2025
savente93
approved these changes
Feb 27, 2025
|
@savente93 Thanks for releasing hydromt 0.10.1. As I mentioned above though, this pull request was not ready as for example in the pyproject toml we point to the installation of hydromt via git ("hydromt@git+https://github.com/Deltares/[email protected]") and not conda forge... Could you adress that? Either by re-opening this PR or in a new branch. Thanks! |
|
Sorry, didn't realise that, I'll fix it today. |
savente93
pushed a commit
that referenced
this pull request
Mar 3, 2025
* unpin numpy and xarray * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #328
The issue was likely related to using numpy<2 in combination with recent pyflwdir update.
Explanation
Requires Hydromt core v0.10.1 patch release