Bugfix: IK-30 spread issues and dev configuration assertion crashes #4212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixed the IK-30 spread bug when the weapon is wielded
Technical details
It inherits from BaseGunWieldable, which by default has a GunWieldBonusComponent
The issue is that SharedWieldableSystem literally adds these values onto the base values:
The IK-30 (and the IK-60 inheriting from it) had a base minAngle of 1 and maxAngle of 4, causing these values to be negative, with maxAngle being smaller than minAngle.
I fixed it by simply adding a GunWieldBonus with 0-0 angles to the IK-30. The other alternative is to rework BaseGunWieldable but it's upstream territory.
A test should probably be written to scan for occurrences of this bug, since it's really easy to accidentally run into. But that should probably be done upstream.
Requirements
Changelog
🆑