Skip to content

Conversation

@gabritto
Copy link
Contributor

Fixes test to avoid new errors introduced by this TS PR merged for TS 5.7.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 22, 2024

@gabritto Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70357,
  "author": "gabritto",
  "headCommitOid": "aa089805134a0dc14ef4c7f56da6a2f86023f6ff",
  "mergeBaseOid": "3553dd5f3053ef5ea1f306c30baa46d12eb7a06f",
  "lastPushDate": "2024-08-22T19:04:39.000Z",
  "lastActivityDate": "2024-08-23T17:48:50.000Z",
  "mergeOfferDate": "2024-08-22T19:21:14.000Z",
  "mergeRequestDate": "2024-08-23T17:48:50.000Z",
  "mergeRequestUser": "gabritto",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "nodal",
      "kind": "edit",
      "files": [
        {
          "path": "types/nodal/nodal-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "charrondev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2024-08-22T19:20:39.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2305445448,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @charrondev — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 22, 2024
@typescript-bot
Copy link
Contributor

@gabritto: Everything looks good here. I am ready to merge this PR (at aa08980) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@charrondev: you can do this too.)

@gabritto
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit e573426 into DefinitelyTyped:master Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants