-
Notifications
You must be signed in to change notification settings - Fork 30.5k
[meteor,styled-components] Fix TS 4.7 compat issues #59560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59560,
"author": "eps1lon",
"headCommitOid": "746b79f78fa36cbd536660748e92399b62830413",
"mergeBaseOid": "b92cbb35c8cb01cc2150736ec8b8640c6af3b085",
"lastPushDate": "2022-04-05T12:25:15.000Z",
"lastActivityDate": "2022-04-05T12:31:46.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "meteor",
"kind": "edit",
"files": [
{
"path": "types/meteor/mongo.d.ts",
"kind": "definition"
}
],
"owners": [
"barbatus",
"fullflavedave",
"orefalo",
"dagatsoin",
"ardatan",
"stefanholzapfel",
"andrei-markeev",
"lmachens",
"gunn",
"alesn",
"perbergland",
"nicu-chiciuc",
"ebroder",
"radekmie",
"wadamek65",
"MacRusher",
"ToastHawaii",
"edemaine"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "styled-components",
"kind": "edit",
"files": [
{
"path": "types/styled-components/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Igorbek",
"Igmat",
"Jessidhia",
"jkillian",
"eps1lon",
"wagerfield",
"Lazyuki",
"lifeiscontent"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 1082340813,
"ciResult": "pass"
} |
|
🔔 @barbatus @fullflavedave @orefalo @dagatsoin @ardatan @stefanholzapfel @andrei-markeev @lmachens @gunn @alesn @perbergland @nicu-chiciuc @ebroder @radekmie @wadamek65 @MacRusher @ToastHawaii @edemaine @Igorbek @Igmat @Jessidhia @jkillian @wagerfield @Lazyuki @lifeiscontent — please review this PR in the next few days. Be sure to explicitly select |
|
@eps1lon The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@eps1lon mongodb v4.5.0 is released. This one can be resolved, right? |
7b60491 to
5cfe67e
Compare
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. styled-components (unpkg)was missing the following properties:
|
|
merged with #56210 stack. |
Fixes issues with TypeScript 4.7 canary (microsoft/TypeScript#48366 specifically) that are blocking #56210
Needed to combine
meteorandstyled-componentsdue to cyclic dependencies.