Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Mar 29, 2022

Fixes issues with TypeScript 4.7 canary (microsoft/TypeScript#48366 specifically) that are blocking #56210

Needed to combine meteor and styled-components due to cyclic dependencies.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 29, 2022

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 59560,
  "author": "eps1lon",
  "headCommitOid": "746b79f78fa36cbd536660748e92399b62830413",
  "mergeBaseOid": "b92cbb35c8cb01cc2150736ec8b8640c6af3b085",
  "lastPushDate": "2022-04-05T12:25:15.000Z",
  "lastActivityDate": "2022-04-05T12:31:46.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "meteor",
      "kind": "edit",
      "files": [
        {
          "path": "types/meteor/mongo.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "barbatus",
        "fullflavedave",
        "orefalo",
        "dagatsoin",
        "ardatan",
        "stefanholzapfel",
        "andrei-markeev",
        "lmachens",
        "gunn",
        "alesn",
        "perbergland",
        "nicu-chiciuc",
        "ebroder",
        "radekmie",
        "wadamek65",
        "MacRusher",
        "ToastHawaii",
        "edemaine"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "styled-components",
      "kind": "edit",
      "files": [
        {
          "path": "types/styled-components/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Igorbek",
        "Igmat",
        "Jessidhia",
        "jkillian",
        "eps1lon",
        "wagerfield",
        "Lazyuki",
        "lifeiscontent"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1082340813,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added The CI failed When GH Actions fails Untested Change This PR does not touch tests labels Mar 29, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 29, 2022

🔔 @barbatus @fullflavedave @orefalo @dagatsoin @ardatan @stefanholzapfel @andrei-markeev @lmachens @gunn @alesn @perbergland @nicu-chiciuc @ebroder @radekmie @wadamek65 @MacRusher @ToastHawaii @edemaine @Igorbek @Igmat @Jessidhia @jkillian @wagerfield @Lazyuki @lifeiscontent — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

@eps1lon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@reichhartd
Copy link
Contributor

@eps1lon mongodb v4.5.0 is released. This one can be resolved, right?

@eps1lon eps1lon force-pushed the fix/ts-4.7/meteor branch from 7b60491 to 5cfe67e Compare April 5, 2022 12:21
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Apr 5, 2022
@eps1lon eps1lon changed the title [meteor] Fix TS 4.7 compat issues [meteor,styled-components] Fix TS 4.7 compat issues Apr 5, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

styled-components (unpkg)

was missing the following properties:

  1. StyleSheetConsumer
  2. StyleSheetContext
  3. version

Generated by 🚫 dangerJS against 746b79f

@eps1lon
Copy link
Collaborator Author

eps1lon commented Apr 7, 2022

merged with #56210 stack.

@eps1lon eps1lon closed this Apr 7, 2022
@eps1lon eps1lon deleted the fix/ts-4.7/meteor branch April 7, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants