add grant-type assertions for jwt-bearer #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rant-type' into add-jwt-assertion-grant-type
nullfunc
changed the title
lionello
approved these changes
Sep 8, 2025
| const json = (await tokens.json()) as any | ||
| if (!tokens.ok) { | ||
| return { | ||
| err: new InvalidJWTError(), |
There was a problem hiding this comment.
InvalidJWTError is a bit too specific. Lots of other reasons why this could fail.
| @@ -173,7 +173,7 @@ export function CodeProvider< | |||
| const action = fd.get("action")?.toString() | |||
|
|
|||
| if (action === "request" || action === "resend") { | |||
| const claims = Object.fromEntries(fd) as Claims | |||
| const claims = Object.fromEntries(fd.entries()) as Claims | |||
There was a problem hiding this comment.
when I see fromX(something.toX()) I wonder if it's a no-op and there's a more direct way to get what we need.
packages/openauth/tsconfig.json
Outdated
| @@ -7,7 +7,8 @@ | |||
| "module": "NodeNext", | |||
| "moduleResolution": "NodeNext", | |||
| "jsx": "react-jsx", | |||
| "jsxImportSource": "hono/jsx" | |||
| "jsxImportSource": "hono/jsx", | |||
| "types": ["node", "bun"] | |||
There was a problem hiding this comment.
Sus: it's either node or bun, not both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for grant-type assertions of jwts. jwk verifications is done but the custom success() handler does custom validation before access and refresh tokens are generated.