Skip to content

fix: Docker build used Go version from go.mod #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

fix: Docker build used Go version from go.mod #1416

merged 1 commit into from
Sep 10, 2025

Conversation

lionello
Copy link
Member

@lionello lionello commented Sep 9, 2025 •
edited
Loading

Description

This address the build failure in https://github.com/DefangLabs/defang/actions/runs/17596287811/job/49989520894#step:6:158

0.137 go: go.mod requires go >= 1.24 (running go 1.23.12; GOTOOLCHAIN=local)

Fix is to get the required Go version from go.mod and pass the Go version to Docker as a build arg.

Linked Issues

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

@lionello lionello requested a review from nullfunc as a code owner September 9, 2025 22:11
@lionello lionello requested review from jordanstephens and nullfunc and removed request for nullfunc September 9, 2025 22:11
@lionello lionello merged commit 98ae13d into main Sep 10, 2025
13 checks passed
@lionello lionello deleted the lio/match-go_version branch September 10, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanstephens jordanstephens jordanstephens approved these changes

@nullfunc nullfunc nullfunc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionello @jordanstephens @nullfunc