chore: Refactor row count to be provided by the datagrid factory #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
even-wei
approved these changes
Dec 10, 2025
Contributor
even-wei
left a comment
even-wei
left a comment
There was a problem hiding this comment.
Amazing! Looks really good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Refactor
What this PR does / why we need it:
Pull Row Count & Row Count Diff into the dataGrid library to ensure it is handled in the same method
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Added and Remove Models will now be visually annotated with green and red cell backgrounds, same as the other diff representations