Feature/refactor run results #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add in `createDataGrid` - Begin adding in util and column functions for grids Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
- Refactor `toDataDiffGrid` and `toValueDiffGrid` to use the new row generation method Signed-off-by: Jared Scott <[email protected]>
…lueDiffGrid`. Rename querydiff.tsx and valuediff.tsx to querydiff.ts and valuediff.ts Signed-off-by: Jared Scott <[email protected]>
….tsx Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
…nerators, and rename to toDataDiffGrid.ts and toValueDiffGrid.ts to be clear Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
…ange to toDataGrid.ts Signed-off-by: Jared Scott <[email protected]>
Signed-off-by: Jared Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Refactor
What this PR does / why we need it:
Refactor and reduce complexity of the
toDataGrid,toDataGridDiff, andtoValueDiffGridmethods. Introduce shared components that can be used across all.sharedmethods as well as dataGrid factory functionsWhich issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE