Update 128 bit logging enabled tests and disable stable config tests #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhlidd
changed the title
mabdinur
approved these changes
Mar 5, 2025
Contributor
mabdinur
left a comment
mabdinur
left a comment
There was a problem hiding this comment.
Left some questions and minor suggestions. Feel free to merge the PR when CI is green.
tests/test_config_consistency.py
Outdated
Comment on lines
562
to
564
| # dd-trace-java stores injected trace information under the "mdc" key | ||
| if context.library.library == "java": | ||
| log_msg = log_msg.get("mdc") |
Contributor
There was a problem hiding this comment.
Can we move this logic to parse_log_injection_message so we can use use it in tests
Comment on lines
+1827
to
+1828
| '*': incomplete_test_app (weblog endpoint not implemented) | ||
| 'spring-boot-3-native': missing_feature |
Contributor
There was a problem hiding this comment.
Are we planning to enable the 128bit logging tests in this PR?
Suggested change
| '*': incomplete_test_app (weblog endpoint not implemented) | |
| 'spring-boot-3-native': missing_feature | |
| '*': incomplete_test_app (weblog endpoint not implemented) | |
| 'spring-boot-3-native': v1.48.0.dev |
Contributor
Author
There was a problem hiding this comment.
Oh we could do it like this, but I was going open a new PR to enable all tests together anyways. This was just to update the manifests to help Java CI pass
robertomonteromiguel
pushed a commit
that referenced
this pull request
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update 128bit logging enabled tests to consider the Java edge case. Update and disable stable config Java tests to allow CI to pass on the following dd-trace-java PR that updates the default value of
DD_LOGS_INJECTION. Stable Config tests will be enabled in a future PR following the merge of the above dd-trace-java PR.Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present