Skip to content

Commit dc2f417

Browse files
authored
Update postgresqlreceiver vacuum metric unit to vacuum not vacuums (open-telemetry#43272)
Updating the unit of the metric `postgresql.table.vacuum.count` in `postgresqlreceiver` to be `vacuum` instead of `vacuums`, to comply with the semantic conventions. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes: [open-telemetry#43207](open-telemetry#43207) <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
1 parent 73e3826 commit dc2f417

25 files changed

+103
-76
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
7+
component: receiver/postgresql
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: "Change the unit of the metric `postgresql.table.vacuum.count` to be `vacuum` instead of vacuums"
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [43272]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

receiver/postgresqlreceiver/documentation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ Number of times a table has manually been vacuumed.
212212
213213
| Unit | Metric Type | Value Type | Aggregation Temporality | Monotonic | Stability |
214214
| ---- | ----------- | ---------- | ----------------------- | --------- | --------- |
215-
| {vacuums} | Sum | Int | Cumulative | true | development |
215+
| {vacuum} | Sum | Int | Cumulative | true | development |
216216
217217
### postgresql.wal.age
218218

receiver/postgresqlreceiver/internal/metadata/generated_metrics.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/postgresqlreceiver/internal/metadata/generated_metrics_test.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

receiver/postgresqlreceiver/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ metrics:
477477
stability:
478478
level: development
479479
enabled: true
480-
unit: "{vacuums}"
480+
unit: "{vacuum}"
481481
sum:
482482
aggregation_temporality: cumulative
483483
monotonic: true

receiver/postgresqlreceiver/testdata/integration/expected_all_db.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ resourceMetrics:
798798
startTimeUnixNano: "1000000"
799799
timeUnixNano: "2000000"
800800
isMonotonic: true
801-
unit: '{vacuums}'
801+
unit: '{vacuum}'
802802
scope:
803803
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
804804
version: latest
@@ -958,7 +958,7 @@ resourceMetrics:
958958
startTimeUnixNano: "1000000"
959959
timeUnixNano: "2000000"
960960
isMonotonic: true
961-
unit: '{vacuums}'
961+
unit: '{vacuum}'
962962
scope:
963963
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
964964
version: latest
@@ -1118,7 +1118,7 @@ resourceMetrics:
11181118
startTimeUnixNano: "1000000"
11191119
timeUnixNano: "2000000"
11201120
isMonotonic: true
1121-
unit: '{vacuums}'
1121+
unit: '{vacuum}'
11221122
scope:
11231123
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
11241124
version: latest
@@ -1278,7 +1278,7 @@ resourceMetrics:
12781278
startTimeUnixNano: "1000000"
12791279
timeUnixNano: "2000000"
12801280
isMonotonic: true
1281-
unit: '{vacuums}'
1281+
unit: '{vacuum}'
12821282
scope:
12831283
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
12841284
version: latest

receiver/postgresqlreceiver/testdata/integration/expected_all_db_connpool.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ resourceMetrics:
312312
startTimeUnixNano: "1706802467703361527"
313313
timeUnixNano: "1706802526712082422"
314314
isMonotonic: true
315-
unit: '{vacuums}'
315+
unit: '{vacuum}'
316316
scope:
317317
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
318318
version: latest
@@ -472,7 +472,7 @@ resourceMetrics:
472472
startTimeUnixNano: "1706802467703361527"
473473
timeUnixNano: "1706802526712082422"
474474
isMonotonic: true
475-
unit: '{vacuums}'
475+
unit: '{vacuum}'
476476
scope:
477477
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
478478
version: latest
@@ -857,7 +857,7 @@ resourceMetrics:
857857
startTimeUnixNano: "1706802467703361527"
858858
timeUnixNano: "1706802526712082422"
859859
isMonotonic: true
860-
unit: '{vacuums}'
860+
unit: '{vacuum}'
861861
scope:
862862
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
863863
version: latest
@@ -1017,7 +1017,7 @@ resourceMetrics:
10171017
startTimeUnixNano: "1706802467703361527"
10181018
timeUnixNano: "1706802526712082422"
10191019
isMonotonic: true
1020-
unit: '{vacuums}'
1020+
unit: '{vacuum}'
10211021
scope:
10221022
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
10231023
version: latest

receiver/postgresqlreceiver/testdata/integration/expected_all_db_schemaattr.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ resourceMetrics:
801801
startTimeUnixNano: "1000000"
802802
timeUnixNano: "2000000"
803803
isMonotonic: true
804-
unit: '{vacuums}'
804+
unit: '{vacuum}'
805805
scope:
806806
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
807807
version: latest
@@ -964,7 +964,7 @@ resourceMetrics:
964964
startTimeUnixNano: "1000000"
965965
timeUnixNano: "2000000"
966966
isMonotonic: true
967-
unit: '{vacuums}'
967+
unit: '{vacuum}'
968968
scope:
969969
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
970970
version: latest
@@ -1127,7 +1127,7 @@ resourceMetrics:
11271127
startTimeUnixNano: "1000000"
11281128
timeUnixNano: "2000000"
11291129
isMonotonic: true
1130-
unit: '{vacuums}'
1130+
unit: '{vacuum}'
11311131
scope:
11321132
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
11331133
version: latest
@@ -1290,7 +1290,7 @@ resourceMetrics:
12901290
startTimeUnixNano: "1000000"
12911291
timeUnixNano: "2000000"
12921292
isMonotonic: true
1293-
unit: '{vacuums}'
1293+
unit: '{vacuum}'
12941294
scope:
12951295
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
12961296
version: latest

receiver/postgresqlreceiver/testdata/integration/expected_multi_db.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -641,7 +641,7 @@ resourceMetrics:
641641
startTimeUnixNano: "1000000"
642642
timeUnixNano: "2000000"
643643
isMonotonic: true
644-
unit: '{vacuums}'
644+
unit: '{vacuum}'
645645
scope:
646646
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
647647
version: latest
@@ -801,7 +801,7 @@ resourceMetrics:
801801
startTimeUnixNano: "1000000"
802802
timeUnixNano: "2000000"
803803
isMonotonic: true
804-
unit: '{vacuums}'
804+
unit: '{vacuum}'
805805
scope:
806806
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
807807
version: latest
@@ -961,7 +961,7 @@ resourceMetrics:
961961
startTimeUnixNano: "1000000"
962962
timeUnixNano: "2000000"
963963
isMonotonic: true
964-
unit: '{vacuums}'
964+
unit: '{vacuum}'
965965
scope:
966966
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
967967
version: latest
@@ -1121,7 +1121,7 @@ resourceMetrics:
11211121
startTimeUnixNano: "1000000"
11221122
timeUnixNano: "2000000"
11231123
isMonotonic: true
1124-
unit: '{vacuums}'
1124+
unit: '{vacuum}'
11251125
scope:
11261126
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
11271127
version: latest

receiver/postgresqlreceiver/testdata/integration/expected_multi_db_connpool.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ resourceMetrics:
155155
startTimeUnixNano: "1706802402706723341"
156156
timeUnixNano: "1706802461712893428"
157157
isMonotonic: true
158-
unit: '{vacuums}'
158+
unit: '{vacuum}'
159159
scope:
160160
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
161161
version: latest
@@ -315,7 +315,7 @@ resourceMetrics:
315315
startTimeUnixNano: "1706802402706723341"
316316
timeUnixNano: "1706802461712893428"
317317
isMonotonic: true
318-
unit: '{vacuums}'
318+
unit: '{vacuum}'
319319
scope:
320320
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
321321
version: latest
@@ -700,7 +700,7 @@ resourceMetrics:
700700
startTimeUnixNano: "1706802402706723341"
701701
timeUnixNano: "1706802461712893428"
702702
isMonotonic: true
703-
unit: '{vacuums}'
703+
unit: '{vacuum}'
704704
scope:
705705
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
706706
version: latest
@@ -860,7 +860,7 @@ resourceMetrics:
860860
startTimeUnixNano: "1706802402706723341"
861861
timeUnixNano: "1706802461712893428"
862862
isMonotonic: true
863-
unit: '{vacuums}'
863+
unit: '{vacuum}'
864864
scope:
865865
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/postgresqlreceiver
866866
version: latest

0 commit comments

Comments
 (0)