Skip to content

Upgrading libddwaf to 1.29.0 #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jandro996 merged 4 commits into from
Oct 9, 2025
Merged

Upgrading libddwaf to 1.29.0 #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f576ab
Bump libddwaf submodule to 1.29.0
jandro996 Oct 7, 2025
25a202f
Update version
jandro996 Oct 7, 2025
c6ba6c4
Update version
jandro996 Oct 8, 2025
5cb38c8
Change version
jandro996 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ defaults:
env:
buildType: RelWithDebInfo
tempdir: ${{ github.workspace }}/build
libddwafVersion: 1.28.1
libddwafVersion: 1.29.0
jobs:
Spotless:
name: spotless
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ repositories {
}

group 'io.sqreen'
version '17.1.0'
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a major version upgrade?, AFAIK there are no breaking API changes right?

Copy link
Member Author

@jandro996 jandro996 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with a major bump out of lack of knowledge :S
Since the last one was done because it coincided with a WAF minor, I assumed we were following that pattern. Or is there actually no relation between the WAF versioning and libddwaf-java?

BTW I'm going to change it to a minor

version '17.2.0'

sourceCompatibility = 1.8
targetCompatibility = 1.8
Expand Down
2 changes: 1 addition & 1 deletion libddwaf
Open in desktop
Submodule libddwaf updated 47 files
+69 −0 CHANGELOG.md
+3 −0 cmake/objects.cmake
+5 −1 schema/actions.json
+6 −24 schema/events.json
+21 −13 schema/result.json
+29 −0 src/builder/checksum_builder.cpp
+19 −0 src/builder/checksum_builder.hpp
+39 −7 src/builder/processor_builder.cpp
+8 −2 src/builder/processor_builder.hpp
+27 −0 src/checksum/base.hpp
+41 −0 src/checksum/luhn_checksum.cpp
+29 −0 src/checksum/luhn_checksum.hpp
+16 −0 src/configuration/actions_parser.cpp
+8 −2 src/configuration/common/configuration.hpp
+5 −3 src/configuration/common/expression_parser.cpp
+23 −3 src/configuration/common/matcher_parser.cpp
+3 −1 src/configuration/common/matcher_parser.hpp
+13 −4 src/configuration/processor_override_parser.cpp
+1 −1 src/configuration/processor_parser.cpp
+1 −1 src/matcher/phrase_match.cpp
+4 −8 src/matcher/regex_match.cpp
+0 −2 src/matcher/regex_match.hpp
+62 −0 src/matcher/regex_match_with_checksum.cpp
+47 −0 src/matcher/regex_match_with_checksum.hpp
+40 −13 src/serializer.cpp
+0 −1 src/transformer/manager.hpp
+37 −2 tests/common/gtest_utils.cpp
+1 −0 tests/common/gtest_utils.hpp
+336 −6 tests/integration/actions/test.cpp
+5 −0 tests/integration/context/test.cpp
+12 −6 tests/integration/exclusion/rule_filter/test.cpp
+52 −49 tests/integration/interface/waf/test.cpp
+1 −0 tests/integration/matchers/regex_match/test.cpp
+190 −0 tests/integration/matchers/regex_match_with_checksum/test.cpp
+24 −0 tests/integration/processors/overrides/ruleset/scanners.json
+535 −10 tests/integration/processors/overrides/test.cpp
+42 −28 tests/integration/rules/custom_rules/test.cpp
+52 −0 tests/unit/checksum/luhn_checksum_test.cpp
+217 −9 tests/unit/configuration/processor_override_parser_test.cpp
+0 −0 tests/unit/matcher/exact_match_test.cpp
+26 −0 tests/unit/matcher/phrase_match_test.cpp
+6 −0 tests/unit/matcher/regex_match_test.cpp
+110 −0 tests/unit/matcher/regex_match_with_checksum_test.cpp
+15 −12 tests/unit/serializer_test.cpp
+2 −1 validator/tests/exclusions/rule_filter/conditional/010_rule_no_exclusions.yaml
+2 −1 validator/tests/rules/actions/001_rule1_match_with_actions.yaml
+1 −1 version
2 changes: 1 addition & 1 deletion src/main/java/com/datadog/ddwaf/Waf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import org.slf4j.LoggerFactory;

public final class Waf {
public static final String LIB_VERSION = "1.28.1";
public static final String LIB_VERSION = "1.29.0";

private static final Logger LOGGER = LoggerFactory.getLogger(Waf.class);
static final boolean EXIT_ON_LEAK;
Expand Down