Skip to content

Change keep to Boolean object so that null is a valid value #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sezen-datadog wants to merge 1 commit into from
Closed

Change keep to Boolean object so that null is a valid value #183

sezen-datadog wants to merge 1 commit into from

Conversation

@sezen-datadog
Copy link
Contributor

@sezen-datadog sezen-datadog commented Sep 19, 2025 •
edited
Loading

This allows the waf to decide whether or not it decides to keep

@sezen-datadog sezen-datadog requested a review from a team as a code owner September 19, 2025 14:28
jandro996
jandro996 reviewed Sep 19, 2025
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments!

Do we have any tests that validate the default value and check this behavior explicitly?
Also, it might be helpful to add a short description in the PR explaining the motivation behind the change, it could be useful for reviewers now and also in the future if we need to look back at this.

@sezen-datadog
Copy link
Contributor Author

sezen-datadog commented Sep 19, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Sep 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-09-19 15:22:02 UTC ℹ️ Start processing command /merge

2025-09-19 15:22:10 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-19 19:23:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandro996 jandro996 jandro996 left review comments

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/asm-java

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sezen-datadog @jandro996