Upgrading libddwaf to 1.28.0 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezen-datadog
force-pushed
the
sezen.leblay/ugrade-libddwaf-1.28.0
branch
from
1e9bbf0 to
9f5e38c
Compare
| shouldFail(InvalidRuleSetException) { | ||
| wafDiagnostics = builder.addOrUpdateConfig('test', [version: '0.0', events: []]) | ||
| } | ||
| // libddwaf 1.27.0+ now accepts empty configurations instead of throwing an exception |
Member
There was a problem hiding this comment.
We might want to update dd-trace-java too as it skipping empty configs with some ugly code
Contributor
Author
There was a problem hiding this comment.
yes I’m adapting it right now
manuel-alvarez-alvarez
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APPSEC-58796
statuses are now longs