-
Notifications
You must be signed in to change notification settings - Fork 4
Map keep and events object to use in tracer, return rules_compat output #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e6a4c2f to
405df75
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
============================================
- Coverage 58.55% 57.42% -1.14%
- Complexity 134 175 +41
============================================
Files 34 34
Lines 3458 3643 +185
Branches 780 819 +39
============================================
+ Hits 2025 2092 +67
- Misses 900 977 +77
- Partials 533 574 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
63aca96 to
c496111
Compare
c7d7369 to
194ce0c
Compare
c496111 to
88d5db2
Compare
194ce0c to
4c57909
Compare
34a1e95 to
0931603
Compare
54e023c to
4c57909
Compare
f331213 to
ec9d0f5
Compare
d9f8fb4 to
7611e51
Compare
aa43d3b to
a206467
Compare
c8072da to
def4bfc
Compare
4d1f5ca to
7224f8d
Compare
…nd refactor derivatives to attributes
7224f8d to
5cd883f
Compare
|
I’m probably missing some context, but I don’t quite understand this part:
From what I can see, the attribute in the mapping is still keep, not manual-keep. |
1478aab to
5c93e43
Compare
jandro996
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
APPSEC-57260
derivatives are mapped to attributes with the new libddwaf version
When libddwaf returns keep, we have to flag the attribute manual-keep
events, consists in an array of events generated as a result of the rule evaluation process.
actions consists in a map of the actions, and their parameters, generated as a result of the rule evaluation process.
all three of these must be exposed to the tracer for us to be able to evaluate libddwaf results
rules_compat is a temporary attribute that holds the new rules return for libddwaf. this will eventually be merged to the rules attribute.