Skip to content

Conversation

@sezen-datadog
Copy link
Contributor

@sezen-datadog sezen-datadog commented Jul 7, 2025

APPSEC-57260

derivatives are mapped to attributes with the new libddwaf version
When libddwaf returns keep, we have to flag the attribute manual-keep
events, consists in an array of events generated as a result of the rule evaluation process.
actions consists in a map of the actions, and their parameters, generated as a result of the rule evaluation process.
all three of these must be exposed to the tracer for us to be able to evaluate libddwaf results

rules_compat is a temporary attribute that holds the new rules return for libddwaf. this will eventually be merged to the rules attribute.

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch from e6a4c2f to 405df75 Compare July 7, 2025 14:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2025

Codecov Report

❌ Patch coverage is 55.93220% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.42%. Comparing base (47c2db6) to head (1478aab).
⚠️ Report is 65 commits behind head on master.

Files with missing lines Patch % Lines
src/main/c/output.c 37.68% 30 Missing and 13 partials ⚠️
src/main/c/waf_jni.c 78.04% 2 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     58.55%   57.42%   -1.14%     
- Complexity      134      175      +41     
============================================
  Files            34       34              
  Lines          3458     3643     +185     
  Branches        780      819      +39     
============================================
+ Hits           2025     2092      +67     
- Misses          900      977      +77     
- Partials        533      574      +41     
Flag Coverage Δ
helper 57.42% <55.93%> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch 3 times, most recently from 63aca96 to c496111 Compare July 8, 2025 11:47
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/upgrade-libddwaf-version-26 branch from c7d7369 to 194ce0c Compare July 8, 2025 11:50
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch from c496111 to 88d5db2 Compare July 8, 2025 11:51
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/upgrade-libddwaf-version-26 branch from 194ce0c to 4c57909 Compare July 8, 2025 11:53
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch 3 times, most recently from 34a1e95 to 0931603 Compare July 8, 2025 12:04
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/upgrade-libddwaf-version-26 branch from 54e023c to 4c57909 Compare July 8, 2025 12:09
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch 5 times, most recently from f331213 to ec9d0f5 Compare July 9, 2025 14:02
Base automatically changed from sezen.leblay/upgrade-libddwaf-version-26 to master July 10, 2025 08:05
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch 9 times, most recently from d9f8fb4 to 7611e51 Compare July 11, 2025 14:30
@sezen-datadog sezen-datadog changed the title Map keep object to use in tracer Map keep and events object to use in tracer, return rules_compat output Jul 11, 2025
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch 2 times, most recently from aa43d3b to a206467 Compare July 15, 2025 08:42
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch 2 times, most recently from c8072da to def4bfc Compare July 15, 2025 10:15
@sezen-datadog sezen-datadog marked this pull request as ready for review July 15, 2025 10:18
@sezen-datadog sezen-datadog requested a review from a team as a code owner July 15, 2025 10:18
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch 3 times, most recently from 4d1f5ca to 7224f8d Compare July 15, 2025 12:12
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch from 7224f8d to 5cd883f Compare July 15, 2025 12:13
@sezen-datadog sezen-datadog requested a review from jandro996 July 21, 2025 08:36
@jandro996
Copy link
Member

I’m probably missing some context, but I don’t quite understand this part:

When libddwaf returns keep, we have to flag the attribute manual-keep.

From what I can see, the attribute in the mapping is still keep, not manual-keep.

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/jwt-upgrade branch from 1478aab to 5c93e43 Compare August 26, 2025 10:23
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sezen-datadog sezen-datadog merged commit 1d848ed into master Aug 28, 2025
42 checks passed
@sezen-datadog sezen-datadog deleted the sezen.leblay/jwt-upgrade branch August 28, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants