Skip to content

Fix unsafe access to CodeCache #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbachorik merged 1 commit into from
Feb 4, 2025
Merged

Fix unsafe access to CodeCache #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ddprof-lib/src/main/cpp/stackWalker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ int StackWalker::walkDwarf(void *ucontext, const void **callchain,
}
if (CodeHeap::contains(pc) && !(depth == 0 && frame.unwindAtomicStub(pc))) {
const void* page_start = (const void*)((uintptr_t)pc & ~0xfffUL);
frame.adjustSP(page_start, pc, sp);
// Don't dereference pc as it may point to unreadable memory
// frame.adjustSP(page_start, pc, sp);
java_ctx->set(pc, sp, fp);
break;
}
Expand Down
Loading