Skip to content

Default to non-ASGCT samplers on J9 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbachorik merged 2 commits into from
Nov 14, 2024
Merged

Default to non-ASGCT samplers on J9 #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4142a8b
Default to GetAllStacktraces sampler on J9 when 'cpu' event is specified
jbachorik Nov 12, 2024
7426d82
Default to GetAllStacktraces wallclock sampler on J9 when 'jvmti' is …
jbachorik Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions ddprof-lib/src/main/cpp/profiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,16 +1016,11 @@ Engine *Profiler::selectCpuEngine(Arguments &args) {
return &noop_engine;
} else if (args._cpu >= 0 || strcmp(args._event, EVENT_CPU) == 0) {
if (VM::isOpenJ9()) {
if (!J9Ext::can_use_ASGCT()) {
if (!J9Ext::is_jvmti_jmethodid_safe()) {
Log::warn("Safe jmethodID access is not available on this JVM. Using "
"CPU profiler on your own risk.");
}
return &j9_engine;
} else if (!J9Ext::is_jmethodid_safe()) {
if (!J9Ext::is_jvmti_jmethodid_safe()) {
Log::warn("Safe jmethodID access is not available on this JVM. Using "
"CPU profiler on your own risk.");
}
return &j9_engine;
}
return !ctimer.check(args)
? (Engine *)&ctimer
Expand All @@ -1048,16 +1043,15 @@ Engine *Profiler::selectWallEngine(Arguments &args) {
return &noop_engine;
}
if (VM::isOpenJ9()) {
if (!J9Ext::can_use_ASGCT()) {
if (args._wallclock_sampler == JVMTI) {
if (!J9Ext::is_jvmti_jmethodid_safe()) {
Log::warn("Safe jmethodID access is not available on this JVM. Using "
"wallclock profiler on your own risk.");
}
j9_engine.sampleIdleThreads();
return (Engine *)&j9_engine;
} else if (!J9Ext::is_jmethodid_safe()) {
Log::warn("Safe jmethodID access is not available on this JVM. Using "
"wallclock profiler on your own risk.");
} else {
return (Engine *)&wall_asgct_engine;
}
}
switch (args._wallclock_sampler) {
Expand Down
Loading