Skip to content

Conversation

houman-moallemi
Copy link

@houman-moallemi houman-moallemi commented Aug 12, 2025

What this PR does / why we need it:

Core Issue

At the moment it's not possible to configure the PodDisruptionBudget for the cluster agent. The existing configuration is hardcoded and set to minAvailable: 1 which isn't highly available.

By allowing users to set minAvailable or maxUnavailable we can achieve proper HA in any respective environment.
With this example configuration we can have a highly available cluster agent.

  • CA replicas: 3
  • PDB maxUnavailable: 1

Interface Consistency

In order to have a consistent interface in the chart, the same changes for clusterAgent are applied to clusterChecksRunner as well. Previous behavior are kept and changes are backwards compatible.

Both createPodDisruptionBudget are copied into the new pdb block so we can deprecate the additional flag in a future minor release.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@houman-moallemi houman-moallemi marked this pull request as ready for review August 12, 2025 07:31
@houman-moallemi houman-moallemi requested a review from a team as a code owner August 12, 2025 07:31
@houman-moallemi houman-moallemi marked this pull request as draft August 12, 2025 07:31
@houman-moallemi houman-moallemi force-pushed the patch-1 branch 2 times, most recently from 5969896 to b989711 Compare August 12, 2025 08:11
@houman-moallemi houman-moallemi marked this pull request as ready for review August 22, 2025 10:08
@houman-moallemi houman-moallemi force-pushed the patch-1 branch 3 times, most recently from d0c701f to 5ffba0b Compare August 22, 2025 10:13
@houman-moallemi houman-moallemi changed the title feat: Made PDB minAvailable configurable feat: Made PodDisruptionBudget configurable Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants