feat: Made PodDisruptionBudget
configurable
#2000
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Core Issue
At the moment it's not possible to configure the
PodDisruptionBudget
for the cluster agent. The existing configuration is hardcoded and set tominAvailable: 1
which isn't highly available.By allowing users to set
minAvailable
ormaxUnavailable
we can achieve proper HA in any respective environment.With this example configuration we can have a highly available cluster agent.
replicas: 3
maxUnavailable: 1
Interface Consistency
In order to have a consistent interface in the chart, the same changes for
clusterAgent
are applied toclusterChecksRunner
as well. Previous behavior are kept and changes are backwards compatible.Both
createPodDisruptionBudget
are copied into the newpdb
block so we can deprecate the additional flag in a future minor release.Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version
,<chartName>/patch-version
, or<chartName>/no-version-bump
)datadog
ordatadog-operator
chart or value changes, update the test baselines (run:make update-test-baselines
)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md