-
Notifications
You must be signed in to change notification settings - Fork 476
chore(llmobs): deprecate warning and error logs on misuse of llm observability sdk #15838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…llmobs-raise-errors-deprecations
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 205 ± 3 ms. The average import time from base is: 208 ± 3 ms. The import time difference between this PR and base is: -3.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate sabrenner/llmobs-raise-errors-deprecations (64080a2) with baseline 3.19 (81e7988) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.3% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -2.7% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.288µs (SLO: <10.000µs 📉 -97.1%) vs baseline: -1.3% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ add_noaspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.2% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.0% ✅ bytearray_aspectTime: ✅ 1.328µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -0.7% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 1.558µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +4.6% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.4% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.485µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.5% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ bytes_aspectTime: ✅ 1.290µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +1.9% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.9% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.314µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -0.8% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 0.503µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.6% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 0.737µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.7% Memory: ✅ 37.965MB (SLO: <41.500MB -8.5%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 0.442µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.9% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +5.1% ✅ casefold_aspectTime: ✅ 0.740µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -1.0% Memory: ✅ 37.827MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ decode_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.7% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 0.422µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.3% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.5% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.6% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 3.344µs (SLO: <10.000µs 📉 -66.6%) vs baseline: -0.6% Memory: ✅ 37.827MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 3.537µs (SLO: <10.000µs 📉 -64.6%) vs baseline: -0.8% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 0.815µs (SLO: <10.000µs 📉 -91.8%) vs baseline: -1.9% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.603µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +1.2% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 0.344µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +0.1% Memory: ✅ 37.985MB (SLO: <41.500MB -8.5%) vs baseline: +5.1% ✅ index_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.8% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 1.277µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +0.2% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.533µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -1.2% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 2.544µs (SLO: <20.000µs 📉 -87.3%) vs baseline: +0.3% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -1.0% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 2.214µs (SLO: <10.000µs 📉 -77.9%) vs baseline: -0.3% Memory: ✅ 37.808MB (SLO: <41.500MB -8.9%) vs baseline: +4.6% ✅ lower_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.0% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 2.401µs (SLO: <20.000µs 📉 -88.0%) vs baseline: 📈 +10.6% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -1.0% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +4.6% ✅ modulo_aspectTime: ✅ 0.973µs (SLO: <10.000µs 📉 -90.3%) vs baseline: +0.2% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.484µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -0.4% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.948µs (SLO: <10.000µs 📉 -90.5%) vs baseline: -0.9% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.172µs (SLO: <10.000µs 📉 -88.3%) vs baseline: -0.3% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.4% ✅ modulo_noaspectTime: ✅ 0.673µs (SLO: <10.000µs 📉 -93.3%) vs baseline: -1.6% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.898µs (SLO: <10.000µs 📉 -51.0%) vs baseline: +0.3% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.7% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.947µs (SLO: <10.000µs 📉 -90.5%) vs baseline: ~same Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.455µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.0% Memory: ✅ 38.004MB (SLO: <41.500MB -8.4%) vs baseline: +5.2% ✅ rstrip_aspectTime: ✅ 1.877µs (SLO: <20.000µs 📉 -90.6%) vs baseline: ~same Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.1% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 0.489µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.4% Memory: ✅ 37.985MB (SLO: <41.500MB -8.5%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.446µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.6% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 1.734µs (SLO: <10.000µs 📉 -82.7%) vs baseline: +1.3% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 0.929µs (SLO: <10.000µs 📉 -90.7%) vs baseline: +0.9% Memory: ✅ 37.827MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 2.175µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -1.3% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 0.394µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.9% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 2.405µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +0.3% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 0.540µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.9% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.352µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -0.5% Memory: ✅ 37.768MB (SLO: <41.500MB -9.0%) vs baseline: +4.4% ✅ title_noaspectTime: ✅ 0.505µs (SLO: <10.000µs 📉 -94.9%) vs baseline: ~same Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 3.203µs (SLO: <10.000µs 📉 -68.0%) vs baseline: -0.4% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 1.042µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 2.230µs (SLO: <10.000µs 📉 -77.7%) vs baseline: +0.5% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.655µs (SLO: <10.000µs 📉 -53.5%) vs baseline: 📈 +11.3% Memory: ✅ 37.886MB (SLO: <41.000MB -7.6%) vs baseline: +3.8% ✅ ospathbasename_noaspectTime: ✅ 1.085µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.4% Memory: ✅ 37.867MB (SLO: <41.000MB -7.6%) vs baseline: +3.8% ✅ ospathjoin_aspectTime: ✅ 6.002µs (SLO: <10.000µs 📉 -40.0%) vs baseline: -0.5% Memory: ✅ 37.965MB (SLO: <41.000MB -7.4%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.302µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.6% Memory: ✅ 37.926MB (SLO: <41.000MB -7.5%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.428µs (SLO: <10.000µs 📉 -65.7%) vs baseline: -0.1% Memory: ✅ 37.788MB (SLO: <41.000MB -7.8%) vs baseline: +3.9% ✅ ospathnormcase_noaspectTime: ✅ 0.575µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +1.9% Memory: ✅ 37.906MB (SLO: <41.000MB -7.5%) vs baseline: +4.4% ✅ ospathsplit_aspectTime: ✅ 4.729µs (SLO: <10.000µs 📉 -52.7%) vs baseline: ~same Memory: ✅ 37.906MB (SLO: <41.000MB -7.5%) vs baseline: +4.4% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: ~same Memory: ✅ 37.965MB (SLO: <41.000MB -7.4%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.632µs (SLO: <10.000µs 📉 -63.7%) vs baseline: -0.5% Memory: ✅ 38.083MB (SLO: <41.000MB -7.1%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.9% Memory: ✅ 37.827MB (SLO: <41.000MB -7.7%) vs baseline: +3.8% ✅ ospathsplitext_aspectTime: ✅ 5.106µs (SLO: <10.000µs 📉 -48.9%) vs baseline: 📈 +13.1% Memory: ✅ 37.926MB (SLO: <41.000MB -7.5%) vs baseline: +4.2% ✅ ospathsplitext_noaspectTime: ✅ 1.372µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.6% Memory: ✅ 37.945MB (SLO: <41.000MB -7.5%) vs baseline: +4.2% 🟡 Near SLO Breach (1 suite)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.590ms (SLO: <4.750ms -3.4%) vs baseline: -0.8% Memory: ✅ 64.059MB (SLO: <66.500MB -3.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.632ms (SLO: <6.750ms 🟡 -1.7%) vs baseline: +0.1% Memory: ✅ 64.060MB (SLO: <66.500MB -3.7%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: -0.2% Memory: ✅ 64.144MB (SLO: <66.500MB -3.5%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: ~same Memory: ✅ 47.823MB (SLO: <49.500MB -3.4%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.861ms (SLO: <2.000ms -6.9%) vs baseline: ~same Memory: ✅ 44.529MB (SLO: <49.000MB -9.1%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.914ms (SLO: <2.100ms -8.9%) vs baseline: -0.2% Memory: ✅ 48.574MB (SLO: <50.000MB -2.9%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.2% Memory: ✅ 54.361MB (SLO: <56.000MB -2.9%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.350ms (SLO: <3.650ms -8.2%) vs baseline: -0.2% Memory: ✅ 54.438MB (SLO: <56.500MB -3.6%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.346ms (SLO: <3.650ms -8.3%) vs baseline: -0.4% Memory: ✅ 54.364MB (SLO: <60.000MB -9.4%) vs baseline: +4.8%
|
Description
In
ddtrace==4.0.0, we deprecated emitting warning and error logs in favor of raising errors directly. This PR makes sure we emit the correct "deprecation" log for this inddtrace~=3.19so that this is surfaced for users.Testing
None, adds deprecation logs.
Risks
None, the breaking change was released in
ddtrace==4.0.0, and we should have had this initially but did not.