-
Notifications
You must be signed in to change notification settings - Fork 476
refactor(profiling): split header files into h and cc
#15834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aec2c43 to
5efd2a2
Compare
Codeowners resolved as |
9208a36 to
e07acea
Compare
Performance SLOsComparing candidate kowalski/split-into-header-and-cc (e07acea) with baseline main (298218a) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.956µs (SLO: <20.000µs 📉 -10.2%) vs baseline: 📈 +20.5% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 14.855µs (SLO: <20.000µs 📉 -25.7%) vs baseline: -0.2% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.338µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.546µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -1.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_aspectTime: ✅ 18.006µs (SLO: <30.000µs 📉 -40.0%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ bytearray_extend_aspectTime: ✅ 23.916µs (SLO: <30.000µs 📉 -20.3%) vs baseline: +0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 2.724µs (SLO: <10.000µs 📉 -72.8%) vs baseline: -1.3% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ bytearray_noaspectTime: ✅ 1.473µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 16.594µs (SLO: <20.000µs 📉 -17.0%) vs baseline: -0.3% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 1.412µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.8% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 55.437µs (SLO: <70.000µs 📉 -20.8%) vs baseline: -0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.6% ✅ bytesio_noaspectTime: ✅ 3.287µs (SLO: <10.000µs 📉 -67.1%) vs baseline: -0.6% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 14.618µs (SLO: <20.000µs 📉 -26.9%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 2.582µs (SLO: <10.000µs 📉 -74.2%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 14.715µs (SLO: <20.000µs 📉 -26.4%) vs baseline: +1.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 3.156µs (SLO: <10.000µs 📉 -68.4%) vs baseline: -0.7% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 15.639µs (SLO: <30.000µs 📉 -47.9%) vs baseline: -0.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ decode_noaspectTime: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.7% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 18.082µs (SLO: <30.000µs 📉 -39.7%) vs baseline: 📈 +22.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 1.504µs (SLO: <10.000µs 📉 -85.0%) vs baseline: +0.3% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 171.325µs (SLO: <200.000µs 📉 -14.3%) vs baseline: +0.3% Memory: ✅ 42.546MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ format_map_aspectTime: ✅ 190.868µs (SLO: <200.000µs -4.6%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 3.738µs (SLO: <10.000µs 📉 -62.6%) vs baseline: -1.6% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 3.116µs (SLO: <10.000µs 📉 -68.8%) vs baseline: -1.8% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 15.233µs (SLO: <20.000µs 📉 -23.8%) vs baseline: -0.7% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 17.055µs (SLO: <20.000µs 📉 -14.7%) vs baseline: ~same Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 1.560µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +1.1% Memory: ✅ 42.487MB (SLO: <43.250MB 🟡 -1.8%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 20.714µs (SLO: <30.000µs 📉 -31.0%) vs baseline: -1.0% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 2.697µs (SLO: <10.000µs 📉 -73.0%) vs baseline: -0.5% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 17.884µs (SLO: <30.000µs 📉 -40.4%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 2.422µs (SLO: <10.000µs 📉 -75.8%) vs baseline: -0.5% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 17.723µs (SLO: <30.000µs 📉 -40.9%) vs baseline: +0.4% Memory: ✅ 42.684MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +5.1% ✅ lstrip_noaspectTime: ✅ 1.866µs (SLO: <10.000µs 📉 -81.3%) vs baseline: -1.0% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 166.525µs (SLO: <200.000µs 📉 -16.7%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 179.971µs (SLO: <200.000µs 📉 -10.0%) vs baseline: +3.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 168.485µs (SLO: <200.000µs 📉 -15.8%) vs baseline: +0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.157µs (SLO: <200.000µs 📉 -13.9%) vs baseline: +0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 3.643µs (SLO: <10.000µs 📉 -63.6%) vs baseline: -1.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 212.139µs (SLO: <300.000µs 📉 -29.3%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <44.000MB -2.9%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 2.917µs (SLO: <10.000µs 📉 -70.8%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 1.426µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +0.7% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ repr_noaspectTime: ✅ 0.522µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -0.3% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 19.086µs (SLO: <30.000µs 📉 -36.4%) vs baseline: ~same Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 2.046µs (SLO: <10.000µs 📉 -79.5%) vs baseline: +6.3% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 15.820µs (SLO: <20.000µs 📉 -20.9%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.601µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 54.001µs (SLO: <80.000µs 📉 -32.5%) vs baseline: -0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 3.645µs (SLO: <10.000µs 📉 -63.6%) vs baseline: -0.4% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 17.643µs (SLO: <20.000µs 📉 -11.8%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 1.877µs (SLO: <10.000µs 📉 -81.2%) vs baseline: ~same Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ swapcase_aspectTime: ✅ 18.558µs (SLO: <30.000µs 📉 -38.1%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 2.794µs (SLO: <10.000µs 📉 -72.1%) vs baseline: -1.1% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 18.260µs (SLO: <30.000µs 📉 -39.1%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.000MB 🟡 -1.0%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 2.673µs (SLO: <10.000µs 📉 -73.3%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 24.393µs (SLO: <30.000µs 📉 -18.7%) vs baseline: 📈 +18.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 4.363µs (SLO: <10.000µs 📉 -56.4%) vs baseline: +0.5% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.5% ✅ upper_aspectTime: ✅ 17.912µs (SLO: <30.000µs 📉 -40.3%) vs baseline: -0.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 2.417µs (SLO: <10.000µs 📉 -75.8%) vs baseline: -0.8% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.193µs (SLO: <10.000µs 📉 -48.1%) vs baseline: 📈 +22.8% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 4.303µs (SLO: <10.000µs 📉 -57.0%) vs baseline: -0.9% Memory: ✅ 42.369MB (SLO: <43.500MB -2.6%) vs baseline: +4.4% ✅ ospathjoin_aspectTime: ✅ 6.228µs (SLO: <10.000µs 📉 -37.7%) vs baseline: -0.7% Memory: ✅ 42.467MB (SLO: <43.500MB -2.4%) vs baseline: +4.6% ✅ ospathjoin_noaspectTime: ✅ 6.322µs (SLO: <10.000µs 📉 -36.8%) vs baseline: -0.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.642µs (SLO: <10.000µs 📉 -63.6%) vs baseline: +2.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 3.636µs (SLO: <10.000µs 📉 -63.6%) vs baseline: -0.1% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.922µs (SLO: <10.000µs 📉 -50.8%) vs baseline: ~same Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 5.002µs (SLO: <10.000µs 📉 -50.0%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.783µs (SLO: <10.000µs 📉 -62.2%) vs baseline: +0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.750µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +0.9% Memory: ✅ 42.448MB (SLO: <43.500MB -2.4%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.624µs (SLO: <10.000µs 📉 -53.8%) vs baseline: -0.2% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 4.638µs (SLO: <10.000µs 📉 -53.6%) vs baseline: +0.2% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.392µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +14.5% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.3% ✅ 1-count-metrics-100-timesTime: ✅ 199.037µs (SLO: <220.000µs -9.5%) vs baseline: -0.5% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.322µs (SLO: <20.000µs 📉 -83.4%) vs baseline: ~same Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-distribution-metrics-100-timesTime: ✅ 212.686µs (SLO: <230.000µs -7.5%) vs baseline: ~same Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.188µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.3% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.705µs (SLO: <150.000µs -9.5%) vs baseline: -0.4% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.5% ✅ 1-rate-metric-1-timesTime: ✅ 3.172µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +0.9% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 211.863µs (SLO: <250.000µs 📉 -15.3%) vs baseline: +0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 19.947ms (SLO: <22.000ms -9.3%) vs baseline: -0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.249ms (SLO: <2.550ms 📉 -11.8%) vs baseline: ~same Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: +0.5% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.174ms (SLO: <2.550ms 📉 -14.7%) vs baseline: -0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.558µs (SLO: <20.000µs 📉 -77.2%) vs baseline: -1.1% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 174.470µs (SLO: <250.000µs 📉 -30.2%) vs baseline: +0.1% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.179ms (SLO: <2.500ms 📉 -12.9%) vs baseline: +0.2% Memory: ✅ 36.019MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +5.0% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes