-
Notifications
You must be signed in to change notification settings - Fork 476
refactor(profiling): attempt to remove one global #15830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(profiling): attempt to remove one global #15830
Conversation
Codeowners resolved as |
49c34f1 to
c92d987
Compare
b84d796 to
36d16a6
Compare
36d16a6 to
9fa7eaa
Compare
Performance SLOsComparing candidate kowalski/refactor-profiling-attempt-to-remove-one-global (9fa7eaa) with baseline kowalski/refactor-profiling-make-current_tasks-and-current_greenlets-non-global (86b8892) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.919µs (SLO: <20.000µs 📉 -10.4%) vs baseline: 📈 +21.1% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.1% ✅ add_inplace_aspectTime: ✅ 15.004µs (SLO: <20.000µs 📉 -25.0%) vs baseline: +0.9% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.1% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -1.2% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 0.547µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 17.936µs (SLO: <30.000µs 📉 -40.2%) vs baseline: -0.6% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 23.871µs (SLO: <30.000µs 📉 -20.4%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 2.735µs (SLO: <10.000µs 📉 -72.7%) vs baseline: +0.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 1.487µs (SLO: <10.000µs 📉 -85.1%) vs baseline: +1.0% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 16.568µs (SLO: <20.000µs 📉 -17.2%) vs baseline: -0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytes_noaspectTime: ✅ 1.423µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +0.6% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 55.467µs (SLO: <70.000µs 📉 -20.8%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 3.288µs (SLO: <10.000µs 📉 -67.1%) vs baseline: +1.1% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 14.744µs (SLO: <20.000µs 📉 -26.3%) vs baseline: +1.2% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ capitalize_noaspectTime: ✅ 2.601µs (SLO: <10.000µs 📉 -74.0%) vs baseline: +0.6% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 14.701µs (SLO: <20.000µs 📉 -26.5%) vs baseline: +0.7% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 3.142µs (SLO: <10.000µs 📉 -68.6%) vs baseline: -1.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ decode_aspectTime: ✅ 15.481µs (SLO: <30.000µs 📉 -48.4%) vs baseline: -0.8% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 1.613µs (SLO: <10.000µs 📉 -83.9%) vs baseline: -0.2% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 18.174µs (SLO: <30.000µs 📉 -39.4%) vs baseline: 📈 +23.6% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 1.498µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -0.5% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 171.610µs (SLO: <200.000µs 📉 -14.2%) vs baseline: +0.3% Memory: ✅ 42.644MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 190.904µs (SLO: <200.000µs -4.5%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 3.799µs (SLO: <10.000µs 📉 -62.0%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 3.172µs (SLO: <10.000µs 📉 -68.3%) vs baseline: -0.2% Memory: ✅ 42.625MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 15.328µs (SLO: <20.000µs 📉 -23.4%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.1% ✅ index_noaspectTime: ✅ 0.466µs (SLO: <10.000µs 📉 -95.3%) vs baseline: +0.4% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ join_aspectTime: ✅ 17.017µs (SLO: <20.000µs 📉 -14.9%) vs baseline: -0.4% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 1.574µs (SLO: <10.000µs 📉 -84.3%) vs baseline: +1.9% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 20.806µs (SLO: <30.000µs 📉 -30.6%) vs baseline: -0.1% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +5.1% ✅ ljust_noaspectTime: ✅ 2.722µs (SLO: <10.000µs 📉 -72.8%) vs baseline: ~same Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 17.931µs (SLO: <30.000µs 📉 -40.2%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 2.421µs (SLO: <10.000µs 📉 -75.8%) vs baseline: -0.5% Memory: ✅ 42.566MB (SLO: <43.250MB 🟡 -1.6%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 21.651µs (SLO: <30.000µs 📉 -27.8%) vs baseline: 📈 +22.8% Memory: ✅ 42.605MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 1.857µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -0.6% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 166.243µs (SLO: <200.000µs 📉 -16.9%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.657µs (SLO: <200.000µs 📉 -12.7%) vs baseline: +0.1% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.5% ✅ modulo_aspect_for_bytesTime: ✅ 168.446µs (SLO: <200.000µs 📉 -15.8%) vs baseline: -0.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.263µs (SLO: <200.000µs 📉 -13.9%) vs baseline: +0.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 3.663µs (SLO: <10.000µs 📉 -63.4%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 212.083µs (SLO: <300.000µs 📉 -29.3%) vs baseline: ~same Memory: ✅ 42.526MB (SLO: <44.000MB -3.3%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 2.900µs (SLO: <10.000µs 📉 -71.0%) vs baseline: -0.3% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 1.481µs (SLO: <10.000µs 📉 -85.2%) vs baseline: +4.4% Memory: ✅ 42.507MB (SLO: <43.500MB -2.3%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.525µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.5% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 19.137µs (SLO: <30.000µs 📉 -36.2%) vs baseline: +0.9% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 1.914µs (SLO: <10.000µs 📉 -80.9%) vs baseline: -0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ slice_aspectTime: ✅ 15.916µs (SLO: <20.000µs 📉 -20.4%) vs baseline: +0.1% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 0.603µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +1.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 53.904µs (SLO: <80.000µs 📉 -32.6%) vs baseline: -0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 3.651µs (SLO: <10.000µs 📉 -63.5%) vs baseline: ~same Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 17.634µs (SLO: <20.000µs 📉 -11.8%) vs baseline: +0.1% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 1.870µs (SLO: <10.000µs 📉 -81.3%) vs baseline: -0.7% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 18.554µs (SLO: <30.000µs 📉 -38.2%) vs baseline: +0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 2.806µs (SLO: <10.000µs 📉 -71.9%) vs baseline: +0.1% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ title_aspectTime: ✅ 18.169µs (SLO: <30.000µs 📉 -39.4%) vs baseline: -0.5% Memory: ✅ 42.546MB (SLO: <43.000MB 🟡 -1.1%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 2.663µs (SLO: <10.000µs 📉 -73.4%) vs baseline: -0.3% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ translate_aspectTime: ✅ 20.553µs (SLO: <30.000µs 📉 -31.5%) vs baseline: -0.2% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 4.340µs (SLO: <10.000µs 📉 -56.6%) vs baseline: +1.0% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ upper_aspectTime: ✅ 18.001µs (SLO: <30.000µs 📉 -40.0%) vs baseline: +0.1% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 2.682µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +9.4% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.165µs (SLO: <10.000µs 📉 -48.4%) vs baseline: 📈 +20.9% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 4.318µs (SLO: <10.000µs 📉 -56.8%) vs baseline: -0.6% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.227µs (SLO: <10.000µs 📉 -37.7%) vs baseline: -0.9% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 6.320µs (SLO: <10.000µs 📉 -36.8%) vs baseline: -0.6% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.588µs (SLO: <10.000µs 📉 -64.1%) vs baseline: -0.1% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 3.623µs (SLO: <10.000µs 📉 -63.8%) vs baseline: -0.3% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.908µs (SLO: <10.000µs 📉 -50.9%) vs baseline: -1.0% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 5.005µs (SLO: <10.000µs 📉 -49.9%) vs baseline: ~same Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.756µs (SLO: <10.000µs 📉 -62.4%) vs baseline: -0.6% Memory: ✅ 42.526MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.747µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -1.8% Memory: ✅ 42.487MB (SLO: <43.500MB -2.3%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.647µs (SLO: <10.000µs 📉 -53.5%) vs baseline: +0.3% Memory: ✅ 42.546MB (SLO: <43.500MB -2.2%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 4.653µs (SLO: <10.000µs 📉 -53.5%) vs baseline: -0.6% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.392µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +14.0% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ 1-count-metrics-100-timesTime: ✅ 198.455µs (SLO: <220.000µs -9.8%) vs baseline: ~same Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.298µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.6% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.196µs (SLO: <230.000µs -6.9%) vs baseline: +0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.4% ✅ 1-gauge-metric-1-timesTime: ✅ 2.181µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.3% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.442µs (SLO: <150.000µs -9.0%) vs baseline: -0.3% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.153µs (SLO: <20.000µs 📉 -84.2%) vs baseline: +1.0% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 213.154µs (SLO: <250.000µs 📉 -14.7%) vs baseline: ~same Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 19.947ms (SLO: <22.000ms -9.3%) vs baseline: -0.4% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.4% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.217ms (SLO: <2.550ms 📉 -13.0%) vs baseline: -0.8% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.407ms (SLO: <1.550ms -9.2%) vs baseline: +0.6% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ 100-rate-metrics-100-timesTime: ✅ 2.180ms (SLO: <2.550ms 📉 -14.5%) vs baseline: -0.1% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.584µs (SLO: <20.000µs 📉 -77.1%) vs baseline: +0.8% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ flush-100-metricsTime: ✅ 173.809µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.2% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.172ms (SLO: <2.500ms 📉 -13.1%) vs baseline: -0.4% Memory: ✅ 36.097MB (SLO: <36.500MB 🟡 -1.1%) vs baseline: +4.8% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes