-
Notifications
You must be signed in to change notification settings - Fork 322
add flaky annotation #9990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flaky annotation #9990
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1094637
Total [baseline] (10.695 s) : 0, 10695097
Agent [candidate] (1.095 s) : 0, 1095447
Total [candidate] (10.826 s) : 0, 10825695
section appsec
Agent [baseline] (1.285 s) : 0, 1284502
Total [baseline] (10.992 s) : 0, 10991773
Agent [candidate] (1.274 s) : 0, 1273958
Total [candidate] (10.995 s) : 0, 10995388
section iast
Agent [baseline] (1.251 s) : 0, 1250807
Total [baseline] (11.197 s) : 0, 11197168
Agent [candidate] (1.231 s) : 0, 1230749
Total [candidate] (11.191 s) : 0, 11191417
section profiling
Agent [baseline] (1.227 s) : 0, 1226662
Total [baseline] (11.023 s) : 0, 11022509
Agent [candidate] (1.232 s) : 0, 1232232
Total [candidate] (11.053 s) : 0, 11052560
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (703.032 ms) : 0, 703032
BytebuddyAgent [candidate] (703.768 ms) : 0, 703768
GlobalTracer [baseline] (247.256 ms) : 0, 247256
GlobalTracer [candidate] (247.321 ms) : 0, 247321
AppSec [baseline] (31.989 ms) : 0, 31989
AppSec [candidate] (32.028 ms) : 0, 32028
Debugger [baseline] (63.941 ms) : 0, 63941
Debugger [candidate] (63.823 ms) : 0, 63823
Remote Config [baseline] (618.86 µs) : 0, 619
Remote Config [candidate] (620.299 µs) : 0, 620
Telemetry [baseline] (8.033 ms) : 0, 8033
Telemetry [candidate] (8.047 ms) : 0, 8047
Flare Poller [baseline] (3.577 ms) : 0, 3577
Flare Poller [candidate] (3.652 ms) : 0, 3652
section appsec
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (733.372 ms) : 0, 733372
BytebuddyAgent [candidate] (727.467 ms) : 0, 727467
GlobalTracer [baseline] (240.567 ms) : 0, 240567
GlobalTracer [candidate] (238.954 ms) : 0, 238954
IAST [baseline] (25.09 ms) : 0, 25090
IAST [candidate] (24.638 ms) : 0, 24638
AppSec [baseline] (174.631 ms) : 0, 174631
AppSec [candidate] (173.419 ms) : 0, 173419
Debugger [baseline] (61.466 ms) : 0, 61466
Debugger [candidate] (60.32 ms) : 0, 60320
Remote Config [baseline] (687.522 µs) : 0, 688
Remote Config [candidate] (711.081 µs) : 0, 711
Telemetry [baseline] (8.277 ms) : 0, 8277
Telemetry [candidate] (8.278 ms) : 0, 8278
Flare Poller [baseline] (3.823 ms) : 0, 3823
Flare Poller [candidate] (3.885 ms) : 0, 3885
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (839.403 ms) : 0, 839403
BytebuddyAgent [candidate] (824.762 ms) : 0, 824762
GlobalTracer [baseline] (238.916 ms) : 0, 238916
GlobalTracer [candidate] (236.506 ms) : 0, 236506
IAST [baseline] (28.848 ms) : 0, 28848
IAST [candidate] (28.114 ms) : 0, 28114
AppSec [baseline] (33.31 ms) : 0, 33310
AppSec [candidate] (32.706 ms) : 0, 32706
Debugger [baseline] (61.804 ms) : 0, 61804
Debugger [candidate] (60.796 ms) : 0, 60796
Remote Config [baseline] (556.055 µs) : 0, 556
Remote Config [candidate] (541.932 µs) : 0, 542
Telemetry [baseline] (7.796 ms) : 0, 7796
Telemetry [candidate] (7.627 ms) : 0, 7627
Flare Poller [baseline] (3.566 ms) : 0, 3566
Flare Poller [candidate] (3.496 ms) : 0, 3496
section profiling
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (729.82 ms) : 0, 729820
BytebuddyAgent [candidate] (734.551 ms) : 0, 734551
GlobalTracer [baseline] (221.658 ms) : 0, 221658
GlobalTracer [candidate] (221.819 ms) : 0, 221819
AppSec [baseline] (32.075 ms) : 0, 32075
AppSec [candidate] (32.074 ms) : 0, 32074
Debugger [baseline] (62.888 ms) : 0, 62888
Debugger [candidate] (62.777 ms) : 0, 62777
Remote Config [baseline] (651.61 µs) : 0, 652
Remote Config [candidate] (657.908 µs) : 0, 658
Telemetry [baseline] (7.981 ms) : 0, 7981
Telemetry [candidate] (7.873 ms) : 0, 7873
Flare Poller [baseline] (3.779 ms) : 0, 3779
Flare Poller [candidate] (3.734 ms) : 0, 3734
ProfilingAgent [baseline] (96.778 ms) : 0, 96778
ProfilingAgent [candidate] (96.855 ms) : 0, 96855
Profiling [baseline] (97.365 ms) : 0, 97365
Profiling [candidate] (97.436 ms) : 0, 97436
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.099 s) : 0, 1098880
Total [baseline] (8.836 s) : 0, 8835691
Agent [candidate] (1.103 s) : 0, 1103328
Total [candidate] (8.862 s) : 0, 8861610
section iast
Agent [baseline] (1.234 s) : 0, 1233828
Total [baseline] (9.516 s) : 0, 9516049
Agent [candidate] (1.234 s) : 0, 1234313
Total [candidate] (9.503 s) : 0, 9503370
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (706.127 ms) : 0, 706127
BytebuddyAgent [candidate] (708.84 ms) : 0, 708840
GlobalTracer [baseline] (248.228 ms) : 0, 248228
GlobalTracer [candidate] (249.542 ms) : 0, 249542
AppSec [baseline] (32.308 ms) : 0, 32308
AppSec [candidate] (32.533 ms) : 0, 32533
Debugger [baseline] (63.535 ms) : 0, 63535
Debugger [candidate] (63.587 ms) : 0, 63587
Remote Config [baseline] (632.072 µs) : 0, 632
Remote Config [candidate] (626.399 µs) : 0, 626
Telemetry [baseline] (8.165 ms) : 0, 8165
Telemetry [candidate] (8.253 ms) : 0, 8253
Flare Poller [baseline] (3.66 ms) : 0, 3660
Flare Poller [candidate] (3.677 ms) : 0, 3677
section iast
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (827.533 ms) : 0, 827533
BytebuddyAgent [candidate] (827.276 ms) : 0, 827276
GlobalTracer [baseline] (237.036 ms) : 0, 237036
GlobalTracer [candidate] (237.235 ms) : 0, 237235
IAST [baseline] (26.617 ms) : 0, 26617
IAST [candidate] (26.54 ms) : 0, 26540
AppSec [baseline] (34.558 ms) : 0, 34558
AppSec [candidate] (34.719 ms) : 0, 34719
Debugger [baseline] (60.153 ms) : 0, 60153
Debugger [candidate] (60.483 ms) : 0, 60483
Remote Config [baseline] (540.012 µs) : 0, 540
Remote Config [candidate] (538.925 µs) : 0, 539
Telemetry [baseline] (7.713 ms) : 0, 7713
Telemetry [candidate] (7.645 ms) : 0, 7645
Flare Poller [baseline] (3.421 ms) : 0, 3421
Flare Poller [candidate] (3.495 ms) : 0, 3495
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 14 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (19.086 ms) : 18890, 19282
. : milestone, 19086,
appsec (18.778 ms) : 18591, 18964
. : milestone, 18778,
code_origins (17.928 ms) : 17750, 18105
. : milestone, 17928,
iast (17.951 ms) : 17771, 18131
. : milestone, 17951,
profiling (19.634 ms) : 19430, 19838
. : milestone, 19634,
tracing (17.597 ms) : 17421, 17773
. : milestone, 17597,
section candidate
no_agent (18.431 ms) : 18237, 18625
. : milestone, 18431,
appsec (18.974 ms) : 18781, 19167
. : milestone, 18974,
code_origins (17.769 ms) : 17594, 17944
. : milestone, 17769,
iast (18.015 ms) : 17836, 18195
. : milestone, 18015,
profiling (18.323 ms) : 18140, 18505
. : milestone, 18323,
tracing (17.577 ms) : 17403, 17750
. : milestone, 17577,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.176 ms) : 1164, 1187
. : milestone, 1176,
iast (3.197 ms) : 3150, 3244
. : milestone, 3197,
iast_FULL (5.678 ms) : 5620, 5736
. : milestone, 5678,
iast_GLOBAL (3.693 ms) : 3630, 3756
. : milestone, 3693,
profiling (2.183 ms) : 2161, 2206
. : milestone, 2183,
tracing (1.802 ms) : 1787, 1817
. : milestone, 1802,
section candidate
no_agent (1.191 ms) : 1180, 1203
. : milestone, 1191,
iast (3.388 ms) : 3332, 3444
. : milestone, 3388,
iast_FULL (5.902 ms) : 5843, 5962
. : milestone, 5902,
iast_GLOBAL (3.739 ms) : 3675, 3803
. : milestone, 3739,
profiling (1.985 ms) : 1967, 2003
. : milestone, 1985,
tracing (1.819 ms) : 1804, 1835
. : milestone, 1819,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.719 ms) : 3495, 3943
. : milestone, 3719,
iast (2.207 ms) : 2144, 2271
. : milestone, 2207,
iast_GLOBAL (2.253 ms) : 2189, 2318
. : milestone, 2253,
profiling (2.076 ms) : 2023, 2129
. : milestone, 2076,
tracing (2.021 ms) : 1971, 2071
. : milestone, 2021,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.702 ms) : 3483, 3922
. : milestone, 3702,
iast (2.194 ms) : 2131, 2258
. : milestone, 2194,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.065 ms) : 2013, 2117
. : milestone, 2065,
tracing (2.028 ms) : 1978, 2077
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~7834eeeaee, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (14.632 s) : 14632000, 14632000
. : milestone, 14632000,
iast (18.441 s) : 18441000, 18441000
. : milestone, 18441000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
profiling (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
tracing (14.612 s) : 14612000, 14612000
. : milestone, 14612000,
section candidate
no_agent (15.538 s) : 15538000, 15538000
. : milestone, 15538000,
appsec (14.905 s) : 14905000, 14905000
. : milestone, 14905000,
iast (18.312 s) : 18312000, 18312000
. : milestone, 18312000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
tracing (14.686 s) : 14686000, 14686000
. : milestone, 14686000,
|
What Does This Do
Annotates flaky test introduced in #9422
The issue is that the current test when AppSec is enabled, the conext is lost in a race condition causing flakiness
Motivation
Mark for future fixing
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]