-
Notifications
You must be signed in to change notification settings - Fork 312
Adding missing XML request/response schema collection #9432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fd35d02
to
d4321c4
Compare
🎯 Code Coverage 🔗 Commit SHA: c11840f | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 14 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068884
Total [baseline] (10.686 s) : 0, 10685768
Agent [candidate] (1.062 s) : 0, 1061683
Total [candidate] (10.758 s) : 0, 10758448
section appsec
Agent [baseline] (1.227 s) : 0, 1226751
Total [baseline] (10.798 s) : 0, 10798226
Agent [candidate] (1.224 s) : 0, 1224405
Total [candidate] (10.849 s) : 0, 10849284
section iast
Agent [baseline] (1.178 s) : 0, 1177759
Total [baseline] (10.931 s) : 0, 10931398
Agent [candidate] (1.187 s) : 0, 1187364
Total [candidate] (10.996 s) : 0, 10996085
section profiling
Agent [baseline] (1.209 s) : 0, 1209185
Total [baseline] (10.949 s) : 0, 10949005
Agent [candidate] (1.204 s) : 0, 1204204
Total [candidate] (10.859 s) : 0, 10858646
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (748.388 ms) : 0, 748388
BytebuddyAgent [candidate] (743.227 ms) : 0, 743227
GlobalTracer [baseline] (246.829 ms) : 0, 246829
GlobalTracer [candidate] (245.674 ms) : 0, 245674
AppSec [baseline] (30.874 ms) : 0, 30874
AppSec [candidate] (30.764 ms) : 0, 30764
Debugger [baseline] (6.537 ms) : 0, 6537
Debugger [candidate] (6.162 ms) : 0, 6162
Remote Config [baseline] (693.14 µs) : 0, 693
Remote Config [candidate] (700.121 µs) : 0, 700
Telemetry [baseline] (12.622 ms) : 0, 12622
Telemetry [candidate] (12.418 ms) : 0, 12418
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (755.892 ms) : 0, 755892
BytebuddyAgent [candidate] (757.096 ms) : 0, 757096
GlobalTracer [baseline] (236.619 ms) : 0, 236619
GlobalTracer [candidate] (235.585 ms) : 0, 235585
AppSec [baseline] (168.408 ms) : 0, 168408
AppSec [candidate] (169.382 ms) : 0, 169382
Debugger [baseline] (7.744 ms) : 0, 7744
Debugger [candidate] (7.352 ms) : 0, 7352
Remote Config [baseline] (643.045 µs) : 0, 643
Remote Config [candidate] (618.67 µs) : 0, 619
Telemetry [baseline] (10.941 ms) : 0, 10941
Telemetry [candidate] (8.465 ms) : 0, 8465
IAST [baseline] (23.904 ms) : 0, 23904
IAST [candidate] (23.34 ms) : 0, 23340
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (850.022 ms) : 0, 850022
BytebuddyAgent [candidate] (857.334 ms) : 0, 857334
GlobalTracer [baseline] (233.481 ms) : 0, 233481
GlobalTracer [candidate] (234.155 ms) : 0, 234155
AppSec [baseline] (26.724 ms) : 0, 26724
AppSec [candidate] (26.245 ms) : 0, 26245
Debugger [baseline] (7.029 ms) : 0, 7029
Debugger [candidate] (6.723 ms) : 0, 6723
Remote Config [baseline] (606.377 µs) : 0, 606
Remote Config [candidate] (586.16 µs) : 0, 586
Telemetry [baseline] (8.291 ms) : 0, 8291
Telemetry [candidate] (8.405 ms) : 0, 8405
IAST [baseline] (29.047 ms) : 0, 29047
IAST [candidate] (31.352 ms) : 0, 31352
section profiling
ProfilingAgent [baseline] (109.575 ms) : 0, 109575
ProfilingAgent [candidate] (107.514 ms) : 0, 107514
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (768.436 ms) : 0, 768436
BytebuddyAgent [candidate] (766.653 ms) : 0, 766653
GlobalTracer [baseline] (224.823 ms) : 0, 224823
GlobalTracer [candidate] (223.723 ms) : 0, 223723
AppSec [baseline] (32.379 ms) : 0, 32379
AppSec [candidate] (30.633 ms) : 0, 30633
Debugger [baseline] (6.665 ms) : 0, 6665
Debugger [candidate] (7.064 ms) : 0, 7064
Remote Config [baseline] (765.417 µs) : 0, 765
Remote Config [candidate] (748.685 µs) : 0, 749
Telemetry [baseline] (14.094 ms) : 0, 14094
Telemetry [candidate] (15.687 ms) : 0, 15687
Profiling [baseline] (110.301 ms) : 0, 110301
Profiling [candidate] (108.16 ms) : 0, 108160
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046288
Total [baseline] (8.631 s) : 0, 8630906
Agent [candidate] (1.046 s) : 0, 1045627
Total [candidate] (8.617 s) : 0, 8617070
section iast
Agent [baseline] (1.196 s) : 0, 1196245
Total [baseline] (9.37 s) : 0, 9370092
Agent [candidate] (1.192 s) : 0, 1191601
Total [candidate] (9.328 s) : 0, 9328078
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (731.817 ms) : 0, 731817
BytebuddyAgent [candidate] (732.286 ms) : 0, 732286
GlobalTracer [baseline] (242.338 ms) : 0, 242338
GlobalTracer [candidate] (242.272 ms) : 0, 242272
AppSec [baseline] (30.146 ms) : 0, 30146
AppSec [candidate] (30.211 ms) : 0, 30211
Debugger [baseline] (6.419 ms) : 0, 6419
Debugger [candidate] (6.127 ms) : 0, 6127
Remote Config [baseline] (670.957 µs) : 0, 671
Remote Config [candidate] (681.919 µs) : 0, 682
Telemetry [baseline] (12.411 ms) : 0, 12411
Telemetry [candidate] (11.513 ms) : 0, 11513
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (864.345 ms) : 0, 864345
BytebuddyAgent [candidate] (863.523 ms) : 0, 863523
GlobalTracer [baseline] (234.907 ms) : 0, 234907
GlobalTracer [candidate] (232.596 ms) : 0, 232596
IAST [baseline] (29.982 ms) : 0, 29982
IAST [candidate] (30.591 ms) : 0, 30591
AppSec [baseline] (27.945 ms) : 0, 27945
AppSec [candidate] (27.693 ms) : 0, 27693
Debugger [baseline] (7.224 ms) : 0, 7224
Debugger [candidate] (5.764 ms) : 0, 5764
Remote Config [baseline] (647.829 µs) : 0, 648
Remote Config [candidate] (605.216 µs) : 0, 605
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (8.225 ms) : 0, 8225
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section baseline
no_agent (37.939 ms) : 37635, 38243
. : milestone, 37939,
appsec (48.823 ms) : 48403, 49244
. : milestone, 48823,
code_origins (44.59 ms) : 44200, 44981
. : milestone, 44590,
iast (47.403 ms) : 46979, 47827
. : milestone, 47403,
profiling (50.764 ms) : 50323, 51204
. : milestone, 50764,
tracing (42.054 ms) : 41708, 42400
. : milestone, 42054,
section candidate
no_agent (38.558 ms) : 38248, 38867
. : milestone, 38558,
appsec (48.306 ms) : 47877, 48735
. : milestone, 48306,
code_origins (46.611 ms) : 46207, 47014
. : milestone, 46611,
iast (45.198 ms) : 44821, 45576
. : milestone, 45198,
profiling (48.34 ms) : 47880, 48800
. : milestone, 48340,
tracing (45.56 ms) : 45181, 45939
. : milestone, 45560,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section baseline
no_agent (4.528 ms) : 4477, 4579
. : milestone, 4528,
iast (9.639 ms) : 9478, 9800
. : milestone, 9639,
iast_FULL (14.206 ms) : 13918, 14494
. : milestone, 14206,
iast_GLOBAL (10.516 ms) : 10330, 10702
. : milestone, 10516,
profiling (9.22 ms) : 9074, 9366
. : milestone, 9220,
tracing (7.938 ms) : 7822, 8054
. : milestone, 7938,
section candidate
no_agent (4.274 ms) : 4225, 4324
. : milestone, 4274,
iast (9.469 ms) : 9313, 9625
. : milestone, 9469,
iast_FULL (14.605 ms) : 14308, 14901
. : milestone, 14605,
iast_GLOBAL (10.566 ms) : 10381, 10751
. : milestone, 10566,
profiling (9.295 ms) : 9151, 9439
. : milestone, 9295,
tracing (7.536 ms) : 7430, 7643
. : milestone, 7536,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.444 ms) : 2392, 2497
. : milestone, 2444,
iast (2.189 ms) : 2126, 2252
. : milestone, 2189,
iast_GLOBAL (2.24 ms) : 2177, 2304
. : milestone, 2240,
profiling (2.034 ms) : 1984, 2085
. : milestone, 2034,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.667 ms) : 3451, 3884
. : milestone, 3667,
iast (2.199 ms) : 2136, 2262
. : milestone, 2199,
iast_GLOBAL (2.245 ms) : 2181, 2309
. : milestone, 2245,
profiling (2.032 ms) : 1982, 2083
. : milestone, 2032,
tracing (2.02 ms) : 1971, 2069
. : milestone, 2020,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c11840f8bc, baseline=1.54.0-SNAPSHOT~f284153719
dateFormat X
axisFormat %s
section baseline
no_agent (15.559 s) : 15559000, 15559000
. : milestone, 15559000,
appsec (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
iast (18.482 s) : 18482000, 18482000
. : milestone, 18482000,
iast_GLOBAL (18.346 s) : 18346000, 18346000
. : milestone, 18346000,
profiling (16.024 s) : 16024000, 16024000
. : milestone, 16024000,
tracing (14.814 s) : 14814000, 14814000
. : milestone, 14814000,
section candidate
no_agent (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
appsec (14.622 s) : 14622000, 14622000
. : milestone, 14622000,
iast (18.212 s) : 18212000, 18212000
. : milestone, 18212000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
. : milestone, 18033000,
profiling (15.413 s) : 15413000, 15413000
. : milestone, 15413000,
tracing (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
|
Looks good! I updated the title of the PR because you’re solving the problem for both request and response. |
849c2bb
to
104bbbd
Compare
92c36be
to
5328ef4
Compare
b0bb9b0
to
883c505
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
883c505
to
dbf8609
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
dbf8609
to
0f25a53
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
0f25a53
to
2d76ec9
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
2d76ec9
to
3334659
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
3334659
to
cb66848
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
Signed-off-by: sezen.leblay <[email protected]>
cb66848
to
c11840f
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
What Does This Do
The instrumentation can digest XML to pass onto WAF
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-58618