-
Notifications
You must be signed in to change notification settings - Fork 312
Don't be strict on opensearch tests #9129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1004216
Total [baseline] (8.601 s) : 0, 8600871
Agent [candidate] (1.003 s) : 0, 1003304
Total [candidate] (8.59 s) : 0, 8590193
section iast
Agent [baseline] (1.135 s) : 0, 1135027
Total [baseline] (9.284 s) : 0, 9283772
Agent [candidate] (1.143 s) : 0, 1143161
Total [candidate] (9.313 s) : 0, 9312894
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.361 ms) : 0, 693361
BytebuddyAgent [candidate] (692.616 ms) : 0, 692616
GlobalTracer [baseline] (244.062 ms) : 0, 244062
GlobalTracer [candidate] (244.049 ms) : 0, 244049
AppSec [baseline] (30.746 ms) : 0, 30746
AppSec [candidate] (30.606 ms) : 0, 30606
Debugger [baseline] (6.149 ms) : 0, 6149
Debugger [candidate] (6.13 ms) : 0, 6130
Remote Config [baseline] (682.472 µs) : 0, 682
Remote Config [candidate] (694.705 µs) : 0, 695
Telemetry [baseline] (8.303 ms) : 0, 8303
Telemetry [candidate] (8.337 ms) : 0, 8337
section iast
BytebuddyAgent [baseline] (808.996 ms) : 0, 808996
BytebuddyAgent [candidate] (815.173 ms) : 0, 815173
GlobalTracer [baseline] (232.851 ms) : 0, 232851
GlobalTracer [candidate] (234.063 ms) : 0, 234063
AppSec [baseline] (27.198 ms) : 0, 27198
AppSec [candidate] (31.028 ms) : 0, 31028
Debugger [baseline] (6.771 ms) : 0, 6771
Debugger [candidate] (5.882 ms) : 0, 5882
Remote Config [baseline] (642.277 µs) : 0, 642
Remote Config [candidate] (587.478 µs) : 0, 587
Telemetry [baseline] (7.987 ms) : 0, 7987
Telemetry [candidate] (8.078 ms) : 0, 8078
IAST [baseline] (29.781 ms) : 0, 29781
IAST [candidate] (27.394 ms) : 0, 27394
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.005 s) : 0, 1005053
Total [baseline] (10.663 s) : 0, 10663017
Agent [candidate] (997.446 ms) : 0, 997446
Total [candidate] (10.698 s) : 0, 10697753
section appsec
Agent [baseline] (1.193 s) : 0, 1193186
Total [baseline] (10.936 s) : 0, 10935719
Agent [candidate] (1.176 s) : 0, 1175992
Total [candidate] (10.723 s) : 0, 10722573
section iast
Agent [baseline] (1.142 s) : 0, 1141973
Total [baseline] (10.845 s) : 0, 10844930
Agent [candidate] (1.141 s) : 0, 1141024
Total [candidate] (10.884 s) : 0, 10884398
section profiling
Agent [baseline] (1.251 s) : 0, 1251469
Total [baseline] (11.035 s) : 0, 11035134
Agent [candidate] (1.245 s) : 0, 1245048
Total [candidate] (11.072 s) : 0, 11072458
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.749 ms) : 0, 693749
BytebuddyAgent [candidate] (688.788 ms) : 0, 688788
GlobalTracer [baseline] (244.449 ms) : 0, 244449
GlobalTracer [candidate] (242.533 ms) : 0, 242533
AppSec [baseline] (30.756 ms) : 0, 30756
AppSec [candidate] (30.249 ms) : 0, 30249
Debugger [baseline] (6.105 ms) : 0, 6105
Debugger [candidate] (6.093 ms) : 0, 6093
Remote Config [baseline] (682.671 µs) : 0, 683
Remote Config [candidate] (675.963 µs) : 0, 676
Telemetry [baseline] (8.328 ms) : 0, 8328
Telemetry [candidate] (8.243 ms) : 0, 8243
section appsec
BytebuddyAgent [baseline] (722.391 ms) : 0, 722391
BytebuddyAgent [candidate] (710.268 ms) : 0, 710268
GlobalTracer [baseline] (238.636 ms) : 0, 238636
GlobalTracer [candidate] (235.678 ms) : 0, 235678
AppSec [baseline] (172.325 ms) : 0, 172325
AppSec [candidate] (171.57 ms) : 0, 171570
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.786 ms) : 0, 5786
Remote Config [baseline] (621.467 µs) : 0, 621
Remote Config [candidate] (604.439 µs) : 0, 604
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (8.028 ms) : 0, 8028
IAST [baseline] (23.839 ms) : 0, 23839
IAST [candidate] (23.229 ms) : 0, 23229
section iast
BytebuddyAgent [baseline] (814.383 ms) : 0, 814383
BytebuddyAgent [candidate] (813.012 ms) : 0, 813012
GlobalTracer [baseline] (233.98 ms) : 0, 233980
GlobalTracer [candidate] (233.962 ms) : 0, 233962
AppSec [baseline] (27.624 ms) : 0, 27624
AppSec [candidate] (32.712 ms) : 0, 32712
Debugger [baseline] (7.575 ms) : 0, 7575
Debugger [candidate] (6.782 ms) : 0, 6782
Remote Config [baseline] (582.017 µs) : 0, 582
Remote Config [candidate] (593.673 µs) : 0, 594
Telemetry [baseline] (8.001 ms) : 0, 8001
Telemetry [candidate] (8.079 ms) : 0, 8079
IAST [baseline] (28.9 ms) : 0, 28900
IAST [candidate] (24.861 ms) : 0, 24861
section profiling
BytebuddyAgent [baseline] (680.376 ms) : 0, 680376
BytebuddyAgent [candidate] (677.851 ms) : 0, 677851
GlobalTracer [baseline] (363.8 ms) : 0, 363800
GlobalTracer [candidate] (361.966 ms) : 0, 361966
AppSec [baseline] (32.521 ms) : 0, 32521
AppSec [candidate] (31.656 ms) : 0, 31656
Debugger [baseline] (12.344 ms) : 0, 12344
Debugger [candidate] (12.057 ms) : 0, 12057
Remote Config [baseline] (667.228 µs) : 0, 667
Remote Config [candidate] (1.407 ms) : 0, 1407
Telemetry [baseline] (8.014 ms) : 0, 8014
Telemetry [candidate] (8.035 ms) : 0, 8035
ProfilingAgent [baseline] (104.832 ms) : 0, 104832
ProfilingAgent [candidate] (103.483 ms) : 0, 103483
Profiling [baseline] (104.858 ms) : 0, 104858
Profiling [candidate] (103.508 ms) : 0, 103508
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (36.89 ms) : 36588, 37191
. : milestone, 36890,
appsec (48.633 ms) : 48205, 49061
. : milestone, 48633,
code_origins (47.353 ms) : 46951, 47754
. : milestone, 47353,
iast (43.883 ms) : 43496, 44271
. : milestone, 43883,
profiling (48.082 ms) : 47627, 48538
. : milestone, 48082,
tracing (43.104 ms) : 42744, 43465
. : milestone, 43104,
section candidate
no_agent (35.982 ms) : 35692, 36271
. : milestone, 35982,
appsec (47.18 ms) : 46763, 47597
. : milestone, 47180,
code_origins (45.017 ms) : 44640, 45394
. : milestone, 45017,
iast (44.325 ms) : 43931, 44718
. : milestone, 44325,
profiling (51.555 ms) : 51075, 52035
. : milestone, 51555,
tracing (43.773 ms) : 43399, 44147
. : milestone, 43773,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (4.311 ms) : 4262, 4360
. : milestone, 4311,
iast (9.192 ms) : 9045, 9339
. : milestone, 9192,
iast_FULL (14.192 ms) : 13910, 14475
. : milestone, 14192,
iast_GLOBAL (10.355 ms) : 10173, 10537
. : milestone, 10355,
profiling (8.582 ms) : 8438, 8726
. : milestone, 8582,
tracing (7.526 ms) : 7412, 7640
. : milestone, 7526,
section candidate
no_agent (4.517 ms) : 4464, 4569
. : milestone, 4517,
iast (9.575 ms) : 9416, 9734
. : milestone, 9575,
iast_FULL (13.799 ms) : 13531, 14067
. : milestone, 13799,
iast_GLOBAL (10.646 ms) : 10454, 10837
. : milestone, 10646,
profiling (8.814 ms) : 8672, 8957
. : milestone, 8814,
tracing (7.703 ms) : 7588, 7819
. : milestone, 7703,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.409 ms) : 2359, 2459
. : milestone, 2409,
iast (2.192 ms) : 2130, 2254
. : milestone, 2192,
iast_GLOBAL (2.238 ms) : 2175, 2301
. : milestone, 2238,
profiling (2.038 ms) : 1988, 2087
. : milestone, 2038,
tracing (2.009 ms) : 1960, 2057
. : milestone, 2009,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.418 ms) : 2368, 2468
. : milestone, 2418,
iast (2.192 ms) : 2129, 2254
. : milestone, 2192,
iast_GLOBAL (2.237 ms) : 2174, 2300
. : milestone, 2237,
profiling (2.061 ms) : 2009, 2113
. : milestone, 2061,
tracing (2.016 ms) : 1967, 2064
. : milestone, 2016,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~39ff88364d, baseline=1.51.0-SNAPSHOT~860a603678
dateFormat X
axisFormat %s
section baseline
no_agent (15.544 s) : 15544000, 15544000
. : milestone, 15544000,
appsec (14.669 s) : 14669000, 14669000
. : milestone, 14669000,
iast (18.309 s) : 18309000, 18309000
. : milestone, 18309000,
iast_GLOBAL (18.053 s) : 18053000, 18053000
. : milestone, 18053000,
profiling (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
tracing (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
section candidate
no_agent (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
appsec (14.737 s) : 14737000, 14737000
. : milestone, 14737000,
iast (18.605 s) : 18605000, 18605000
. : milestone, 18605000,
iast_GLOBAL (17.717 s) : 17717000, 17717000
. : milestone, 17717000,
profiling (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
tracing (14.656 s) : 14656000, 14656000
. : milestone, 14656000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking the CI. Need fix from @DataDog/apm-idm-java
What Does This Do
Logs shows that the trace is discarded since spans are not received in the correct order. Removing strict trace writing as a workaround
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]