-
Notifications
You must be signed in to change notification settings - Fork 312
Allow tag builds to access Gitlab cache #9124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bric3
approved these changes
Jul 8, 2025
AlexeyKuznetsov-DD
approved these changes
Jul 8, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (994.47 ms) : 0, 994470
Total [baseline] (10.709 s) : 0, 10709378
Agent [candidate] (994.619 ms) : 0, 994619
Total [candidate] (10.638 s) : 0, 10637987
section appsec
Agent [baseline] (1.174 s) : 0, 1174089
Total [baseline] (10.795 s) : 0, 10795172
Agent [candidate] (1.182 s) : 0, 1181759
Total [candidate] (10.774 s) : 0, 10774474
section iast
Agent [baseline] (1.134 s) : 0, 1133692
Total [baseline] (10.835 s) : 0, 10834710
Agent [candidate] (1.132 s) : 0, 1132192
Total [candidate] (10.783 s) : 0, 10782662
section profiling
Agent [baseline] (1.253 s) : 0, 1252909
Total [baseline] (11.038 s) : 0, 11037718
Agent [candidate] (1.255 s) : 0, 1254730
Total [candidate] (11.016 s) : 0, 11015909
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.32 ms) : 0, 686320
BytebuddyAgent [candidate] (686.767 ms) : 0, 686767
GlobalTracer [baseline] (242.239 ms) : 0, 242239
GlobalTracer [candidate] (242.101 ms) : 0, 242101
AppSec [baseline] (30.268 ms) : 0, 30268
AppSec [candidate] (30.137 ms) : 0, 30137
Debugger [baseline] (5.939 ms) : 0, 5939
Debugger [candidate] (5.964 ms) : 0, 5964
Remote Config [baseline] (671.0 µs) : 0, 671
Remote Config [candidate] (679.455 µs) : 0, 679
Telemetry [baseline] (8.243 ms) : 0, 8243
Telemetry [candidate] (8.202 ms) : 0, 8202
section appsec
BytebuddyAgent [baseline] (709.77 ms) : 0, 709770
BytebuddyAgent [candidate] (715.135 ms) : 0, 715135
GlobalTracer [baseline] (234.998 ms) : 0, 234998
GlobalTracer [candidate] (236.26 ms) : 0, 236260
IAST [baseline] (23.222 ms) : 0, 23222
IAST [candidate] (23.29 ms) : 0, 23290
AppSec [baseline] (170.852 ms) : 0, 170852
AppSec [candidate] (171.591 ms) : 0, 171591
Debugger [baseline] (5.685 ms) : 0, 5685
Debugger [candidate] (5.727 ms) : 0, 5727
Remote Config [baseline] (611.139 µs) : 0, 611
Remote Config [candidate] (605.664 µs) : 0, 606
Telemetry [baseline] (8.107 ms) : 0, 8107
Telemetry [candidate] (8.156 ms) : 0, 8156
section iast
BytebuddyAgent [baseline] (808.306 ms) : 0, 808306
BytebuddyAgent [candidate] (807.19 ms) : 0, 807190
GlobalTracer [baseline] (232.476 ms) : 0, 232476
GlobalTracer [candidate] (232.382 ms) : 0, 232382
IAST [baseline] (24.565 ms) : 0, 24565
IAST [candidate] (24.594 ms) : 0, 24594
AppSec [baseline] (32.414 ms) : 0, 32414
AppSec [candidate] (33.007 ms) : 0, 33007
Debugger [baseline] (6.622 ms) : 0, 6622
Debugger [candidate] (5.757 ms) : 0, 5757
Remote Config [baseline] (577.157 µs) : 0, 577
Remote Config [candidate] (579.626 µs) : 0, 580
Telemetry [baseline] (7.964 ms) : 0, 7964
Telemetry [candidate] (7.923 ms) : 0, 7923
section profiling
BytebuddyAgent [baseline] (682.712 ms) : 0, 682712
BytebuddyAgent [candidate] (685.383 ms) : 0, 685383
GlobalTracer [baseline] (363.263 ms) : 0, 363263
GlobalTracer [candidate] (362.922 ms) : 0, 362922
AppSec [baseline] (33.33 ms) : 0, 33330
AppSec [candidate] (31.746 ms) : 0, 31746
Debugger [baseline] (9.106 ms) : 0, 9106
Debugger [candidate] (11.935 ms) : 0, 11935
Remote Config [baseline] (669.743 µs) : 0, 670
Remote Config [candidate] (670.978 µs) : 0, 671
Telemetry [baseline] (8.735 ms) : 0, 8735
Telemetry [candidate] (8.023 ms) : 0, 8023
ProfilingAgent [baseline] (105.637 ms) : 0, 105637
ProfilingAgent [candidate] (103.905 ms) : 0, 103905
Profiling [baseline] (105.662 ms) : 0, 105662
Profiling [candidate] (103.929 ms) : 0, 103929
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (990.91 ms) : 0, 990910
Total [baseline] (8.579 s) : 0, 8578728
Agent [candidate] (999.76 ms) : 0, 999760
Total [candidate] (8.554 s) : 0, 8554109
section iast
Agent [baseline] (1.13 s) : 0, 1129940
Total [baseline] (9.279 s) : 0, 9279077
Agent [candidate] (1.132 s) : 0, 1132374
Total [candidate] (9.247 s) : 0, 9247260
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.537 ms) : 0, 684537
BytebuddyAgent [candidate] (689.362 ms) : 0, 689362
GlobalTracer [baseline] (240.874 ms) : 0, 240874
GlobalTracer [candidate] (243.849 ms) : 0, 243849
AppSec [baseline] (30.078 ms) : 0, 30078
AppSec [candidate] (30.622 ms) : 0, 30622
Debugger [baseline] (5.933 ms) : 0, 5933
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (674.373 µs) : 0, 674
Remote Config [candidate] (686.495 µs) : 0, 686
Telemetry [baseline] (8.171 ms) : 0, 8171
Telemetry [candidate] (8.316 ms) : 0, 8316
section iast
BytebuddyAgent [baseline] (805.573 ms) : 0, 805573
BytebuddyAgent [candidate] (807.71 ms) : 0, 807710
GlobalTracer [baseline] (231.622 ms) : 0, 231622
GlobalTracer [candidate] (231.937 ms) : 0, 231937
IAST [baseline] (26.4 ms) : 0, 26400
IAST [candidate] (28.72 ms) : 0, 28720
AppSec [baseline] (30.51 ms) : 0, 30510
AppSec [candidate] (27.167 ms) : 0, 27167
Debugger [baseline] (6.592 ms) : 0, 6592
Debugger [candidate] (7.579 ms) : 0, 7579
Remote Config [baseline] (576.967 µs) : 0, 577
Remote Config [candidate] (578.19 µs) : 0, 578
Telemetry [baseline] (7.983 ms) : 0, 7983
Telemetry [candidate] (7.986 ms) : 0, 7986
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (4.435 ms) : 4386, 4485
. : milestone, 4435,
iast (9.42 ms) : 9264, 9576
. : milestone, 9420,
iast_FULL (14.023 ms) : 13744, 14303
. : milestone, 14023,
iast_GLOBAL (10.198 ms) : 10022, 10375
. : milestone, 10198,
profiling (8.587 ms) : 8449, 8724
. : milestone, 8587,
tracing (7.386 ms) : 7284, 7487
. : milestone, 7386,
section candidate
no_agent (4.351 ms) : 4301, 4401
. : milestone, 4351,
iast (9.507 ms) : 9348, 9667
. : milestone, 9507,
iast_FULL (13.919 ms) : 13642, 14196
. : milestone, 13919,
iast_GLOBAL (10.372 ms) : 10181, 10563
. : milestone, 10372,
profiling (8.662 ms) : 8519, 8804
. : milestone, 8662,
tracing (7.422 ms) : 7306, 7537
. : milestone, 7422,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (37.027 ms) : 36727, 37328
. : milestone, 37027,
appsec (47.283 ms) : 46854, 47711
. : milestone, 47283,
code_origins (44.272 ms) : 43881, 44663
. : milestone, 44272,
iast (45.677 ms) : 45279, 46074
. : milestone, 45677,
profiling (46.28 ms) : 45886, 46674
. : milestone, 46280,
tracing (42.5 ms) : 42138, 42862
. : milestone, 42500,
section candidate
no_agent (38.392 ms) : 38074, 38709
. : milestone, 38392,
appsec (48.328 ms) : 47902, 48753
. : milestone, 48328,
code_origins (45.826 ms) : 45420, 46232
. : milestone, 45826,
iast (45.129 ms) : 44735, 45522
. : milestone, 45129,
profiling (48.276 ms) : 47809, 48744
. : milestone, 48276,
tracing (42.501 ms) : 42152, 42851
. : milestone, 42501,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.428 ms) : 2378, 2478
. : milestone, 2428,
iast (2.223 ms) : 2159, 2286
. : milestone, 2223,
iast_GLOBAL (2.258 ms) : 2194, 2321
. : milestone, 2258,
profiling (2.058 ms) : 2007, 2108
. : milestone, 2058,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.428 ms) : 2378, 2479
. : milestone, 2428,
iast (2.215 ms) : 2152, 2278
. : milestone, 2215,
iast_GLOBAL (2.249 ms) : 2185, 2312
. : milestone, 2249,
profiling (2.072 ms) : 2020, 2124
. : milestone, 2072,
tracing (2.045 ms) : 1996, 2094
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~a35fe4cbbb, baseline=1.51.0-SNAPSHOT~4acd1c74e1
dateFormat X
axisFormat %s
section baseline
no_agent (15.454 s) : 15454000, 15454000
. : milestone, 15454000,
appsec (14.516 s) : 14516000, 14516000
. : milestone, 14516000,
iast (18.486 s) : 18486000, 18486000
. : milestone, 18486000,
iast_GLOBAL (18.078 s) : 18078000, 18078000
. : milestone, 18078000,
profiling (15.936 s) : 15936000, 15936000
. : milestone, 15936000,
tracing (14.746 s) : 14746000, 14746000
. : milestone, 14746000,
section candidate
no_agent (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
appsec (14.799 s) : 14799000, 14799000
. : milestone, 14799000,
iast (18.267 s) : 18267000, 18267000
. : milestone, 18267000,
iast_GLOBAL (18.088 s) : 18088000, 18088000
. : milestone, 18088000,
profiling (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
tracing (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Allow builds from tags (eg releases) to access the Gitlab cache. By default, Gitlab only allows access to the cache to "protected" branches. All branches are protected, tags are not protected.
With this change, the cache is unprotected and accessible by tags. See Gitlab documentation
Motivation
The last release had jobs timing out because the cache was not accessible.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]