-
Notifications
You must be signed in to change notification settings - Fork 322
Fix IAST VerifyError on custom StreamReader with super call #9075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.005 s) : 0, 1005076
Total [baseline] (8.635 s) : 0, 8634524
Agent [candidate] (996.661 ms) : 0, 996661
Total [candidate] (8.579 s) : 0, 8579145
section iast
Agent [baseline] (1.131 s) : 0, 1131252
Total [baseline] (9.257 s) : 0, 9257247
Agent [candidate] (1.136 s) : 0, 1135745
Total [candidate] (9.339 s) : 0, 9338502
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.056 ms) : 0, 695056
BytebuddyAgent [candidate] (688.341 ms) : 0, 688341
GlobalTracer [baseline] (243.84 ms) : 0, 243840
GlobalTracer [candidate] (242.224 ms) : 0, 242224
AppSec [baseline] (30.348 ms) : 0, 30348
AppSec [candidate] (30.365 ms) : 0, 30365
Debugger [baseline] (6.037 ms) : 0, 6037
Debugger [candidate] (6.04 ms) : 0, 6040
Remote Config [baseline] (679.156 µs) : 0, 679
Remote Config [candidate] (671.635 µs) : 0, 672
Telemetry [baseline] (8.275 ms) : 0, 8275
Telemetry [candidate] (8.184 ms) : 0, 8184
section iast
BytebuddyAgent [baseline] (808.182 ms) : 0, 808182
BytebuddyAgent [candidate] (811.157 ms) : 0, 811157
GlobalTracer [baseline] (232.651 ms) : 0, 232651
GlobalTracer [candidate] (233.533 ms) : 0, 233533
AppSec [baseline] (27.557 ms) : 0, 27557
AppSec [candidate] (26.184 ms) : 0, 26184
Debugger [baseline] (5.803 ms) : 0, 5803
Debugger [candidate] (5.865 ms) : 0, 5865
Remote Config [baseline] (581.266 µs) : 0, 581
Remote Config [candidate] (584.192 µs) : 0, 584
Telemetry [baseline] (7.917 ms) : 0, 7917
Telemetry [candidate] (8.01 ms) : 0, 8010
IAST [baseline] (27.829 ms) : 0, 27829
IAST [candidate] (29.605 ms) : 0, 29605
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.629 ms) : 0, 995629
Total [baseline] (10.632 s) : 0, 10631647
Agent [candidate] (1.004 s) : 0, 1004111
Total [candidate] (10.711 s) : 0, 10711388
section appsec
Agent [baseline] (1.175 s) : 0, 1175488
Total [baseline] (10.79 s) : 0, 10789699
Agent [candidate] (1.174 s) : 0, 1174259
Total [candidate] (10.731 s) : 0, 10731229
section iast
Agent [baseline] (1.139 s) : 0, 1139107
Total [baseline] (10.884 s) : 0, 10884074
Agent [candidate] (1.133 s) : 0, 1133131
Total [candidate] (10.816 s) : 0, 10815705
section profiling
Agent [baseline] (1.248 s) : 0, 1247547
Total [baseline] (10.914 s) : 0, 10914294
Agent [candidate] (1.242 s) : 0, 1242305
Total [candidate] (10.939 s) : 0, 10939148
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.707 ms) : 0, 687707
BytebuddyAgent [candidate] (691.922 ms) : 0, 691922
GlobalTracer [baseline] (241.732 ms) : 0, 241732
GlobalTracer [candidate] (245.202 ms) : 0, 245202
AppSec [baseline] (30.422 ms) : 0, 30422
AppSec [candidate] (30.9 ms) : 0, 30900
Debugger [baseline] (6.126 ms) : 0, 6126
Debugger [candidate] (6.18 ms) : 0, 6180
Remote Config [baseline] (686.92 µs) : 0, 687
Remote Config [candidate] (697.869 µs) : 0, 698
Telemetry [baseline] (8.203 ms) : 0, 8203
Telemetry [candidate] (8.341 ms) : 0, 8341
section appsec
BytebuddyAgent [baseline] (711.144 ms) : 0, 711144
BytebuddyAgent [candidate] (709.755 ms) : 0, 709755
GlobalTracer [baseline] (235.878 ms) : 0, 235878
GlobalTracer [candidate] (236.05 ms) : 0, 236050
IAST [baseline] (22.04 ms) : 0, 22040
IAST [candidate] (22.192 ms) : 0, 22192
AppSec [baseline] (171.0 ms) : 0, 171000
AppSec [candidate] (171.102 ms) : 0, 171102
Debugger [baseline] (5.819 ms) : 0, 5819
Debugger [candidate] (5.754 ms) : 0, 5754
Remote Config [baseline] (612.609 µs) : 0, 613
Remote Config [candidate] (603.339 µs) : 0, 603
Telemetry [baseline] (8.174 ms) : 0, 8174
Telemetry [candidate] (8.081 ms) : 0, 8081
section iast
BytebuddyAgent [baseline] (813.518 ms) : 0, 813518
BytebuddyAgent [candidate] (808.812 ms) : 0, 808812
GlobalTracer [baseline] (234.306 ms) : 0, 234306
GlobalTracer [candidate] (233.452 ms) : 0, 233452
IAST [baseline] (28.021 ms) : 0, 28021
IAST [candidate] (26.859 ms) : 0, 26859
AppSec [baseline] (27.989 ms) : 0, 27989
AppSec [candidate] (28.665 ms) : 0, 28665
Debugger [baseline] (5.846 ms) : 0, 5846
Debugger [candidate] (5.884 ms) : 0, 5884
Remote Config [baseline] (594.323 µs) : 0, 594
Remote Config [candidate] (587.807 µs) : 0, 588
Telemetry [baseline] (7.993 ms) : 0, 7993
Telemetry [candidate] (8.035 ms) : 0, 8035
section profiling
BytebuddyAgent [baseline] (680.586 ms) : 0, 680586
BytebuddyAgent [candidate] (677.832 ms) : 0, 677832
GlobalTracer [baseline] (362.964 ms) : 0, 362964
GlobalTracer [candidate] (360.623 ms) : 0, 360623
AppSec [baseline] (33.84 ms) : 0, 33840
AppSec [candidate] (32.37 ms) : 0, 32370
Debugger [baseline] (10.503 ms) : 0, 10503
Debugger [candidate] (11.287 ms) : 0, 11287
Remote Config [baseline] (677.046 µs) : 0, 677
Remote Config [candidate] (1.407 ms) : 0, 1407
Telemetry [baseline] (7.977 ms) : 0, 7977
Telemetry [candidate] (7.928 ms) : 0, 7928
ProfilingAgent [baseline] (102.429 ms) : 0, 102429
ProfilingAgent [candidate] (102.338 ms) : 0, 102338
Profiling [baseline] (102.454 ms) : 0, 102454
Profiling [candidate] (102.362 ms) : 0, 102362
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section baseline
no_agent (37.984 ms) : 37677, 38292
. : milestone, 37984,
appsec (47.782 ms) : 47346, 48217
. : milestone, 47782,
code_origins (45.753 ms) : 45372, 46134
. : milestone, 45753,
iast (44.817 ms) : 44437, 45198
. : milestone, 44817,
profiling (46.623 ms) : 46202, 47044
. : milestone, 46623,
tracing (42.463 ms) : 42118, 42808
. : milestone, 42463,
section candidate
no_agent (36.314 ms) : 36012, 36615
. : milestone, 36314,
appsec (48.031 ms) : 47602, 48459
. : milestone, 48031,
code_origins (47.041 ms) : 46631, 47451
. : milestone, 47041,
iast (44.166 ms) : 43790, 44541
. : milestone, 44166,
profiling (48.236 ms) : 47768, 48704
. : milestone, 48236,
tracing (44.112 ms) : 43745, 44479
. : milestone, 44112,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section baseline
no_agent (4.446 ms) : 4391, 4501
. : milestone, 4446,
iast (9.285 ms) : 9137, 9433
. : milestone, 9285,
iast_FULL (14.001 ms) : 13726, 14276
. : milestone, 14001,
iast_GLOBAL (10.807 ms) : 10614, 10999
. : milestone, 10807,
profiling (8.782 ms) : 8643, 8921
. : milestone, 8782,
tracing (7.415 ms) : 7311, 7520
. : milestone, 7415,
section candidate
no_agent (4.354 ms) : 4303, 4404
. : milestone, 4354,
iast (9.351 ms) : 9192, 9511
. : milestone, 9351,
iast_FULL (13.616 ms) : 13346, 13885
. : milestone, 13616,
iast_GLOBAL (10.216 ms) : 10037, 10394
. : milestone, 10216,
profiling (9.07 ms) : 8924, 9216
. : milestone, 9070,
tracing (7.544 ms) : 7430, 7658
. : milestone, 7544,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section baseline
no_agent (15.021 s) : 15021000, 15021000
. : milestone, 15021000,
appsec (15.012 s) : 15012000, 15012000
. : milestone, 15012000,
iast (18.387 s) : 18387000, 18387000
. : milestone, 18387000,
iast_GLOBAL (17.986 s) : 17986000, 17986000
. : milestone, 17986000,
profiling (15.337 s) : 15337000, 15337000
. : milestone, 15337000,
tracing (14.81 s) : 14810000, 14810000
. : milestone, 14810000,
section candidate
no_agent (15.325 s) : 15325000, 15325000
. : milestone, 15325000,
appsec (14.842 s) : 14842000, 14842000
. : milestone, 14842000,
iast (18.078 s) : 18078000, 18078000
. : milestone, 18078000,
iast_GLOBAL (18.158 s) : 18158000, 18158000
. : milestone, 18158000,
profiling (15.327 s) : 15327000, 15327000
. : milestone, 15327000,
tracing (14.813 s) : 14813000, 14813000
. : milestone, 14813000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~2743f880b1, baseline=1.51.0-SNAPSHOT~84c3bbd29f
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.427 ms) : 2377, 2477
. : milestone, 2427,
iast (2.209 ms) : 2146, 2271
. : milestone, 2209,
iast_GLOBAL (2.243 ms) : 2180, 2305
. : milestone, 2243,
profiling (2.039 ms) : 1989, 2089
. : milestone, 2039,
tracing (2.032 ms) : 1984, 2081
. : milestone, 2032,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.422 ms) : 2372, 2471
. : milestone, 2422,
iast (2.206 ms) : 2143, 2269
. : milestone, 2206,
iast_GLOBAL (2.252 ms) : 2189, 2315
. : milestone, 2252,
profiling (2.05 ms) : 1999, 2100
. : milestone, 2050,
tracing (2.025 ms) : 1977, 2073
. : milestone, 2025,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
APPSEC-58131
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]