Skip to content

Adjust muzzle limit for vertx instrumentations #8846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhlidd merged 8 commits into from
May 20, 2025
Merged

Adjust muzzle limit for vertx instrumentations #8846

mhlidd merged 8 commits into from
May 20, 2025

Conversation

@mhlidd
Copy link
Contributor

@mhlidd mhlidd commented May 19, 2025

What Does This Do

Make the same adjustments as the following PR.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mhlidd mhlidd requested a review from a team as a code owner May 19, 2025 11:59
@mhlidd mhlidd requested a review from amarziali May 19, 2025 11:59
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mhlidd mhlidd added comp: testing Testing tag: no release notes Changes to exclude from release notes type: bug Bug report and fix labels May 19, 2025
@pr-commenter
Copy link

pr-commenter bot commented May 19, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/remove-muzzle-limit
git_commit_date 1747732349 1747733027
git_commit_sha 4ab4ee3 1e12ac4
release_version 1.50.0-SNAPSHOT~4ab4ee3044 1.50.0-SNAPSHOT~1e12ac4812
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747735450 1747735450
ci_job_id 945422675 945422675
ci_pipeline_id 65580925 65580925
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-qba76gvb-project-304-concurrent-0-fgzjvwki 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-qba76gvb-project-304-concurrent-0-fgzjvwki 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016834
Total [baseline] (8.65 s) : 0, 8649990
Agent [candidate] (1.019 s) : 0, 1019406
Total [candidate] (8.641 s) : 0, 8641128
section iast
Agent [baseline] (1.156 s) : 0, 1156116
Total [baseline] (9.213 s) : 0, 9213420
Agent [candidate] (1.162 s) : 0, 1161729
Total [candidate] (9.277 s) : 0, 9277438
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.157 s) : 0, 1157043
Total [baseline] (9.217 s) : 0, 9217295
Agent [candidate] (1.148 s) : 0, 1147644
Total [candidate] (9.193 s) : 0, 9193218
section iast_TELEMETRY_OFF
Agent [baseline] (1.149 s) : 0, 1148988
Total [baseline] (9.262 s) : 0, 9261910
Agent [candidate] (1.152 s) : 0, 1152158
Total [candidate] (9.227 s) : 0, 9227434
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.017 s -
Agent iast 1.156 s 139.282 ms (13.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.157 s 140.21 ms (13.8%)
Agent iast_TELEMETRY_OFF 1.149 s 132.154 ms (13.0%)
Total tracing 8.65 s -
Total iast 9.213 s 563.43 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.217 s 567.306 ms (6.6%)
Total iast_TELEMETRY_OFF 9.262 s 611.921 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent iast 1.162 s 142.323 ms (14.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.148 s 128.238 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.152 s 132.752 ms (13.0%)
Total tracing 8.641 s -
Total iast 9.277 s 636.311 ms (7.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.193 s 552.091 ms (6.4%)
Total iast_TELEMETRY_OFF 9.227 s 586.306 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.172 ms) : 0, 681172
BytebuddyAgent [candidate] (682.547 ms) : 0, 682547
GlobalTracer [baseline] (239.587 ms) : 0, 239587
GlobalTracer [candidate] (240.131 ms) : 0, 240131
AppSec [baseline] (54.394 ms) : 0, 54394
AppSec [candidate] (55.891 ms) : 0, 55891
Debugger [baseline] (8.367 ms) : 0, 8367
Debugger [candidate] (7.57 ms) : 0, 7570
Remote Config [baseline] (709.749 µs) : 0, 710
Remote Config [candidate] (699.362 µs) : 0, 699
Telemetry [baseline] (9.079 ms) : 0, 9079
Telemetry [candidate] (9.03 ms) : 0, 9030
section iast
BytebuddyAgent [baseline] (807.342 ms) : 0, 807342
BytebuddyAgent [candidate] (811.906 ms) : 0, 811906
GlobalTracer [baseline] (231.533 ms) : 0, 231533
GlobalTracer [candidate] (232.295 ms) : 0, 232295
IAST [baseline] (27.018 ms) : 0, 27018
IAST [candidate] (27.075 ms) : 0, 27075
AppSec [baseline] (52.236 ms) : 0, 52236
AppSec [candidate] (52.329 ms) : 0, 52329
Debugger [baseline] (5.925 ms) : 0, 5925
Debugger [candidate] (5.967 ms) : 0, 5967
Remote Config [baseline] (615.875 µs) : 0, 616
Remote Config [candidate] (600.404 µs) : 0, 600
Telemetry [baseline] (7.855 ms) : 0, 7855
Telemetry [candidate] (7.866 ms) : 0, 7866
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.03 ms) : 0, 809030
BytebuddyAgent [candidate] (800.503 ms) : 0, 800503
GlobalTracer [baseline] (230.438 ms) : 0, 230438
GlobalTracer [candidate] (230.522 ms) : 0, 230522
IAST [baseline] (27.778 ms) : 0, 27778
IAST [candidate] (28.341 ms) : 0, 28341
AppSec [baseline] (51.602 ms) : 0, 51602
AppSec [candidate] (49.549 ms) : 0, 49549
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (5.921 ms) : 0, 5921
Remote Config [baseline] (617.147 µs) : 0, 617
Remote Config [candidate] (619.555 µs) : 0, 620
Telemetry [baseline] (7.987 ms) : 0, 7987
Telemetry [candidate] (7.953 ms) : 0, 7953
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.881 ms) : 0, 801881
BytebuddyAgent [candidate] (804.608 ms) : 0, 804608
GlobalTracer [baseline] (231.05 ms) : 0, 231050
GlobalTracer [candidate] (231.067 ms) : 0, 231067
IAST [baseline] (23.933 ms) : 0, 23933
IAST [candidate] (22.49 ms) : 0, 22490
AppSec [baseline] (54.165 ms) : 0, 54165
AppSec [candidate] (56.021 ms) : 0, 56021
Debugger [baseline] (5.958 ms) : 0, 5958
Debugger [candidate] (5.947 ms) : 0, 5947
Remote Config [baseline] (607.723 µs) : 0, 608
Remote Config [candidate] (602.333 µs) : 0, 602
Telemetry [baseline] (7.778 ms) : 0, 7778
Telemetry [candidate] (7.759 ms) : 0, 7759
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017167
Total [baseline] (10.461 s) : 0, 10460907
Agent [candidate] (1.022 s) : 0, 1021796
Total [candidate] (10.505 s) : 0, 10505061
section appsec
Agent [baseline] (1.163 s) : 0, 1163426
Total [baseline] (10.684 s) : 0, 10683757
Agent [candidate] (1.164 s) : 0, 1164117
Total [candidate] (10.692 s) : 0, 10692204
section iast
Agent [baseline] (1.148 s) : 0, 1148116
Total [baseline] (10.873 s) : 0, 10872669
Agent [candidate] (1.148 s) : 0, 1147667
Total [candidate] (10.906 s) : 0, 10906032
section profiling
Agent [baseline] (1.284 s) : 0, 1283717
Total [baseline] (10.826 s) : 0, 10825974
Agent [candidate] (1.293 s) : 0, 1292780
Total [candidate] (10.926 s) : 0, 10926027
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.017 s -
Agent appsec 1.163 s 146.259 ms (14.4%)
Agent iast 1.148 s 130.949 ms (12.9%)
Agent profiling 1.284 s 266.55 ms (26.2%)
Total tracing 10.461 s -
Total appsec 10.684 s 222.85 ms (2.1%)
Total iast 10.873 s 411.762 ms (3.9%)
Total profiling 10.826 s 365.067 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent appsec 1.164 s 142.32 ms (13.9%)
Agent iast 1.148 s 125.87 ms (12.3%)
Agent profiling 1.293 s 270.983 ms (26.5%)
Total tracing 10.505 s -
Total appsec 10.692 s 187.142 ms (1.8%)
Total iast 10.906 s 400.971 ms (3.8%)
Total profiling 10.926 s 420.966 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.475 ms) : 0, 681475
BytebuddyAgent [candidate] (684.068 ms) : 0, 684068
GlobalTracer [baseline] (239.444 ms) : 0, 239444
GlobalTracer [candidate] (240.806 ms) : 0, 240806
AppSec [baseline] (54.166 ms) : 0, 54166
AppSec [candidate] (55.263 ms) : 0, 55263
Debugger [baseline] (8.896 ms) : 0, 8896
Debugger [candidate] (8.361 ms) : 0, 8361
Remote Config [baseline] (682.334 µs) : 0, 682
Remote Config [candidate] (689.666 µs) : 0, 690
Telemetry [baseline] (8.968 ms) : 0, 8968
Telemetry [candidate] (9.059 ms) : 0, 9059
section appsec
BytebuddyAgent [baseline] (701.99 ms) : 0, 701990
BytebuddyAgent [candidate] (702.746 ms) : 0, 702746
GlobalTracer [baseline] (237.044 ms) : 0, 237044
GlobalTracer [candidate] (236.863 ms) : 0, 236863
AppSec [baseline] (175.55 ms) : 0, 175550
AppSec [candidate] (175.784 ms) : 0, 175784
Debugger [baseline] (5.942 ms) : 0, 5942
Debugger [candidate] (5.904 ms) : 0, 5904
Remote Config [baseline] (630.011 µs) : 0, 630
Remote Config [candidate] (619.811 µs) : 0, 620
Telemetry [baseline] (7.761 ms) : 0, 7761
Telemetry [candidate] (7.747 ms) : 0, 7747
IAST [baseline] (21.877 ms) : 0, 21877
IAST [candidate] (21.759 ms) : 0, 21759
section iast
BytebuddyAgent [baseline] (801.28 ms) : 0, 801280
BytebuddyAgent [candidate] (800.915 ms) : 0, 800915
GlobalTracer [baseline] (230.8 ms) : 0, 230800
GlobalTracer [candidate] (230.588 ms) : 0, 230588
AppSec [baseline] (49.346 ms) : 0, 49346
AppSec [candidate] (49.134 ms) : 0, 49134
Debugger [baseline] (5.864 ms) : 0, 5864
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (591.694 µs) : 0, 592
Remote Config [candidate] (593.986 µs) : 0, 594
Telemetry [baseline] (7.801 ms) : 0, 7801
Telemetry [candidate] (7.89 ms) : 0, 7890
IAST [baseline] (28.918 ms) : 0, 28918
IAST [candidate] (29.186 ms) : 0, 29186
section profiling
BytebuddyAgent [baseline] (676.304 ms) : 0, 676304
BytebuddyAgent [candidate] (681.591 ms) : 0, 681591
GlobalTracer [baseline] (375.501 ms) : 0, 375501
GlobalTracer [candidate] (378.034 ms) : 0, 378034
AppSec [baseline] (61.858 ms) : 0, 61858
AppSec [candidate] (62.603 ms) : 0, 62603
Debugger [baseline] (6.389 ms) : 0, 6389
Debugger [candidate] (6.357 ms) : 0, 6357
Remote Config [baseline] (686.92 µs) : 0, 687
Remote Config [candidate] (682.612 µs) : 0, 683
Telemetry [baseline] (8.328 ms) : 0, 8328
Telemetry [candidate] (8.322 ms) : 0, 8322
ProfilingAgent [baseline] (103.54 ms) : 0, 103540
ProfilingAgent [candidate] (104.062 ms) : 0, 104062
Profiling [baseline] (103.564 ms) : 0, 103564
Profiling [candidate] (104.087 ms) : 0, 104087
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-20T09:34:33 2025-05-20T09:42:20
git_branch master mhlidd/remove-muzzle-limit
git_commit_date 1747732349 1747733027
git_commit_sha 4ab4ee3 1e12ac4
release_version 1.50.0-SNAPSHOT~4ab4ee3044 1.50.0-SNAPSHOT~1e12ac4812
start_time 2025-05-20T09:34:18 2025-05-20T09:42:06
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1747734540 1747734540
ci_job_id 945422676 945422676
ci_pipeline_id 65580925 65580925
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-uus1uqpw-project-304-concurrent-2-n3d5l37d 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-uus1uqpw-project-304-concurrent-2-n3d5l37d 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.259 µs) : 359, 399
.   : milestone, 379,
iast (522.101 µs) : 500, 544
.   : milestone, 522,
iast_FULL (740.567 µs) : 719, 762
.   : milestone, 741,
iast_GLOBAL (577.8 µs) : 556, 600
.   : milestone, 578,
iast_HARDCODED_SECRET_DISABLED (523.367 µs) : 500, 547
.   : milestone, 523,
iast_INACTIVE (480.283 µs) : 457, 503
.   : milestone, 480,
iast_TELEMETRY_OFF (525.873 µs) : 503, 549
.   : milestone, 526,
tracing (466.675 µs) : 444, 489
.   : milestone, 467,
section candidate
no_agent (390.905 µs) : 371, 411
.   : milestone, 391,
iast (532.252 µs) : 510, 554
.   : milestone, 532,
iast_FULL (738.103 µs) : 716, 760
.   : milestone, 738,
iast_GLOBAL (565.635 µs) : 544, 587
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (525.996 µs) : 502, 550
.   : milestone, 526,
iast_INACTIVE (476.039 µs) : 454, 498
.   : milestone, 476,
iast_TELEMETRY_OFF (528.091 µs) : 505, 551
.   : milestone, 528,
tracing (467.488 µs) : 446, 489
.   : milestone, 467,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.259 µs [359.255 µs, 399.264 µs] -
iast 522.101 µs [500.137 µs, 544.065 µs] 142.842 µs (37.7%)
iast_FULL 740.567 µs [718.765 µs, 762.37 µs] 361.308 µs (95.3%)
iast_GLOBAL 577.8 µs [555.926 µs, 599.674 µs] 198.541 µs (52.3%)
iast_HARDCODED_SECRET_DISABLED 523.367 µs [500.21 µs, 546.523 µs] 144.107 µs (38.0%)
iast_INACTIVE 480.283 µs [457.423 µs, 503.143 µs] 101.024 µs (26.6%)
iast_TELEMETRY_OFF 525.873 µs [502.852 µs, 548.894 µs] 146.614 µs (38.7%)
tracing 466.675 µs [444.407 µs, 488.944 µs] 87.416 µs (23.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 390.905 µs [371.126 µs, 410.684 µs] -
iast 532.252 µs [510.29 µs, 554.214 µs] 141.347 µs (36.2%)
iast_FULL 738.103 µs [716.007 µs, 760.2 µs] 347.198 µs (88.8%)
iast_GLOBAL 565.635 µs [544.001 µs, 587.269 µs] 174.73 µs (44.7%)
iast_HARDCODED_SECRET_DISABLED 525.996 µs [502.249 µs, 549.743 µs] 135.091 µs (34.6%)
iast_INACTIVE 476.039 µs [454.343 µs, 497.735 µs] 85.134 µs (21.8%)
iast_TELEMETRY_OFF 528.091 µs [505.021 µs, 551.161 µs] 137.186 µs (35.1%)
tracing 467.488 µs [445.544 µs, 489.432 µs] 76.583 µs (19.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1381
.   : milestone, 1362,
appsec (1.741 ms) : 1717, 1764
.   : milestone, 1741,
appsec_no_iast (1.745 ms) : 1721, 1768
.   : milestone, 1745,
code_origins (1.689 ms) : 1663, 1716
.   : milestone, 1689,
iast (1.517 ms) : 1492, 1541
.   : milestone, 1517,
profiling (1.531 ms) : 1508, 1554
.   : milestone, 1531,
tracing (1.516 ms) : 1492, 1541
.   : milestone, 1516,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.739 ms) : 1715, 1762
.   : milestone, 1739,
appsec_no_iast (1.745 ms) : 1721, 1768
.   : milestone, 1745,
code_origins (1.676 ms) : 1650, 1703
.   : milestone, 1676,
iast (1.534 ms) : 1510, 1558
.   : milestone, 1534,
profiling (1.533 ms) : 1509, 1556
.   : milestone, 1533,
tracing (1.507 ms) : 1482, 1532
.   : milestone, 1507,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.381 ms] -
appsec 1.741 ms [1.717 ms, 1.764 ms] 379.12 µs (27.8%)
appsec_no_iast 1.745 ms [1.721 ms, 1.768 ms] 382.961 µs (28.1%)
code_origins 1.689 ms [1.663 ms, 1.716 ms] 327.862 µs (24.1%)
iast 1.517 ms [1.492 ms, 1.541 ms] 155.306 µs (11.4%)
profiling 1.531 ms [1.508 ms, 1.554 ms] 169.738 µs (12.5%)
tracing 1.516 ms [1.492 ms, 1.541 ms] 154.786 µs (11.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.739 ms [1.715 ms, 1.762 ms] 376.243 µs (27.6%)
appsec_no_iast 1.745 ms [1.721 ms, 1.768 ms] 382.289 µs (28.1%)
code_origins 1.676 ms [1.65 ms, 1.703 ms] 313.842 µs (23.0%)
iast 1.534 ms [1.51 ms, 1.558 ms] 171.631 µs (12.6%)
profiling 1.533 ms [1.509 ms, 1.556 ms] 170.594 µs (12.5%)
tracing 1.507 ms [1.482 ms, 1.532 ms] 144.311 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/remove-muzzle-limit
git_commit_date 1747732349 1747733027
git_commit_sha 4ab4ee3 1e12ac4
release_version 1.50.0-SNAPSHOT~4ab4ee3044 1.50.0-SNAPSHOT~1e12ac4812
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1747735045 1747735045
ci_job_id 945422677 945422677
ci_pipeline_id 65580925 65580925
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-qba76gvb-project-304-concurrent-1-tlorfp77 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-qba76gvb-project-304-concurrent-1-tlorfp77 6.8.0-1028-aws #30~22.04.1-Ubuntu SMP Sun Apr 20 06:03:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.414 ms) : 2364, 2464
.   : milestone, 2414,
iast (2.196 ms) : 2133, 2259
.   : milestone, 2196,
iast_GLOBAL (2.242 ms) : 2179, 2305
.   : milestone, 2242,
profiling (2.037 ms) : 1987, 2087
.   : milestone, 2037,
tracing (2.025 ms) : 1976, 2073
.   : milestone, 2025,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.419 ms) : 2368, 2469
.   : milestone, 2419,
iast (2.19 ms) : 2127, 2253
.   : milestone, 2190,
iast_GLOBAL (2.241 ms) : 2177, 2304
.   : milestone, 2241,
profiling (2.059 ms) : 2008, 2110
.   : milestone, 2059,
tracing (2.029 ms) : 1980, 2078
.   : milestone, 2029,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.464 ms, 1.487 ms] -
appsec 2.414 ms [2.364 ms, 2.464 ms] 938.359 µs (63.6%)
iast 2.196 ms [2.133 ms, 2.259 ms] 720.663 µs (48.8%)
iast_GLOBAL 2.242 ms [2.179 ms, 2.305 ms] 766.642 µs (52.0%)
profiling 2.037 ms [1.987 ms, 2.087 ms] 561.581 µs (38.1%)
tracing 2.025 ms [1.976 ms, 2.073 ms] 549.169 µs (37.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.419 ms [2.368 ms, 2.469 ms] 942.222 µs (63.8%)
iast 2.19 ms [2.127 ms, 2.253 ms] 714.021 µs (48.4%)
iast_GLOBAL 2.241 ms [2.177 ms, 2.304 ms] 764.275 µs (51.8%)
profiling 2.059 ms [2.008 ms, 2.11 ms] 582.472 µs (39.5%)
tracing 2.029 ms [1.98 ms, 2.078 ms] 553.12 µs (37.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1e12ac4812, baseline=1.50.0-SNAPSHOT~4ab4ee3044
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.926 s) : 14926000, 14926000
.   : milestone, 14926000,
appsec (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,
iast (19.301 s) : 19301000, 19301000
.   : milestone, 19301000,
iast_GLOBAL (17.988 s) : 17988000, 17988000
.   : milestone, 17988000,
profiling (15.083 s) : 15083000, 15083000
.   : milestone, 15083000,
tracing (15.053 s) : 15053000, 15053000
.   : milestone, 15053000,
section candidate
no_agent (14.964 s) : 14964000, 14964000
.   : milestone, 14964000,
appsec (15.132 s) : 15132000, 15132000
.   : milestone, 15132000,
iast (19.129 s) : 19129000, 19129000
.   : milestone, 19129000,
iast_GLOBAL (18.022 s) : 18022000, 18022000
.   : milestone, 18022000,
profiling (15.281 s) : 15281000, 15281000
.   : milestone, 15281000,
tracing (15.053 s) : 15053000, 15053000
.   : milestone, 15053000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.926 s [14.926 s, 14.926 s] -
appsec 14.964 s [14.964 s, 14.964 s] 38.0 ms (0.3%)
iast 19.301 s [19.301 s, 19.301 s] 4.375 s (29.3%)
iast_GLOBAL 17.988 s [17.988 s, 17.988 s] 3.062 s (20.5%)
profiling 15.083 s [15.083 s, 15.083 s] 157.0 ms (1.1%)
tracing 15.053 s [15.053 s, 15.053 s] 127.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.964 s [14.964 s, 14.964 s] -
appsec 15.132 s [15.132 s, 15.132 s] 168.0 ms (1.1%)
iast 19.129 s [19.129 s, 19.129 s] 4.165 s (27.8%)
iast_GLOBAL 18.022 s [18.022 s, 18.022 s] 3.058 s (20.4%)
profiling 15.281 s [15.281 s, 15.281 s] 317.0 ms (2.1%)
tracing 15.053 s [15.053 s, 15.053 s] 89.0 ms (0.6%)

mcculls
mcculls previously approved these changes May 19, 2025
View reviewed changes
@mcculls
Copy link
Contributor

mcculls commented May 19, 2025

@mhlidd some further tweaking of the range might be needed:

> Task :dd-java-agent:instrumentation:vertx-pg-client-4.0:muzzle-AssertPass-io.vertx-vertx-pg-client-5.0.0 FAILED
FAILED MUZZLE VALIDATION: datadog.trace.instrumentation.vertx_pg_client_4.PgPoolImplInstrumentation mismatches:
-- datadog.trace.instrumentation.vertx_pg_client_4.PgPoolImplAdvice:29 Missing method io.vertx.pgclient.impl.PgConnectionFactory#connect(Lio/vertx/core/Context;)Lio/vertx/core/Future;

@mcculls mcculls dismissed their stale review May 19, 2025 12:47

muzzle still failing on CI

@amarziali
Copy link
Contributor

amarziali commented May 19, 2025

@mhlidd some further tweaking of the range might be needed:

> Task :dd-java-agent:instrumentation:vertx-pg-client-4.0:muzzle-AssertPass-io.vertx-vertx-pg-client-5.0.0 FAILED
FAILED MUZZLE VALIDATION: datadog.trace.instrumentation.vertx_pg_client_4.PgPoolImplInstrumentation mismatches:
-- datadog.trace.instrumentation.vertx_pg_client_4.PgPoolImplAdvice:29 Missing method io.vertx.pgclient.impl.PgConnectionFactory#connect(Lio/vertx/core/Context;)Lio/vertx/core/Future;

Yes I just pushed a workaround to have a quick fix. Even if the advices are applied inconsistently on 5+, they are not creating spans so it can be acceptable. However a proper muzzle fix should be done

mhlidd
mhlidd commented May 20, 2025
View reviewed changes
dd-java-agent/instrumentation/vertx-web-4.0/build.gradle Outdated
Comment on lines 18 to 19
versions = "[4.0.0,)"
javaVersion = "11"
Copy link
Contributor Author

@mhlidd mhlidd May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amarziali Made a similar change here. Let me know if this is incorrect 🙇‍♂️

Copy link
Contributor

@amarziali amarziali May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed since it seems that advices are not applying for >=5. It looks passing locally now

@mhlidd mhlidd changed the title Adjust muzzle limit for vertx-pg-client Adjust muzzle limit for vertx instrumentations May 20, 2025
@mhlidd mhlidd merged commit 0ebd52b into master May 20, 2025
590 of 591 checks passed
@mhlidd mhlidd deleted the mhlidd/remove-muzzle-limit branch May 20, 2025 12:22
@github-actions github-actions bot added this to the 1.50.0 milestone May 20, 2025
PerfectSlayer pushed a commit that referenced this pull request Jun 12, 2025
@mhlidd @amarziali @PerfectSlayer
Adjust muzzle limit for vertx instrumentations (#8846)
3e38785 
* removing limits for version 5.0.0 on muzzle

* add vertx-pg-client-4.4.2

* workaround

* use java 11 for vertx mysql client muzzle

* use java 11 for all the vertx 3.9 checking 5+

* fix muzzle for vertx-web

* modifying vertx-web-4.0

* skip assertInverse for muzzle vertx web 4

---------

Co-authored-by: Andrea Marziali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@amarziali amarziali Awaiting requested review from amarziali

Assignees

No one assigned

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mhlidd @mcculls @amarziali