Skip to content

Ensure net.bytebuddy.raw is set to true when ConfigTransformSpockExtension is installed #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcculls merged 1 commit into from
Apr 24, 2025
Merged

Ensure net.bytebuddy.raw is set to true when ConfigTransformSpockExtension is installed #8728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...rc/test/groovy/datadog/trace/agent/tooling/bytebuddy/outline/TypeFactoryForkedTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package datadog.trace.agent.tooling.bytebuddy.outline

import datadog.trace.agent.tooling.bytebuddy.ClassFileLocators
import datadog.trace.agent.tooling.bytebuddy.matcher.DDElementMatchers
import net.bytebuddy.description.type.TypeDescription
import spock.lang.Shared
import spock.lang.Specification

Expand All @@ -28,6 +29,9 @@ class TypeFactoryForkedTest extends Specification {
def hasContextField = declaresContextField('java.lang.Runnable', 'java.lang.String')

def "can mix full types with outlines"() {
expect:
TypeDescription.AbstractBase.RAW_TYPES // this test relies on raw-types

when:
def systemLoader = ClassLoader.systemClassLoader
def systemLocator = ClassFileLocators.classFileLocator(systemLoader)
Expand Down
5 changes: 5 additions & 0 deletions ...s/test-utils/src/main/groovy/datadog/trace/test/util/ConfigTransformSpockExtension.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ import static net.bytebuddy.matcher.ElementMatchers.none
* Transforms the Config class to make its INSTANCE field non-final and volatile.
*/
class ConfigTransformSpockExtension implements IGlobalExtension {
static {
// same setting as AgentInstaller to avoid spurious agent-tooling test failures
System.setProperty("net.bytebuddy.raw", "true")
}

static final String INST_CONFIG = "datadog.trace.api.InstrumenterConfig"
static final String CONFIG = "datadog.trace.api.Config"

Expand Down