Upgrade libddwaf java to 14.0.0 #8654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
6 times, most recently
from
54f9c5d to
71046f9
Compare
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
5 times, most recently
from
a5ff9ce to
88e240e
Compare
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
sezen-datadog
added
comp: asm iast
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
from
e706341 to
8a9e7c1
Compare
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
2 times, most recently
from
af04cd6 to
ec2a6fb
Compare
smola
requested changes
Jun 4, 2025
dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java
Show resolved
Hide resolved
dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
smola
reviewed
Jun 4, 2025
remote-config/remote-config-api/src/main/java/datadog/remoteconfig/ConfigurationPoller.java
Outdated
Show resolved
Hide resolved
smola
reviewed
Jun 4, 2025
...config/remote-config-core/src/main/java/datadog/remoteconfig/DefaultConfigurationPoller.java
Outdated
Show resolved
Hide resolved
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
from
86a8a1b to
e7e8985
Compare
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
2 times, most recently
from
bed5c32 to
da05633
Compare
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
3 times, most recently
from
5b79c2f to
8212f64
Compare
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
3 times, most recently
from
2893e4c to
60d5eee
Compare
smola
reviewed
Jun 23, 2025
dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/ddwaf/WAFModuleSpecification.groovy
Outdated
Show resolved
Hide resolved
...appsec/src/test/groovy/com/datadog/appsec/config/AppSecConfigServiceImplSpecification.groovy
Show resolved
Hide resolved
...appsec/src/test/groovy/com/datadog/appsec/config/AppSecConfigServiceImplSpecification.groovy
Show resolved
Hide resolved
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
2 times, most recently
from
e18eb3a to
02b1985
Compare
smola
requested changes
Jun 24, 2025
dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
dd-java-agent/appsec/src/main/java/com/datadog/appsec/config/AppSecConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
smola
approved these changes
Jun 24, 2025
sezen-datadog
force-pushed
the
sezen.leblay/upgrade-libddwaf-java-1.23
branch
from
d802d00 to
d5435c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Integrates upgrade of libddwaf java to version 14.0.0 (major upgrade because of libddwaf upgrade to version 1.24.1 in DataDog/libddwaf-java#159) The most important changes include upgrading the libsqreen dependency, replacing the AppSecConfig and AppSecConfigDeserializer classes with a new WAF configuration approach (use of raw configurations in map formats), and refactoring the AppSecSystem and WafBenchmark classes to integrate with the updated WAF system.
Motivation
Remote config errors are now reported per each remote config file independently.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-55502