-
Notifications
You must be signed in to change notification settings - Fork 322
Revert "FIXME: temporarily ignore hostname assertions on CircleCI (#8411)" #8422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit ebdbdd4.
PerfectSlayer
approved these changes
Feb 19, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041131
Total [baseline] (10.521 s) : 0, 10521025
Agent [candidate] (1.044 s) : 0, 1044456
Total [candidate] (10.467 s) : 0, 10467319
section appsec
Agent [baseline] (1.187 s) : 0, 1187030
Total [baseline] (10.787 s) : 0, 10786731
Agent [candidate] (1.184 s) : 0, 1183522
Total [candidate] (10.743 s) : 0, 10743201
section iast
Agent [baseline] (1.173 s) : 0, 1172828
Total [baseline] (10.997 s) : 0, 10996504
Agent [candidate] (1.175 s) : 0, 1174929
Total [candidate] (10.952 s) : 0, 10952325
section profiling
Agent [baseline] (1.266 s) : 0, 1266111
Total [baseline] (10.981 s) : 0, 10980981
Agent [candidate] (1.265 s) : 0, 1264959
Total [candidate] (10.926 s) : 0, 10925559
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.36 ms) : 0, 718360
BytebuddyAgent [candidate] (720.508 ms) : 0, 720508
GlobalTracer [baseline] (239.884 ms) : 0, 239884
GlobalTracer [candidate] (240.598 ms) : 0, 240598
AppSec [baseline] (55.454 ms) : 0, 55454
AppSec [candidate] (55.857 ms) : 0, 55857
Remote Config [baseline] (702.346 µs) : 0, 702
Remote Config [candidate] (702.097 µs) : 0, 702
Telemetry [baseline] (11.563 ms) : 0, 11563
Telemetry [candidate] (11.606 ms) : 0, 11606
section appsec
BytebuddyAgent [baseline] (737.921 ms) : 0, 737921
BytebuddyAgent [candidate] (735.396 ms) : 0, 735396
GlobalTracer [baseline] (237.052 ms) : 0, 237052
GlobalTracer [candidate] (236.943 ms) : 0, 236943
AppSec [baseline] (176.757 ms) : 0, 176757
AppSec [candidate] (176.277 ms) : 0, 176277
Remote Config [baseline] (669.838 µs) : 0, 670
Remote Config [candidate] (675.403 µs) : 0, 675
Telemetry [baseline] (8.648 ms) : 0, 8648
Telemetry [candidate] (8.311 ms) : 0, 8311
IAST [baseline] (21.236 ms) : 0, 21236
IAST [candidate] (21.453 ms) : 0, 21453
section iast
BytebuddyAgent [baseline] (837.558 ms) : 0, 837558
BytebuddyAgent [candidate] (838.54 ms) : 0, 838540
GlobalTracer [baseline] (230.867 ms) : 0, 230867
GlobalTracer [candidate] (231.308 ms) : 0, 231308
AppSec [baseline] (57.09 ms) : 0, 57090
AppSec [candidate] (57.364 ms) : 0, 57364
Remote Config [baseline] (608.828 µs) : 0, 609
Remote Config [candidate] (617.697 µs) : 0, 618
Telemetry [baseline] (8.614 ms) : 0, 8614
Telemetry [candidate] (8.817 ms) : 0, 8817
IAST [baseline] (22.905 ms) : 0, 22905
IAST [candidate] (23.036 ms) : 0, 23036
section profiling
BytebuddyAgent [baseline] (710.07 ms) : 0, 710070
BytebuddyAgent [candidate] (709.957 ms) : 0, 709957
GlobalTracer [baseline] (351.343 ms) : 0, 351343
GlobalTracer [candidate] (351.184 ms) : 0, 351184
AppSec [baseline] (55.673 ms) : 0, 55673
AppSec [candidate] (55.062 ms) : 0, 55062
Remote Config [baseline] (681.632 µs) : 0, 682
Remote Config [candidate] (694.475 µs) : 0, 694
Telemetry [baseline] (8.995 ms) : 0, 8995
Telemetry [candidate] (9.04 ms) : 0, 9040
ProfilingAgent [baseline] (96.878 ms) : 0, 96878
ProfilingAgent [candidate] (96.583 ms) : 0, 96583
Profiling [baseline] (96.904 ms) : 0, 96904
Profiling [candidate] (96.608 ms) : 0, 96608
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043924
Total [baseline] (8.736 s) : 0, 8736343
Agent [candidate] (1.047 s) : 0, 1046802
Total [candidate] (8.655 s) : 0, 8654980
section iast
Agent [baseline] (1.196 s) : 0, 1196209
Total [baseline] (9.302 s) : 0, 9302459
Agent [candidate] (1.174 s) : 0, 1174290
Total [candidate] (9.302 s) : 0, 9302034
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.188 s) : 0, 1188270
Total [baseline] (9.254 s) : 0, 9253644
Agent [candidate] (1.173 s) : 0, 1173017
Total [candidate] (9.231 s) : 0, 9231147
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168412
Total [baseline] (9.271 s) : 0, 9270825
Agent [candidate] (1.172 s) : 0, 1172426
Total [candidate] (9.239 s) : 0, 9238536
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.722 ms) : 0, 718722
BytebuddyAgent [candidate] (721.905 ms) : 0, 721905
GlobalTracer [baseline] (240.43 ms) : 0, 240430
GlobalTracer [candidate] (241.598 ms) : 0, 241598
AppSec [baseline] (56.54 ms) : 0, 56540
AppSec [candidate] (55.833 ms) : 0, 55833
Remote Config [baseline] (703.783 µs) : 0, 704
Remote Config [candidate] (711.616 µs) : 0, 712
Telemetry [baseline] (12.307 ms) : 0, 12307
Telemetry [candidate] (11.462 ms) : 0, 11462
section iast
BytebuddyAgent [baseline] (855.152 ms) : 0, 855152
BytebuddyAgent [candidate] (838.169 ms) : 0, 838169
GlobalTracer [baseline] (234.448 ms) : 0, 234448
GlobalTracer [candidate] (231.461 ms) : 0, 231461
AppSec [baseline] (58.047 ms) : 0, 58047
AppSec [candidate] (57.264 ms) : 0, 57264
Remote Config [baseline] (633.616 µs) : 0, 634
Remote Config [candidate] (613.285 µs) : 0, 613
Telemetry [baseline] (8.907 ms) : 0, 8907
Telemetry [candidate] (8.704 ms) : 0, 8704
IAST [baseline] (23.445 ms) : 0, 23445
IAST [candidate] (22.812 ms) : 0, 22812
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (849.138 ms) : 0, 849138
BytebuddyAgent [candidate] (836.69 ms) : 0, 836690
GlobalTracer [baseline] (232.967 ms) : 0, 232967
GlobalTracer [candidate] (230.891 ms) : 0, 230891
AppSec [baseline] (57.852 ms) : 0, 57852
AppSec [candidate] (57.749 ms) : 0, 57749
Remote Config [baseline] (616.227 µs) : 0, 616
Remote Config [candidate] (616.625 µs) : 0, 617
Telemetry [baseline] (8.838 ms) : 0, 8838
Telemetry [candidate] (8.834 ms) : 0, 8834
IAST [baseline] (23.335 ms) : 0, 23335
IAST [candidate] (22.892 ms) : 0, 22892
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.673 ms) : 0, 832673
BytebuddyAgent [candidate] (836.168 ms) : 0, 836168
GlobalTracer [baseline] (231.563 ms) : 0, 231563
GlobalTracer [candidate] (231.68 ms) : 0, 231680
AppSec [baseline] (53.337 ms) : 0, 53337
AppSec [candidate] (55.033 ms) : 0, 55033
Remote Config [baseline] (617.048 µs) : 0, 617
Remote Config [candidate] (623.329 µs) : 0, 623
Telemetry [baseline] (8.654 ms) : 0, 8654
Telemetry [candidate] (8.686 ms) : 0, 8686
IAST [baseline] (26.347 ms) : 0, 26347
IAST [candidate] (24.878 ms) : 0, 24878
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section baseline
no_agent (381.814 µs) : 360, 404
. : milestone, 382,
iast (504.06 µs) : 482, 526
. : milestone, 504,
iast_FULL (724.022 µs) : 702, 746
. : milestone, 724,
iast_GLOBAL (552.265 µs) : 531, 574
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (507.579 µs) : 486, 529
. : milestone, 508,
iast_INACTIVE (467.888 µs) : 446, 489
. : milestone, 468,
iast_TELEMETRY_OFF (500.737 µs) : 477, 524
. : milestone, 501,
tracing (459.711 µs) : 438, 481
. : milestone, 460,
section candidate
no_agent (381.166 µs) : 362, 401
. : milestone, 381,
iast (513.482 µs) : 491, 536
. : milestone, 513,
iast_FULL (729.618 µs) : 707, 752
. : milestone, 730,
iast_GLOBAL (552.422 µs) : 531, 574
. : milestone, 552,
iast_HARDCODED_SECRET_DISABLED (510.163 µs) : 489, 532
. : milestone, 510,
iast_INACTIVE (465.16 µs) : 443, 487
. : milestone, 465,
iast_TELEMETRY_OFF (490.788 µs) : 469, 512
. : milestone, 491,
tracing (455.612 µs) : 435, 477
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section baseline
no_agent (1.357 ms) : 1336, 1377
. : milestone, 1357,
appsec (1.764 ms) : 1740, 1787
. : milestone, 1764,
appsec_no_iast (1.766 ms) : 1743, 1790
. : milestone, 1766,
iast (1.511 ms) : 1486, 1535
. : milestone, 1511,
profiling (1.531 ms) : 1506, 1556
. : milestone, 1531,
tracing (1.478 ms) : 1453, 1503
. : milestone, 1478,
section candidate
no_agent (1.354 ms) : 1334, 1373
. : milestone, 1354,
appsec (1.752 ms) : 1728, 1776
. : milestone, 1752,
appsec_no_iast (1.751 ms) : 1726, 1777
. : milestone, 1751,
iast (1.529 ms) : 1505, 1553
. : milestone, 1529,
profiling (1.521 ms) : 1497, 1544
. : milestone, 1521,
tracing (1.5 ms) : 1476, 1524
. : milestone, 1500,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.374 ms) : 2330, 2418
. : milestone, 2374,
iast (2.115 ms) : 2060, 2170
. : milestone, 2115,
iast_GLOBAL (2.156 ms) : 2101, 2211
. : milestone, 2156,
profiling (1.96 ms) : 1916, 2003
. : milestone, 1960,
tracing (1.959 ms) : 1917, 2001
. : milestone, 1959,
section candidate
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (2.375 ms) : 2331, 2419
. : milestone, 2375,
iast (2.11 ms) : 2054, 2165
. : milestone, 2110,
iast_GLOBAL (2.157 ms) : 2102, 2213
. : milestone, 2157,
profiling (1.963 ms) : 1919, 2007
. : milestone, 1963,
tracing (1.956 ms) : 1914, 1998
. : milestone, 1956,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~13bfe1b223, baseline=1.47.0-SNAPSHOT~0dafd10d66
dateFormat X
axisFormat %s
section baseline
no_agent (14.882 s) : 14882000, 14882000
. : milestone, 14882000,
appsec (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
iast (18.187 s) : 18187000, 18187000
. : milestone, 18187000,
iast_GLOBAL (18.245 s) : 18245000, 18245000
. : milestone, 18245000,
profiling (15.435 s) : 15435000, 15435000
. : milestone, 15435000,
tracing (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
section candidate
no_agent (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
appsec (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
iast (19.102 s) : 19102000, 19102000
. : milestone, 19102000,
iast_GLOBAL (18.068 s) : 18068000, 18068000
. : milestone, 18068000,
profiling (15.192 s) : 15192000, 15192000
. : milestone, 15192000,
tracing (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
|
mcculls
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "FIXME: temporarily ignore hostname assertions on CircleCI (#8411)
This reverts commit ebdbdd4.
Circle CI confirmed this was an issue on their side, and it should be fixed now.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]