-
Notifications
You must be signed in to change notification settings - Fork 322
Revert to OLD JDK versions to unblock CI #8421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
mcculls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - #8405 should include a revert of this change to verify the fixes work
cc @jbachorik
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046324
Total [baseline] (8.678 s) : 0, 8677962
Agent [candidate] (1.048 s) : 0, 1047548
Total [candidate] (8.67 s) : 0, 8670200
section iast
Agent [baseline] (1.168 s) : 0, 1168080
Total [baseline] (9.232 s) : 0, 9231901
Agent [candidate] (1.168 s) : 0, 1168478
Total [candidate] (9.298 s) : 0, 9297555
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1180566
Total [baseline] (9.22 s) : 0, 9219537
Agent [candidate] (1.183 s) : 0, 1183475
Total [candidate] (9.277 s) : 0, 9277236
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165620
Total [baseline] (9.254 s) : 0, 9254374
Agent [candidate] (1.166 s) : 0, 1166200
Total [candidate] (9.266 s) : 0, 9266345
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.994 ms) : 0, 720994
BytebuddyAgent [candidate] (719.965 ms) : 0, 719965
GlobalTracer [baseline] (240.98 ms) : 0, 240980
GlobalTracer [candidate] (240.953 ms) : 0, 240953
AppSec [baseline] (55.407 ms) : 0, 55407
AppSec [candidate] (55.541 ms) : 0, 55541
Remote Config [baseline] (704.076 µs) : 0, 704
Remote Config [candidate] (704.75 µs) : 0, 705
Telemetry [baseline] (12.961 ms) : 0, 12961
Telemetry [candidate] (15.127 ms) : 0, 15127
section iast
BytebuddyAgent [baseline] (833.937 ms) : 0, 833937
BytebuddyAgent [candidate] (834.295 ms) : 0, 834295
GlobalTracer [baseline] (230.02 ms) : 0, 230020
GlobalTracer [candidate] (230.144 ms) : 0, 230144
AppSec [baseline] (56.873 ms) : 0, 56873
AppSec [candidate] (56.757 ms) : 0, 56757
Remote Config [baseline] (601.889 µs) : 0, 602
Remote Config [candidate] (610.44 µs) : 0, 610
Telemetry [baseline] (8.646 ms) : 0, 8646
Telemetry [candidate] (8.699 ms) : 0, 8699
IAST [baseline] (22.767 ms) : 0, 22767
IAST [candidate] (22.702 ms) : 0, 22702
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (842.932 ms) : 0, 842932
BytebuddyAgent [candidate] (844.287 ms) : 0, 844287
GlobalTracer [baseline] (231.965 ms) : 0, 231965
GlobalTracer [candidate] (233.05 ms) : 0, 233050
AppSec [baseline] (57.558 ms) : 0, 57558
AppSec [candidate] (57.881 ms) : 0, 57881
Remote Config [baseline] (622.331 µs) : 0, 622
Remote Config [candidate] (628.606 µs) : 0, 629
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (8.879 ms) : 0, 8879
IAST [baseline] (23.165 ms) : 0, 23165
IAST [candidate] (23.324 ms) : 0, 23324
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.991 ms) : 0, 831991
BytebuddyAgent [candidate] (832.284 ms) : 0, 832284
GlobalTracer [baseline] (230.092 ms) : 0, 230092
GlobalTracer [candidate] (230.357 ms) : 0, 230357
AppSec [baseline] (53.684 ms) : 0, 53684
AppSec [candidate] (52.912 ms) : 0, 52912
Remote Config [baseline] (631.309 µs) : 0, 631
Remote Config [candidate] (614.48 µs) : 0, 614
Telemetry [baseline] (8.611 ms) : 0, 8611
Telemetry [candidate] (8.539 ms) : 0, 8539
IAST [baseline] (25.326 ms) : 0, 25326
IAST [candidate] (26.252 ms) : 0, 26252
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042344
Total [baseline] (10.473 s) : 0, 10473469
Agent [candidate] (1.04 s) : 0, 1039503
Total [candidate] (10.476 s) : 0, 10475587
section appsec
Agent [baseline] (1.182 s) : 0, 1182018
Total [baseline] (10.744 s) : 0, 10743791
Agent [candidate] (1.181 s) : 0, 1181210
Total [candidate] (10.72 s) : 0, 10720086
section iast
Agent [baseline] (1.171 s) : 0, 1170827
Total [baseline] (11.06 s) : 0, 11059549
Agent [candidate] (1.179 s) : 0, 1178682
Total [candidate] (11.001 s) : 0, 11000971
section profiling
Agent [baseline] (1.269 s) : 0, 1269427
Total [baseline] (10.902 s) : 0, 10901522
Agent [candidate] (1.26 s) : 0, 1260297
Total [candidate] (10.872 s) : 0, 10871552
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.827 ms) : 0, 720827
BytebuddyAgent [candidate] (717.114 ms) : 0, 717114
GlobalTracer [baseline] (239.464 ms) : 0, 239464
GlobalTracer [candidate] (239.353 ms) : 0, 239353
AppSec [baseline] (55.305 ms) : 0, 55305
AppSec [candidate] (55.583 ms) : 0, 55583
Remote Config [baseline] (699.607 µs) : 0, 700
Remote Config [candidate] (725.185 µs) : 0, 725
Telemetry [baseline] (10.73 ms) : 0, 10730
Telemetry [candidate] (11.502 ms) : 0, 11502
section appsec
BytebuddyAgent [baseline] (734.292 ms) : 0, 734292
BytebuddyAgent [candidate] (732.723 ms) : 0, 732723
GlobalTracer [baseline] (236.468 ms) : 0, 236468
GlobalTracer [candidate] (236.813 ms) : 0, 236813
IAST [baseline] (21.419 ms) : 0, 21419
IAST [candidate] (21.423 ms) : 0, 21423
AppSec [baseline] (176.419 ms) : 0, 176419
AppSec [candidate] (176.852 ms) : 0, 176852
Remote Config [baseline] (667.908 µs) : 0, 668
Remote Config [candidate] (661.082 µs) : 0, 661
Telemetry [baseline] (8.238 ms) : 0, 8238
Telemetry [candidate] (8.223 ms) : 0, 8223
section iast
BytebuddyAgent [baseline] (834.401 ms) : 0, 834401
BytebuddyAgent [candidate] (841.794 ms) : 0, 841794
GlobalTracer [baseline] (231.156 ms) : 0, 231156
GlobalTracer [candidate] (231.458 ms) : 0, 231458
IAST [baseline] (22.902 ms) : 0, 22902
IAST [candidate] (23.152 ms) : 0, 23152
AppSec [baseline] (57.687 ms) : 0, 57687
AppSec [candidate] (57.56 ms) : 0, 57560
Remote Config [baseline] (626.509 µs) : 0, 627
Remote Config [candidate] (617.31 µs) : 0, 617
Telemetry [baseline] (8.741 ms) : 0, 8741
Telemetry [candidate] (8.677 ms) : 0, 8677
section profiling
BytebuddyAgent [baseline] (712.587 ms) : 0, 712587
BytebuddyAgent [candidate] (706.973 ms) : 0, 706973
GlobalTracer [baseline] (351.85 ms) : 0, 351850
GlobalTracer [candidate] (350.789 ms) : 0, 350789
AppSec [baseline] (55.894 ms) : 0, 55894
AppSec [candidate] (54.593 ms) : 0, 54593
Remote Config [baseline] (681.839 µs) : 0, 682
Remote Config [candidate] (666.572 µs) : 0, 667
Telemetry [baseline] (8.977 ms) : 0, 8977
Telemetry [candidate] (8.978 ms) : 0, 8978
ProfilingAgent [baseline] (96.782 ms) : 0, 96782
ProfilingAgent [candidate] (96.039 ms) : 0, 96039
Profiling [baseline] (96.806 ms) : 0, 96806
Profiling [candidate] (96.064 ms) : 0, 96064
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section baseline
no_agent (384.784 µs) : 364, 406
. : milestone, 385,
iast (513.56 µs) : 492, 535
. : milestone, 514,
iast_FULL (734.498 µs) : 713, 756
. : milestone, 734,
iast_GLOBAL (572.331 µs) : 549, 596
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (519.06 µs) : 496, 542
. : milestone, 519,
iast_INACTIVE (464.693 µs) : 444, 486
. : milestone, 465,
iast_TELEMETRY_OFF (506.04 µs) : 483, 529
. : milestone, 506,
tracing (466.005 µs) : 445, 487
. : milestone, 466,
section candidate
no_agent (380.351 µs) : 361, 400
. : milestone, 380,
iast (513.571 µs) : 491, 536
. : milestone, 514,
iast_FULL (735.553 µs) : 713, 758
. : milestone, 736,
iast_GLOBAL (563.16 µs) : 541, 586
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (523.995 µs) : 500, 548
. : milestone, 524,
iast_INACTIVE (463.864 µs) : 443, 485
. : milestone, 464,
iast_TELEMETRY_OFF (508.176 µs) : 485, 531
. : milestone, 508,
tracing (460.089 µs) : 439, 481
. : milestone, 460,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1382
. : milestone, 1362,
appsec (1.786 ms) : 1763, 1809
. : milestone, 1786,
appsec_no_iast (1.769 ms) : 1746, 1792
. : milestone, 1769,
iast (1.522 ms) : 1497, 1546
. : milestone, 1522,
profiling (1.532 ms) : 1507, 1558
. : milestone, 1532,
tracing (1.498 ms) : 1474, 1523
. : milestone, 1498,
section candidate
no_agent (1.367 ms) : 1347, 1387
. : milestone, 1367,
appsec (1.76 ms) : 1736, 1784
. : milestone, 1760,
appsec_no_iast (1.788 ms) : 1764, 1813
. : milestone, 1788,
iast (1.521 ms) : 1496, 1545
. : milestone, 1521,
profiling (1.511 ms) : 1487, 1534
. : milestone, 1511,
tracing (1.516 ms) : 1492, 1541
. : milestone, 1516,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.36 ms) : 2317, 2404
. : milestone, 2360,
iast (2.111 ms) : 2056, 2166
. : milestone, 2111,
iast_GLOBAL (2.151 ms) : 2096, 2207
. : milestone, 2151,
profiling (2.444 ms) : 2260, 2628
. : milestone, 2444,
tracing (1.952 ms) : 1910, 1994
. : milestone, 1952,
section candidate
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.352 ms) : 2308, 2395
. : milestone, 2352,
iast (2.115 ms) : 2059, 2171
. : milestone, 2115,
iast_GLOBAL (2.157 ms) : 2102, 2213
. : milestone, 2157,
profiling (1.957 ms) : 1914, 2001
. : milestone, 1957,
tracing (1.947 ms) : 1905, 1989
. : milestone, 1947,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~02b2a0d7d1, baseline=1.47.0-SNAPSHOT~9f81c1810a
dateFormat X
axisFormat %s
section baseline
no_agent (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
appsec (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
iast (18.321 s) : 18321000, 18321000
. : milestone, 18321000,
iast_GLOBAL (18.13 s) : 18130000, 18130000
. : milestone, 18130000,
profiling (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
tracing (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
section candidate
no_agent (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
appsec (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
iast (18.317 s) : 18317000, 18317000
. : milestone, 18317000,
iast_GLOBAL (17.636 s) : 17636000, 17636000
. : milestone, 17636000,
profiling (15.283 s) : 15283000, 15283000
. : milestone, 15283000,
tracing (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
|
|
#8405 was fixed. Closing this remediation |
What Does This Do
Revert to OLD JDK versions until #8405 fixes the issue
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: LANGPLAT-320