🍒 #8191 - TempLocationManager Fixes and Improvements #8199

jbachorik · 2025-01-14T15:04:47Z

Backport #8191 to release/v1.45.x

(cherry picked from commit d0eed45)

(cherry picked from commit 58d5da8)

(cherry picked from commit a770911)

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/AdviceShader.java

github-actions · 2025-01-14T15:06:43Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

PerfectSlayer

Reporting approval

pr-commenter · 2025-01-14T15:45:15Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jaroslav.bachorik/backport-pr-8191
git_commit_date	1736864662	1736866947
git_commit_sha	`0df72c4`	`2f6f74e`
release_version	1.46.0-SNAPSHOT~0df72c42da	1.46.0-SNAPSHOT~2f6f74e2e3

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736869332	1736869332
ci_job_id	765550014	765550014
ci_pipeline_id	52943821	52943821
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 4 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:Telemetry	better [-1031.854µs; -505.652µs] or [-11.564%; -5.667%]	8.154ms	8.923ms

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063820
Total [baseline] (10.486 s) : 0, 10486023
Agent [candidate] (1.055 s) : 0, 1054930
Total [candidate] (10.542 s) : 0, 10541683
section appsec
Agent [baseline] (1.195 s) : 0, 1195448
Total [baseline] (10.801 s) : 0, 10801265
Agent [candidate] (1.19 s) : 0, 1189576
Total [candidate] (10.722 s) : 0, 10722127
section iast
Agent [baseline] (1.182 s) : 0, 1182323
Total [baseline] (10.983 s) : 0, 10982621
Agent [candidate] (1.185 s) : 0, 1185226
Total [candidate] (10.989 s) : 0, 10988999
section profiling
Agent [baseline] (1.257 s) : 0, 1256593
Total [baseline] (10.902 s) : 0, 10901924
Agent [candidate] (1.267 s) : 0, 1266634
Total [candidate] (10.823 s) : 0, 10823130

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.064 s	-
Agent	appsec	1.195 s	131.628 ms (12.4%)
Agent	iast	1.182 s	118.504 ms (11.1%)
Agent	profiling	1.257 s	192.774 ms (18.1%)
Total	tracing	10.486 s	-
Total	appsec	10.801 s	315.243 ms (3.0%)
Total	iast	10.983 s	496.598 ms (4.7%)
Total	profiling	10.902 s	415.902 ms (4.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.19 s	134.647 ms (12.8%)
Agent	iast	1.185 s	130.296 ms (12.4%)
Agent	profiling	1.267 s	211.704 ms (20.1%)
Total	tracing	10.542 s	-
Total	appsec	10.722 s	180.444 ms (1.7%)
Total	iast	10.989 s	447.316 ms (4.2%)
Total	profiling	10.823 s	281.447 ms (2.7%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.873 ms) : 0, 719873
BytebuddyAgent [candidate] (713.88 ms) : 0, 713880
GlobalTracer [baseline] (257.054 ms) : 0, 257054
GlobalTracer [candidate] (255.712 ms) : 0, 255712
AppSec [baseline] (56.069 ms) : 0, 56069
AppSec [candidate] (55.31 ms) : 0, 55310
Remote Config [baseline] (722.936 µs) : 0, 723
Remote Config [candidate] (737.728 µs) : 0, 738
Telemetry [baseline] (15.048 ms) : 0, 15048
Telemetry [candidate] (14.268 ms) : 0, 14268
section appsec
BytebuddyAgent [baseline] (736.168 ms) : 0, 736168
BytebuddyAgent [candidate] (731.411 ms) : 0, 731411
GlobalTracer [baseline] (254.106 ms) : 0, 254106
GlobalTracer [candidate] (253.364 ms) : 0, 253364
AppSec [baseline] (171.319 ms) : 0, 171319
AppSec [candidate] (171.197 ms) : 0, 171197
Remote Config [baseline] (669.705 µs) : 0, 670
Remote Config [candidate] (660.113 µs) : 0, 660
Telemetry [baseline] (8.279 ms) : 0, 8279
Telemetry [candidate] (8.279 ms) : 0, 8279
IAST [baseline] (19.439 ms) : 0, 19439
IAST [candidate] (19.306 ms) : 0, 19306
section iast
BytebuddyAgent [baseline] (831.639 ms) : 0, 831639
BytebuddyAgent [candidate] (833.265 ms) : 0, 833265
GlobalTracer [baseline] (247.004 ms) : 0, 247004
GlobalTracer [candidate] (247.798 ms) : 0, 247798
AppSec [baseline] (57.946 ms) : 0, 57946
AppSec [candidate] (58.303 ms) : 0, 58303
Remote Config [baseline] (687.8 µs) : 0, 688
Remote Config [candidate] (662.153 µs) : 0, 662
Telemetry [baseline] (8.721 ms) : 0, 8721
Telemetry [candidate] (8.774 ms) : 0, 8774
IAST [baseline] (21.309 ms) : 0, 21309
IAST [candidate] (21.367 ms) : 0, 21367
section profiling
BytebuddyAgent [baseline] (704.274 ms) : 0, 704274
BytebuddyAgent [candidate] (709.318 ms) : 0, 709318
GlobalTracer [baseline] (350.257 ms) : 0, 350257
GlobalTracer [candidate] (356.669 ms) : 0, 356669
AppSec [baseline] (54.929 ms) : 0, 54929
AppSec [candidate] (53.513 ms) : 0, 53513
Remote Config [baseline] (674.595 µs) : 0, 675
Remote Config [candidate] (666.9 µs) : 0, 667
Telemetry [baseline] (8.923 ms) : 0, 8923
Telemetry [candidate] (8.154 ms) : 0, 8154
ProfilingAgent [baseline] (95.514 ms) : 0, 95514
ProfilingAgent [candidate] (96.042 ms) : 0, 96042
Profiling [baseline] (95.538 ms) : 0, 95538
Profiling [candidate] (96.066 ms) : 0, 96066

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054072
Total [baseline] (8.617 s) : 0, 8617445
Agent [candidate] (1.066 s) : 0, 1066074
Total [candidate] (8.606 s) : 0, 8605914
section iast
Agent [baseline] (1.182 s) : 0, 1182455
Total [baseline] (9.212 s) : 0, 9211639
Agent [candidate] (1.18 s) : 0, 1180010
Total [candidate] (9.184 s) : 0, 9183502
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184670
Total [baseline] (9.184 s) : 0, 9184029
Agent [candidate] (1.191 s) : 0, 1190501
Total [candidate] (9.238 s) : 0, 9237789
section iast_TELEMETRY_OFF
Agent [baseline] (1.188 s) : 0, 1187812
Total [baseline] (9.216 s) : 0, 9215979
Agent [candidate] (1.191 s) : 0, 1191078
Total [candidate] (9.198 s) : 0, 9197562

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.054 s	-
Agent	iast	1.182 s	128.383 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.185 s	130.598 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.188 s	133.741 ms (12.7%)
Total	tracing	8.617 s	-
Total	iast	9.212 s	594.194 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.184 s	566.584 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.216 s	598.535 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.066 s	-
Agent	iast	1.18 s	113.936 ms (10.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.191 s	124.427 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.191 s	125.004 ms (11.7%)
Total	tracing	8.606 s	-
Total	iast	9.184 s	577.588 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.238 s	631.875 ms (7.3%)
Total	iast_TELEMETRY_OFF	9.198 s	591.648 ms (6.9%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.224 ms) : 0, 712224
BytebuddyAgent [candidate] (720.843 ms) : 0, 720843
GlobalTracer [baseline] (254.839 ms) : 0, 254839
GlobalTracer [candidate] (258.511 ms) : 0, 258511
AppSec [baseline] (55.733 ms) : 0, 55733
AppSec [candidate] (55.695 ms) : 0, 55695
Remote Config [baseline] (718.119 µs) : 0, 718
Remote Config [candidate] (740.935 µs) : 0, 741
Telemetry [baseline] (15.7 ms) : 0, 15700
Telemetry [candidate] (15.181 ms) : 0, 15181
section iast
BytebuddyAgent [baseline] (832.089 ms) : 0, 832089
BytebuddyAgent [candidate] (829.39 ms) : 0, 829390
GlobalTracer [baseline] (246.517 ms) : 0, 246517
GlobalTracer [candidate] (246.612 ms) : 0, 246612
AppSec [baseline] (57.765 ms) : 0, 57765
AppSec [candidate] (58.223 ms) : 0, 58223
Remote Config [baseline] (673.919 µs) : 0, 674
Remote Config [candidate] (669.695 µs) : 0, 670
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.795 ms) : 0, 8795
IAST [baseline] (21.591 ms) : 0, 21591
IAST [candidate] (21.346 ms) : 0, 21346
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (833.165 ms) : 0, 833165
BytebuddyAgent [candidate] (837.654 ms) : 0, 837654
GlobalTracer [baseline] (247.236 ms) : 0, 247236
GlobalTracer [candidate] (248.396 ms) : 0, 248396
AppSec [baseline] (58.464 ms) : 0, 58464
AppSec [candidate] (58.426 ms) : 0, 58426
Remote Config [baseline] (673.756 µs) : 0, 674
Remote Config [candidate] (669.955 µs) : 0, 670
Telemetry [baseline] (8.755 ms) : 0, 8755
Telemetry [candidate] (8.838 ms) : 0, 8838
IAST [baseline] (21.353 ms) : 0, 21353
IAST [candidate] (21.334 ms) : 0, 21334
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.919 ms) : 0, 835919
BytebuddyAgent [candidate] (839.288 ms) : 0, 839288
GlobalTracer [baseline] (248.04 ms) : 0, 248040
GlobalTracer [candidate] (248.282 ms) : 0, 248282
AppSec [baseline] (58.126 ms) : 0, 58126
AppSec [candidate] (57.945 ms) : 0, 57945
Remote Config [baseline] (684.624 µs) : 0, 685
Remote Config [candidate] (647.092 µs) : 0, 647
Telemetry [baseline] (8.749 ms) : 0, 8749
Telemetry [candidate] (8.715 ms) : 0, 8715
IAST [baseline] (21.165 ms) : 0, 21165
IAST [candidate] (20.976 ms) : 0, 20976

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-14T15:14:19	2025-01-14T15:21:21
git_branch	master	jaroslav.bachorik/backport-pr-8191
git_commit_date	1736864662	1736866947
git_commit_sha	`0df72c4`	`2f6f74e`
release_version	1.46.0-SNAPSHOT~0df72c42da	1.46.0-SNAPSHOT~2f6f74e2e3
start_time	2025-01-14T15:14:05	2025-01-14T15:21:07

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736868437	1736868437
ci_job_id	765550017	765550017
ci_pipeline_id	52943821	52943821
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da
    dateFormat X
    axisFormat %s
section baseline
no_agent (385.03 µs) : 365, 405
.   : milestone, 385,
iast (496.828 µs) : 475, 518
.   : milestone, 497,
iast_FULL (674.006 µs) : 652, 696
.   : milestone, 674,
iast_GLOBAL (534.424 µs) : 512, 557
.   : milestone, 534,
iast_HARDCODED_SECRET_DISABLED (497.582 µs) : 476, 519
.   : milestone, 498,
iast_INACTIVE (459.224 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (487.939 µs) : 466, 510
.   : milestone, 488,
tracing (455.908 µs) : 435, 477
.   : milestone, 456,
section candidate
no_agent (386.769 µs) : 365, 409
.   : milestone, 387,
iast (503.431 µs) : 482, 525
.   : milestone, 503,
iast_FULL (664.615 µs) : 643, 686
.   : milestone, 665,
iast_GLOBAL (525.207 µs) : 504, 547
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (503.362 µs) : 482, 525
.   : milestone, 503,
iast_INACTIVE (462.826 µs) : 441, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (492.968 µs) : 471, 515
.   : milestone, 493,
tracing (465.59 µs) : 444, 487
.   : milestone, 466,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	385.03 µs [364.644 µs, 405.415 µs]	-
iast	496.828 µs [475.415 µs, 518.242 µs]	111.798 µs (29.0%)
iast_FULL	674.006 µs [652.185 µs, 695.827 µs]	288.976 µs (75.1%)
iast_GLOBAL	534.424 µs [512.256 µs, 556.592 µs]	149.394 µs (38.8%)
iast_HARDCODED_SECRET_DISABLED	497.582 µs [475.877 µs, 519.286 µs]	112.552 µs (29.2%)
iast_INACTIVE	459.224 µs [438.121 µs, 480.326 µs]	74.194 µs (19.3%)
iast_TELEMETRY_OFF	487.939 µs [465.942 µs, 509.936 µs]	102.909 µs (26.7%)
tracing	455.908 µs [434.557 µs, 477.26 µs]	70.879 µs (18.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.769 µs [364.944 µs, 408.594 µs]	-
iast	503.431 µs [481.541 µs, 525.321 µs]	116.662 µs (30.2%)
iast_FULL	664.615 µs [642.864 µs, 686.366 µs]	277.846 µs (71.8%)
iast_GLOBAL	525.207 µs [503.642 µs, 546.771 µs]	138.438 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED	503.362 µs [481.577 µs, 525.146 µs]	116.593 µs (30.1%)
iast_INACTIVE	462.826 µs [441.478 µs, 484.174 µs]	76.057 µs (19.7%)
iast_TELEMETRY_OFF	492.968 µs [471.29 µs, 514.646 µs]	106.199 µs (27.5%)
tracing	465.59 µs [444.268 µs, 486.912 µs]	78.821 µs (20.4%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.36 ms) : 1341, 1379
.   : milestone, 1360,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.749 ms) : 1725, 1774
.   : milestone, 1749,
iast (1.511 ms) : 1487, 1534
.   : milestone, 1511,
profiling (1.523 ms) : 1499, 1546
.   : milestone, 1523,
tracing (1.478 ms) : 1453, 1503
.   : milestone, 1478,
section candidate
no_agent (1.364 ms) : 1344, 1383
.   : milestone, 1364,
appsec (1.753 ms) : 1729, 1777
.   : milestone, 1753,
appsec_no_iast (1.805 ms) : 1782, 1828
.   : milestone, 1805,
iast (1.498 ms) : 1474, 1521
.   : milestone, 1498,
profiling (1.54 ms) : 1517, 1563
.   : milestone, 1540,
tracing (1.499 ms) : 1475, 1523
.   : milestone, 1499,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.341 ms, 1.379 ms]	-
appsec	1.732 ms [1.708 ms, 1.756 ms]	372.073 µs (27.4%)
appsec_no_iast	1.749 ms [1.725 ms, 1.774 ms]	389.301 µs (28.6%)
iast	1.511 ms [1.487 ms, 1.534 ms]	150.641 µs (11.1%)
profiling	1.523 ms [1.499 ms, 1.546 ms]	162.677 µs (12.0%)
tracing	1.478 ms [1.453 ms, 1.503 ms]	117.938 µs (8.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.364 ms [1.344 ms, 1.383 ms]	-
appsec	1.753 ms [1.729 ms, 1.777 ms]	389.743 µs (28.6%)
appsec_no_iast	1.805 ms [1.782 ms, 1.828 ms]	441.426 µs (32.4%)
iast	1.498 ms [1.474 ms, 1.521 ms]	133.909 µs (9.8%)
profiling	1.54 ms [1.517 ms, 1.563 ms]	176.394 µs (12.9%)
tracing	1.499 ms [1.475 ms, 1.523 ms]	135.132 µs (9.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jaroslav.bachorik/backport-pr-8191
git_commit_date	1736864662	1736866947
git_commit_sha	`0df72c4`	`2f6f74e`
release_version	1.46.0-SNAPSHOT~0df72c42da	1.46.0-SNAPSHOT~2f6f74e2e3

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1736869004	1736869004
ci_job_id	765550020	765550020
ci_pipeline_id	52943821	52943821
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.279 s) : 15279000, 15279000
.   : milestone, 15279000,
appsec (15.018 s) : 15018000, 15018000
.   : milestone, 15018000,
iast (18.671 s) : 18671000, 18671000
.   : milestone, 18671000,
iast_GLOBAL (18.16 s) : 18160000, 18160000
.   : milestone, 18160000,
profiling (15.281 s) : 15281000, 15281000
.   : milestone, 15281000,
tracing (14.803 s) : 14803000, 14803000
.   : milestone, 14803000,
section candidate
no_agent (14.646 s) : 14646000, 14646000
.   : milestone, 14646000,
appsec (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
iast (18.777 s) : 18777000, 18777000
.   : milestone, 18777000,
iast_GLOBAL (18.232 s) : 18232000, 18232000
.   : milestone, 18232000,
profiling (15.15 s) : 15150000, 15150000
.   : milestone, 15150000,
tracing (14.632 s) : 14632000, 14632000
.   : milestone, 14632000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.279 s [15.279 s, 15.279 s]	-
appsec	15.018 s [15.018 s, 15.018 s]	-261.0 ms (-1.7%)
iast	18.671 s [18.671 s, 18.671 s]	3.392 s (22.2%)
iast_GLOBAL	18.16 s [18.16 s, 18.16 s]	2.881 s (18.9%)
profiling	15.281 s [15.281 s, 15.281 s]	2.0 ms (0.0%)
tracing	14.803 s [14.803 s, 14.803 s]	-476.0 ms (-3.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.646 s [14.646 s, 14.646 s]	-
appsec	14.951 s [14.951 s, 14.951 s]	305.0 ms (2.1%)
iast	18.777 s [18.777 s, 18.777 s]	4.131 s (28.2%)
iast_GLOBAL	18.232 s [18.232 s, 18.232 s]	3.586 s (24.5%)
profiling	15.15 s [15.15 s, 15.15 s]	504.0 ms (3.4%)
tracing	14.632 s [14.632 s, 14.632 s]	-14.0 ms (-0.1%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~2f6f74e2e3, baseline=1.46.0-SNAPSHOT~0df72c42da
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1476
.   : milestone, 1465,
appsec (2.354 ms) : 2311, 2397
.   : milestone, 2354,
iast (2.1 ms) : 2046, 2154
.   : milestone, 2100,
iast_GLOBAL (2.141 ms) : 2087, 2196
.   : milestone, 2141,
profiling (1.959 ms) : 1915, 2002
.   : milestone, 1959,
tracing (1.937 ms) : 1895, 1979
.   : milestone, 1937,
section candidate
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.35 ms) : 2308, 2392
.   : milestone, 2350,
iast (2.09 ms) : 2036, 2143
.   : milestone, 2090,
iast_GLOBAL (2.139 ms) : 2084, 2193
.   : milestone, 2139,
profiling (1.954 ms) : 1911, 1997
.   : milestone, 1954,
tracing (1.943 ms) : 1901, 1985
.   : milestone, 1943,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.454 ms, 1.476 ms]	-
appsec	2.354 ms [2.311 ms, 2.397 ms]	889.247 µs (60.7%)
iast	2.1 ms [2.046 ms, 2.154 ms]	635.166 µs (43.4%)
iast_GLOBAL	2.141 ms [2.087 ms, 2.196 ms]	676.458 µs (46.2%)
profiling	1.959 ms [1.915 ms, 2.002 ms]	493.907 µs (33.7%)
tracing	1.937 ms [1.895 ms, 1.979 ms]	472.204 µs (32.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.35 ms [2.308 ms, 2.392 ms]	880.963 µs (60.0%)
iast	2.09 ms [2.036 ms, 2.143 ms]	620.71 µs (42.3%)
iast_GLOBAL	2.139 ms [2.084 ms, 2.193 ms]	669.666 µs (45.6%)
profiling	1.954 ms [1.911 ms, 1.997 ms]	484.855 µs (33.0%)
tracing	1.943 ms [1.901 ms, 1.985 ms]	474.11 µs (32.3%)

jbachorik added 3 commits January 14, 2025 16:02

Remove CompletableFuture from TempLocationManager

02d8d51

(cherry picked from commit d0eed45)

Do not run the cleanup if there is nothing to clean up

6e98a97

(cherry picked from commit 58d5da8)

Exclude JFR repository from temp files self-cleanup

2f6f74e

(cherry picked from commit a770911)

jbachorik requested review from a team as code owners January 14, 2025 15:04

jbachorik requested review from dougqh and nikita-tkachenko-datadog January 14, 2025 15:04

jbachorik marked this pull request as draft January 14, 2025 15:05

datadog-datadog-prod-us1 bot reviewed Jan 14, 2025

View reviewed changes

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/AdviceShader.java Show resolved Hide resolved

jbachorik changed the base branch from master to release/v1.45.x January 14, 2025 15:08

jbachorik added type: bug Bug report and fix comp: profiling Profiling labels Jan 14, 2025

jbachorik marked this pull request as ready for review January 14, 2025 15:09

mcculls approved these changes Jan 14, 2025

View reviewed changes

MattAlp approved these changes Jan 14, 2025

View reviewed changes

PerfectSlayer approved these changes Jan 14, 2025

View reviewed changes

PerfectSlayer changed the title ~~🍒 8191 TempLocationManager Fixes and Improvements~~ 🍒 #8191 - TempLocationManager Fixes and Improvements Jan 14, 2025

mcculls added this to the 1.45.1 milestone Jan 14, 2025

MattAlp merged commit ec1744f into release/v1.45.x Jan 14, 2025
156 of 157 checks passed

MattAlp deleted the jaroslav.bachorik/backport-pr-8191 branch January 14, 2025 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🍒 #8191 - TempLocationManager Fixes and Improvements #8199

🍒 #8191 - TempLocationManager Fixes and Improvements #8199

Uh oh!

jbachorik commented Jan 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2025

Uh oh!

PerfectSlayer left a comment

Uh oh!

pr-commenter bot commented Jan 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

🍒 #8191 - TempLocationManager Fixes and Improvements #8199

🍒 #8191 - TempLocationManager Fixes and Improvements #8199

Uh oh!

Conversation

jbachorik commented Jan 14, 2025

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2025

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter bot commented Jan 14, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants