Skip to content

🍒 #8192 - Ensure shaded helpers have unique names when injected into class-loaders #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcculls merged 2 commits into from
Jan 14, 2025
Merged

🍒 #8192 - Ensure shaded helpers have unique names when injected into class-loaders #8193

mcculls merged 2 commits into from
Jan 14, 2025
+120 −64

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Jan 14, 2025

Backport #8192 to release/v1.45.x

@mcculls mcculls requested a review from a team as a code owner January 14, 2025 09:05
@mcculls mcculls added type: bug Bug report and fix comp: tooling Build & Tooling labels Jan 14, 2025
@mcculls mcculls requested a review from ygree January 14, 2025 09:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Remove the tag from the pull request title

If you need help, please check our contributing guidelines.

@mcculls mcculls requested a review from amarziali January 14, 2025 09:05
@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master stuart.mcculloch/backport-pr-8192
git_commit_date 1736835932 1736845495
git_commit_sha 866fc61 e431c35
release_version 1.46.0-SNAPSHOT~866fc61571 1.46.0-SNAPSHOT~e431c3536c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736847867 1736847867
ci_job_id 765046005 765046005
ci_pipeline_id 52907513 52907513
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 4 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:Remote Config better
[-50.931µs; -16.522µs] or [-7.326%; -2.377%]		 661.502µs 695.229µs
scenario:startup:petclinic:profiling:Telemetry better
[-907.217µs; -559.642µs] or [-10.231%; -6.311%]		 8.134ms 8.867ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058876
Total [baseline] (10.523 s) : 0, 10522729
Agent [candidate] (1.054 s) : 0, 1054199
Total [candidate] (10.446 s) : 0, 10446045
section appsec
Agent [baseline] (1.195 s) : 0, 1194542
Total [baseline] (10.714 s) : 0, 10714403
Agent [candidate] (1.186 s) : 0, 1186466
Total [candidate] (10.684 s) : 0, 10683916
section iast
Agent [baseline] (1.181 s) : 0, 1181078
Total [baseline] (10.977 s) : 0, 10976651
Agent [candidate] (1.191 s) : 0, 1190988
Total [candidate] (11.016 s) : 0, 11015945
section profiling
Agent [baseline] (1.272 s) : 0, 1272062
Total [baseline] (10.868 s) : 0, 10868337
Agent [candidate] (1.282 s) : 0, 1281752
Total [candidate] (10.863 s) : 0, 10862789
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.195 s 135.666 ms (12.8%)
Agent iast 1.181 s 122.202 ms (11.5%)
Agent profiling 1.272 s 213.186 ms (20.1%)
Total tracing 10.523 s -
Total appsec 10.714 s 191.674 ms (1.8%)
Total iast 10.977 s 453.922 ms (4.3%)
Total profiling 10.868 s 345.608 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.186 s 132.267 ms (12.5%)
Agent iast 1.191 s 136.789 ms (13.0%)
Agent profiling 1.282 s 227.553 ms (21.6%)
Total tracing 10.446 s -
Total appsec 10.684 s 237.871 ms (2.3%)
Total iast 11.016 s 569.9 ms (5.5%)
Total profiling 10.863 s 416.744 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.448 ms) : 0, 716448
BytebuddyAgent [candidate] (713.249 ms) : 0, 713249
GlobalTracer [baseline] (257.076 ms) : 0, 257076
GlobalTracer [candidate] (256.2 ms) : 0, 256200
AppSec [baseline] (55.426 ms) : 0, 55426
AppSec [candidate] (55.434 ms) : 0, 55434
Remote Config [baseline] (735.49 µs) : 0, 735
Remote Config [candidate] (737.081 µs) : 0, 737
Telemetry [baseline] (14.296 ms) : 0, 14296
Telemetry [candidate] (13.582 ms) : 0, 13582
section appsec
BytebuddyAgent [baseline] (734.966 ms) : 0, 734966
BytebuddyAgent [candidate] (729.979 ms) : 0, 729979
GlobalTracer [baseline] (254.094 ms) : 0, 254094
GlobalTracer [candidate] (252.612 ms) : 0, 252612
AppSec [baseline] (171.715 ms) : 0, 171715
AppSec [candidate] (170.024 ms) : 0, 170024
IAST [baseline] (19.492 ms) : 0, 19492
IAST [candidate] (19.259 ms) : 0, 19259
Remote Config [baseline] (669.067 µs) : 0, 669
Remote Config [candidate] (652.322 µs) : 0, 652
Telemetry [baseline] (8.323 ms) : 0, 8323
Telemetry [candidate] (8.542 ms) : 0, 8542
section iast
BytebuddyAgent [baseline] (830.719 ms) : 0, 830719
BytebuddyAgent [candidate] (837.975 ms) : 0, 837975
GlobalTracer [baseline] (246.503 ms) : 0, 246503
GlobalTracer [candidate] (248.185 ms) : 0, 248185
AppSec [baseline] (58.022 ms) : 0, 58022
AppSec [candidate] (58.312 ms) : 0, 58312
IAST [baseline] (21.489 ms) : 0, 21489
IAST [candidate] (21.602 ms) : 0, 21602
Remote Config [baseline] (677.029 µs) : 0, 677
Remote Config [candidate] (685.358 µs) : 0, 685
Telemetry [baseline] (8.696 ms) : 0, 8696
Telemetry [candidate] (8.943 ms) : 0, 8943
section profiling
BytebuddyAgent [baseline] (702.01 ms) : 0, 702010
BytebuddyAgent [candidate] (707.82 ms) : 0, 707820
GlobalTracer [baseline] (368.179 ms) : 0, 368179
GlobalTracer [candidate] (372.901 ms) : 0, 372901
AppSec [baseline] (54.848 ms) : 0, 54848
AppSec [candidate] (54.056 ms) : 0, 54056
Remote Config [baseline] (695.229 µs) : 0, 695
Remote Config [candidate] (661.502 µs) : 0, 662
Telemetry [baseline] (8.867 ms) : 0, 8867
Telemetry [candidate] (8.134 ms) : 0, 8134
ProfilingAgent [baseline] (95.561 ms) : 0, 95561
ProfilingAgent [candidate] (96.012 ms) : 0, 96012
Profiling [baseline] (95.586 ms) : 0, 95586
Profiling [candidate] (96.035 ms) : 0, 96035
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1058085
Total [baseline] (8.625 s) : 0, 8624687
Agent [candidate] (1.055 s) : 0, 1055192
Total [candidate] (8.624 s) : 0, 8623991
section iast
Agent [baseline] (1.18 s) : 0, 1180053
Total [baseline] (9.209 s) : 0, 9208632
Agent [candidate] (1.183 s) : 0, 1183164
Total [candidate] (9.202 s) : 0, 9201948
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.188 s) : 0, 1188343
Total [baseline] (9.203 s) : 0, 9203234
Agent [candidate] (1.191 s) : 0, 1191399
Total [candidate] (9.25 s) : 0, 9249524
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1174336
Total [baseline] (9.183 s) : 0, 9183453
Agent [candidate] (1.175 s) : 0, 1175230
Total [candidate] (9.211 s) : 0, 9211287
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.18 s 121.968 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.188 s 130.259 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.174 s 116.252 ms (11.0%)
Total tracing 8.625 s -
Total iast 9.209 s 583.945 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.203 s 578.547 ms (6.7%)
Total iast_TELEMETRY_OFF 9.183 s 558.766 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.183 s 127.972 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 136.206 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.175 s 120.038 ms (11.4%)
Total tracing 8.624 s -
Total iast 9.202 s 577.957 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.25 s 625.533 ms (7.3%)
Total iast_TELEMETRY_OFF 9.211 s 587.297 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.476 ms) : 0, 717476
BytebuddyAgent [candidate] (712.7 ms) : 0, 712700
GlobalTracer [baseline] (255.598 ms) : 0, 255598
GlobalTracer [candidate] (255.537 ms) : 0, 255537
AppSec [baseline] (55.35 ms) : 0, 55350
AppSec [candidate] (55.949 ms) : 0, 55949
Remote Config [baseline] (724.633 µs) : 0, 725
Remote Config [candidate] (718.804 µs) : 0, 719
Telemetry [baseline] (13.894 ms) : 0, 13894
Telemetry [candidate] (15.281 ms) : 0, 15281
section iast
BytebuddyAgent [baseline] (829.798 ms) : 0, 829798
BytebuddyAgent [candidate] (831.778 ms) : 0, 831778
GlobalTracer [baseline] (246.177 ms) : 0, 246177
GlobalTracer [candidate] (246.999 ms) : 0, 246999
AppSec [baseline] (58.254 ms) : 0, 58254
AppSec [candidate] (58.49 ms) : 0, 58490
Remote Config [baseline] (677.285 µs) : 0, 677
Remote Config [candidate] (673.153 µs) : 0, 673
Telemetry [baseline] (8.754 ms) : 0, 8754
Telemetry [candidate] (8.768 ms) : 0, 8768
IAST [baseline] (21.464 ms) : 0, 21464
IAST [candidate] (21.477 ms) : 0, 21477
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.728 ms) : 0, 835728
BytebuddyAgent [candidate] (836.508 ms) : 0, 836508
GlobalTracer [baseline] (247.622 ms) : 0, 247622
GlobalTracer [candidate] (249.535 ms) : 0, 249535
AppSec [baseline] (58.663 ms) : 0, 58663
AppSec [candidate] (58.828 ms) : 0, 58828
Remote Config [baseline] (682.801 µs) : 0, 683
Remote Config [candidate] (674.657 µs) : 0, 675
Telemetry [baseline] (8.874 ms) : 0, 8874
Telemetry [candidate] (8.975 ms) : 0, 8975
IAST [baseline] (21.715 ms) : 0, 21715
IAST [candidate] (21.77 ms) : 0, 21770
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (825.935 ms) : 0, 825935
BytebuddyAgent [candidate] (826.505 ms) : 0, 826505
GlobalTracer [baseline] (245.951 ms) : 0, 245951
GlobalTracer [candidate] (246.308 ms) : 0, 246308
AppSec [baseline] (57.584 ms) : 0, 57584
AppSec [candidate] (57.399 ms) : 0, 57399
Remote Config [baseline] (641.914 µs) : 0, 642
Remote Config [candidate] (644.3 µs) : 0, 644
Telemetry [baseline] (8.599 ms) : 0, 8599
Telemetry [candidate] (8.6 ms) : 0, 8600
IAST [baseline] (20.671 ms) : 0, 20671
IAST [candidate] (20.746 ms) : 0, 20746
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-14T09:14:46 2025-01-14T09:21:44
git_branch master stuart.mcculloch/backport-pr-8192
git_commit_date 1736835932 1736845495
git_commit_sha 866fc61 e431c35
release_version 1.46.0-SNAPSHOT~866fc61571 1.46.0-SNAPSHOT~e431c3536c
start_time 2025-01-14T09:14:33 2025-01-14T09:21:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736846856 1736846856
ci_job_id 765046006 765046006
ci_pipeline_id 52907513 52907513
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.185 µs) : 355, 394
.   : milestone, 374,
iast (490.445 µs) : 469, 512
.   : milestone, 490,
iast_FULL (653.173 µs) : 632, 675
.   : milestone, 653,
iast_GLOBAL (524.024 µs) : 502, 546
.   : milestone, 524,
iast_HARDCODED_SECRET_DISABLED (491.939 µs) : 470, 513
.   : milestone, 492,
iast_INACTIVE (458.48 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (478.289 µs) : 457, 500
.   : milestone, 478,
tracing (453.835 µs) : 432, 476
.   : milestone, 454,
section candidate
no_agent (367.05 µs) : 347, 388
.   : milestone, 367,
iast (492.737 µs) : 471, 515
.   : milestone, 493,
iast_FULL (651.388 µs) : 630, 673
.   : milestone, 651,
iast_GLOBAL (521.178 µs) : 499, 543
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (494.118 µs) : 473, 516
.   : milestone, 494,
iast_INACTIVE (458.566 µs) : 436, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (473.928 µs) : 453, 495
.   : milestone, 474,
tracing (447.8 µs) : 427, 468
.   : milestone, 448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.185 µs [354.605 µs, 393.765 µs] -
iast 490.445 µs [468.941 µs, 511.948 µs] 116.26 µs (31.1%)
iast_FULL 653.173 µs [631.509 µs, 674.837 µs] 278.988 µs (74.6%)
iast_GLOBAL 524.024 µs [502.154 µs, 545.895 µs] 149.839 µs (40.0%)
iast_HARDCODED_SECRET_DISABLED 491.939 µs [470.499 µs, 513.379 µs] 117.754 µs (31.5%)
iast_INACTIVE 458.48 µs [437.168 µs, 479.792 µs] 84.295 µs (22.5%)
iast_TELEMETRY_OFF 478.289 µs [456.87 µs, 499.709 µs] 104.104 µs (27.8%)
tracing 453.835 µs [432.129 µs, 475.54 µs] 79.65 µs (21.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.05 µs [346.551 µs, 387.548 µs] -
iast 492.737 µs [470.838 µs, 514.636 µs] 125.687 µs (34.2%)
iast_FULL 651.388 µs [629.743 µs, 673.033 µs] 284.338 µs (77.5%)
iast_GLOBAL 521.178 µs [498.984 µs, 543.372 µs] 154.128 µs (42.0%)
iast_HARDCODED_SECRET_DISABLED 494.118 µs [472.684 µs, 515.552 µs] 127.068 µs (34.6%)
iast_INACTIVE 458.566 µs [436.237 µs, 480.896 µs] 91.516 µs (24.9%)
iast_TELEMETRY_OFF 473.928 µs [452.689 µs, 495.166 µs] 106.878 µs (29.1%)
tracing 447.8 µs [427.106 µs, 468.494 µs] 80.75 µs (22.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1328, 1370
.   : milestone, 1349,
appsec (1.756 ms) : 1733, 1778
.   : milestone, 1756,
appsec_no_iast (1.77 ms) : 1745, 1795
.   : milestone, 1770,
iast (1.495 ms) : 1471, 1518
.   : milestone, 1495,
profiling (1.521 ms) : 1496, 1546
.   : milestone, 1521,
tracing (1.484 ms) : 1459, 1508
.   : milestone, 1484,
section candidate
no_agent (1.365 ms) : 1346, 1385
.   : milestone, 1365,
appsec (1.744 ms) : 1721, 1768
.   : milestone, 1744,
appsec_no_iast (1.755 ms) : 1730, 1780
.   : milestone, 1755,
iast (1.491 ms) : 1468, 1514
.   : milestone, 1491,
profiling (1.505 ms) : 1480, 1530
.   : milestone, 1505,
tracing (1.464 ms) : 1438, 1489
.   : milestone, 1464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.328 ms, 1.37 ms] -
appsec 1.756 ms [1.733 ms, 1.778 ms] 406.5 µs (30.1%)
appsec_no_iast 1.77 ms [1.745 ms, 1.795 ms] 421.025 µs (31.2%)
iast 1.495 ms [1.471 ms, 1.518 ms] 145.62 µs (10.8%)
profiling 1.521 ms [1.496 ms, 1.546 ms] 171.803 µs (12.7%)
tracing 1.484 ms [1.459 ms, 1.508 ms] 134.626 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.385 ms] -
appsec 1.744 ms [1.721 ms, 1.768 ms] 379.173 µs (27.8%)
appsec_no_iast 1.755 ms [1.73 ms, 1.78 ms] 389.604 µs (28.5%)
iast 1.491 ms [1.468 ms, 1.514 ms] 125.845 µs (9.2%)
profiling 1.505 ms [1.48 ms, 1.53 ms] 139.358 µs (10.2%)
tracing 1.464 ms [1.438 ms, 1.489 ms] 98.288 µs (7.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master stuart.mcculloch/backport-pr-8192
git_commit_date 1736835932 1736845495
git_commit_sha 866fc61 e431c35
release_version 1.46.0-SNAPSHOT~866fc61571 1.46.0-SNAPSHOT~e431c3536c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736847399 1736847399
ci_job_id 765046007 765046007
ci_pipeline_id 52907513 52907513
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1487
.   : milestone, 1475,
appsec (2.367 ms) : 2325, 2410
.   : milestone, 2367,
iast (2.104 ms) : 2049, 2159
.   : milestone, 2104,
iast_GLOBAL (2.166 ms) : 2111, 2222
.   : milestone, 2166,
profiling (2.446 ms) : 2263, 2628
.   : milestone, 2446,
tracing (1.941 ms) : 1899, 1982
.   : milestone, 1941,
section candidate
no_agent (1.479 ms) : 1467, 1491
.   : milestone, 1479,
appsec (2.366 ms) : 2323, 2409
.   : milestone, 2366,
iast (2.109 ms) : 2054, 2164
.   : milestone, 2109,
iast_GLOBAL (2.152 ms) : 2097, 2207
.   : milestone, 2152,
profiling (1.978 ms) : 1934, 2022
.   : milestone, 1978,
tracing (1.95 ms) : 1908, 1992
.   : milestone, 1950,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.487 ms] -
appsec 2.367 ms [2.325 ms, 2.41 ms] 892.613 µs (60.5%)
iast 2.104 ms [2.049 ms, 2.159 ms] 629.14 µs (42.7%)
iast_GLOBAL 2.166 ms [2.111 ms, 2.222 ms] 691.395 µs (46.9%)
profiling 2.446 ms [2.263 ms, 2.628 ms] 970.952 µs (65.8%)
tracing 1.941 ms [1.899 ms, 1.982 ms] 465.701 µs (31.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.467 ms, 1.491 ms] -
appsec 2.366 ms [2.323 ms, 2.409 ms] 886.893 µs (60.0%)
iast 2.109 ms [2.054 ms, 2.164 ms] 629.994 µs (42.6%)
iast_GLOBAL 2.152 ms [2.097 ms, 2.207 ms] 673.1 µs (45.5%)
profiling 1.978 ms [1.934 ms, 2.022 ms] 498.929 µs (33.7%)
tracing 1.95 ms [1.908 ms, 1.992 ms] 471.33 µs (31.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~e431c3536c, baseline=1.46.0-SNAPSHOT~866fc61571
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.706 s) : 14706000, 14706000
.   : milestone, 14706000,
appsec (15.151 s) : 15151000, 15151000
.   : milestone, 15151000,
iast (18.952 s) : 18952000, 18952000
.   : milestone, 18952000,
iast_GLOBAL (18.141 s) : 18141000, 18141000
.   : milestone, 18141000,
profiling (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
tracing (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
section candidate
no_agent (15.425 s) : 15425000, 15425000
.   : milestone, 15425000,
appsec (15.165 s) : 15165000, 15165000
.   : milestone, 15165000,
iast (19.035 s) : 19035000, 19035000
.   : milestone, 19035000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
.   : milestone, 18038000,
profiling (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
tracing (14.842 s) : 14842000, 14842000
.   : milestone, 14842000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.706 s [14.706 s, 14.706 s] -
appsec 15.151 s [15.151 s, 15.151 s] 445.0 ms (3.0%)
iast 18.952 s [18.952 s, 18.952 s] 4.246 s (28.9%)
iast_GLOBAL 18.141 s [18.141 s, 18.141 s] 3.435 s (23.4%)
profiling 15.175 s [15.175 s, 15.175 s] 469.0 ms (3.2%)
tracing 14.988 s [14.988 s, 14.988 s] 282.0 ms (1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.425 s [15.425 s, 15.425 s] -
appsec 15.165 s [15.165 s, 15.165 s] -260.0 ms (-1.7%)
iast 19.035 s [19.035 s, 19.035 s] 3.61 s (23.4%)
iast_GLOBAL 18.038 s [18.038 s, 18.038 s] 2.613 s (16.9%)
profiling 15.284 s [15.284 s, 15.284 s] -141.0 ms (-0.9%)
tracing 14.842 s [14.842 s, 14.842 s] -583.0 ms (-3.8%)

@mcculls mcculls changed the title [🍒 8192] Ensure shaded helpers have unique names when injected into class-loaders Ensure shaded helpers have unique names when injected into class-loaders Jan 14, 2025
@mcculls mcculls merged commit 51b4d94 into release/v1.45.x Jan 14, 2025
149 of 151 checks passed
@mcculls mcculls deleted the stuart.mcculloch/backport-pr-8192 branch January 14, 2025 09:51
@github-actions github-actions bot added this to the 1.45.1 milestone Jan 14, 2025
@mcculls mcculls changed the title Ensure shaded helpers have unique names when injected into class-loaders 🍒 #8192 - Ensure shaded helpers have unique names when injected into class-loaders Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@amarziali amarziali amarziali approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling type: bug Bug report and fix

Projects

None yet

Milestone

1.45.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @amarziali