-
Notifications
You must be signed in to change notification settings - Fork 322
Fix tests related to IAST source values #6700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/iast-fix-source-values-tests
Feb 19, 2024
Merged
Fix tests related to IAST source values #6700
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/iast-fix-source-values-tests
Feb 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Feb 19, 2024
smola
approved these changes
Feb 19, 2024
ac4cb05 to
8a34f7a
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8a34f7a9fa, baseline=1.31.0-SNAPSHOT~79327cd5f2
dateFormat X
axisFormat %s
section baseline
no_agent (374.547 µs) : 354, 395
. : milestone, 375,
iast (479.06 µs) : 458, 500
. : milestone, 479,
iast_FULL (542.131 µs) : 521, 563
. : milestone, 542,
iast_GLOBAL (489.521 µs) : 469, 510
. : milestone, 490,
iast_HARDCODED_SECRET_DISABLED (475.926 µs) : 456, 496
. : milestone, 476,
iast_INACTIVE (453.166 µs) : 433, 474
. : milestone, 453,
iast_TELEMETRY_OFF (472.505 µs) : 452, 493
. : milestone, 473,
tracing (445.043 µs) : 425, 465
. : milestone, 445,
section candidate
no_agent (369.036 µs) : 349, 389
. : milestone, 369,
iast (478.951 µs) : 458, 500
. : milestone, 479,
iast_FULL (537.164 µs) : 517, 558
. : milestone, 537,
iast_GLOBAL (508.572 µs) : 487, 530
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (474.626 µs) : 454, 495
. : milestone, 475,
iast_INACTIVE (463.045 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (468.581 µs) : 448, 489
. : milestone, 469,
tracing (446.878 µs) : 426, 467
. : milestone, 447,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~8a34f7a9fa, baseline=1.31.0-SNAPSHOT~79327cd5f2
dateFormat X
axisFormat %s
section baseline
no_agent (1.366 ms) : 1347, 1385
. : milestone, 1366,
appsec (1.803 ms) : 1779, 1827
. : milestone, 1803,
iast (1.537 ms) : 1514, 1560
. : milestone, 1537,
profiling (1.525 ms) : 1500, 1549
. : milestone, 1525,
tracing (1.488 ms) : 1464, 1512
. : milestone, 1488,
section candidate
no_agent (1.36 ms) : 1341, 1379
. : milestone, 1360,
appsec (1.752 ms) : 1728, 1775
. : milestone, 1752,
iast (1.521 ms) : 1498, 1544
. : milestone, 1521,
profiling (1.516 ms) : 1492, 1541
. : milestone, 1516,
tracing (1.512 ms) : 1489, 1535
. : milestone, 1512,
|
8a34f7a to
c551545
Compare
jandro996
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm iast
Application Security Management (IAST)
tag: flaky test
Flaky tests
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes source values related tests, IAST now is capable to attach source values when the source is coming from an object. This PR fixes the tests that #6675 broke.