Add priorities for server set errors #5359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 20 cases.
|
amarziali
force-pushed
the
andrea.marziali/error-prios
branch
2 times, most recently
from
d0ea4a1 to
d4961bc
Compare
amarziali
force-pushed
the
andrea.marziali/error-prios
branch
from
d4961bc to
74661c4
Compare
ygree
reviewed
Jun 12, 2023
| } | ||
|
|
||
| @Override | ||
| public AgentSpan onError(final AgentSpan span, final Throwable throwable) { |
Contributor
There was a problem hiding this comment.
I can't see any usages of this method
Contributor
Author
There was a problem hiding this comment.
it's used by Subclasses (e.g. datadog.trace.instrumentation.tomcat.TomcatDecorator#onResponse calls onError).
Being overridded now http server based decorators are inheriting this behavior
ygree
approved these changes
Jun 12, 2023
Contributor
ygree
left a comment
ygree
left a comment
There was a problem hiding this comment.
LGTM except for onError method that I can't find any usages for.
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Similarly to resource names, it adds priority based error flag settings.
The http servers will set error using a lower priority than the user one. The errors set elsewhere will stay untouched (but it should be changed in the future as well).
It solves a particular two use cases:
Motivation
Additional Notes