Make embedded git.properties have lower priority than other git metadata sources #5160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
nikita-tkachenko-datadog
force-pushed
the
nikita-tkachenko/git-info-providers-priority-fix
branch
from
823864d to
2bbf77c
Compare
smola
approved these changes
May 9, 2023
smola
approved these changes
May 9, 2023
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/git-info-providers-priority-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
There is a component in the tracer that fetches git metadata associated with the traced code.
The component has a few sources that it uses to obtain the data:
git.propertiesfile available on the classpath (injected either manually or by a Maven/Gradle plugin).gitfolder that is available locallyThe sources are listed in order of priority.
The last two sources are only available if CI Visibility subsystem is enabled in the tracer.
This PR changes the relative priorities of git metadata sources, making
git.propertiesthe least preferable one.Motivation
git.propertiesis the least reliable of the sources, as we have no way of ensuring that the file located on the classpath resides in the JAR that we want to trace, and not in some 3rd party dependency.We want to try other more reliable sources before resorting to this one.
Additional Notes
Embedded git metadata extraction was added in scope of PR 4951