Fix for PlayFramework split routing #4991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
reviewed
Mar 29, 2023
| } | ||
| if (i < path.length() && path.charAt(i) != '/' && rawPath.charAt(i) == '/') { | ||
| path = path.substring(0, i) + '/' + path.substring(i); | ||
| } |
Contributor
There was a problem hiding this comment.
This whole logic seems very costly. Is the result cached in some way?
Contributor
Author
There was a problem hiding this comment.
Good point! I'll add a cache to this logic.
ygree
force-pushed
the
ygree/play-split-routing-fix
branch
from
69b692e to
f30a018
Compare
ygree
force-pushed
the
ygree/play-split-routing-fix
branch
from
1ff1d65 to
d1bbb63
Compare
ygree
force-pushed
the
ygree/play-split-routing-fix
branch
from
d1bbb63 to
cb7af5f
Compare
bantonsson
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This is a workaround to add a
/if it is missing when using split routesPlayFramework routes compiler
generates play.api.routing.HandlerDef.pathwithout a/. https://github.com/playframework/playframework/blob/main/dev-mode/routes-compiler/src/main/twirl/play/routes/compiler/inject/forwardsRouter.scala.twirl#L70Motivation
Resolves #4806
Additional Notes