Add GraphQL async-fetcher test #4132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygree
force-pushed
the
ygree/graphql-async-test
branch
from
ad98567 to
5653463
Compare
Contributor
Author
|
Closing this in favor of #4896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This reproduces the issue when an async fetcher is in use. The span is not marked as errored.
This PR also includes CompletableFuture tests showing that this issue is not GraphQL specific but applicable to any failing CompletableFuture.
Additionally it demonstrates an adhoc workaround for GraphQL instrumentation only that allows to capture and log error into the span.
Motivation
Additional Notes
Ref: #4051