-
Notifications
You must be signed in to change notification settings - Fork 323
fix Capture Expressions for line probes #10303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Captures were not added if captureSnapshot=false. using isFullSnapshot method to determine if we adding them or not
038abc3 to
d54dd6b
Compare
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (317.343 µs) : 283, 351
. : milestone, 317,
basic (278.163 µs) : 271, 285
. : milestone, 278,
loop (8.966 ms) : 8961, 8971
. : milestone, 8966,
section candidate
noprobe (332.874 µs) : 267, 399
. : milestone, 333,
basic (274.854 µs) : 267, 282
. : milestone, 275,
loop (8.957 ms) : 8951, 8962
. : milestone, 8957,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096147
Total [baseline] (8.788 s) : 0, 8788080
Agent [candidate] (1.091 s) : 0, 1090546
Total [candidate] (8.742 s) : 0, 8741502
section iast
Agent [baseline] (1.219 s) : 0, 1219055
Total [baseline] (9.289 s) : 0, 9289145
Agent [candidate] (1.232 s) : 0, 1231732
Total [candidate] (9.377 s) : 0, 9376732
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.21 ms) : 0, 1210
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (658.946 ms) : 0, 658946
BytebuddyAgent [candidate] (654.894 ms) : 0, 654894
GlobalTracer [baseline] (285.281 ms) : 0, 285281
GlobalTracer [candidate] (284.551 ms) : 0, 284551
AppSec [baseline] (33.308 ms) : 0, 33308
AppSec [candidate] (32.979 ms) : 0, 32979
Debugger [baseline] (68.047 ms) : 0, 68047
Debugger [candidate] (67.999 ms) : 0, 67999
Remote Config [baseline] (622.878 µs) : 0, 623
Remote Config [candidate] (637.25 µs) : 0, 637
Telemetry [baseline] (9.126 ms) : 0, 9126
Telemetry [candidate] (8.901 ms) : 0, 8901
Flare Poller [baseline] (3.855 ms) : 0, 3855
Flare Poller [candidate] (3.752 ms) : 0, 3752
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (788.755 ms) : 0, 788755
BytebuddyAgent [candidate] (797.656 ms) : 0, 797656
GlobalTracer [baseline] (255.271 ms) : 0, 255271
GlobalTracer [candidate] (257.703 ms) : 0, 257703
AppSec [baseline] (33.482 ms) : 0, 33482
AppSec [candidate] (31.893 ms) : 0, 31893
Debugger [baseline] (65.462 ms) : 0, 65462
Debugger [candidate] (67.892 ms) : 0, 67892
Remote Config [baseline] (601.274 µs) : 0, 601
Remote Config [candidate] (604.51 µs) : 0, 605
Telemetry [baseline] (8.329 ms) : 0, 8329
Telemetry [candidate] (8.424 ms) : 0, 8424
Flare Poller [baseline] (3.548 ms) : 0, 3548
Flare Poller [candidate] (3.554 ms) : 0, 3554
IAST [baseline] (27.059 ms) : 0, 27059
IAST [candidate] (27.326 ms) : 0, 27326
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089782
Total [baseline] (10.77 s) : 0, 10769640
Agent [candidate] (1.086 s) : 0, 1086124
Total [candidate] (10.819 s) : 0, 10819381
section appsec
Agent [baseline] (1.267 s) : 0, 1266782
Total [baseline] (10.949 s) : 0, 10948860
Agent [candidate] (1.264 s) : 0, 1264150
Total [candidate] (10.895 s) : 0, 10895475
section iast
Agent [baseline] (1.225 s) : 0, 1224645
Total [baseline] (11.233 s) : 0, 11233086
Agent [candidate] (1.228 s) : 0, 1228143
Total [candidate] (11.111 s) : 0, 11110995
section profiling
Agent [baseline] (1.21 s) : 0, 1209625
Total [baseline] (10.947 s) : 0, 10947020
Agent [candidate] (1.201 s) : 0, 1201367
Total [candidate] (10.893 s) : 0, 10892525
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (654.112 ms) : 0, 654112
BytebuddyAgent [candidate] (651.691 ms) : 0, 651691
GlobalTracer [baseline] (283.761 ms) : 0, 283761
GlobalTracer [candidate] (283.112 ms) : 0, 283112
AppSec [baseline] (32.798 ms) : 0, 32798
AppSec [candidate] (32.687 ms) : 0, 32687
Debugger [baseline] (68.983 ms) : 0, 68983
Debugger [candidate] (68.281 ms) : 0, 68281
Remote Config [baseline] (609.142 µs) : 0, 609
Remote Config [candidate] (648.144 µs) : 0, 648
Telemetry [baseline] (8.935 ms) : 0, 8935
Telemetry [candidate] (9.148 ms) : 0, 9148
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.82 ms) : 0, 3820
section appsec
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (691.595 ms) : 0, 691595
BytebuddyAgent [candidate] (690.009 ms) : 0, 690009
GlobalTracer [baseline] (258.395 ms) : 0, 258395
GlobalTracer [candidate] (257.835 ms) : 0, 257835
IAST [baseline] (24.533 ms) : 0, 24533
IAST [candidate] (24.56 ms) : 0, 24560
AppSec [baseline] (172.692 ms) : 0, 172692
AppSec [candidate] (173.707 ms) : 0, 173707
Debugger [baseline] (68.991 ms) : 0, 68991
Debugger [candidate] (67.686 ms) : 0, 67686
Remote Config [baseline] (799.564 µs) : 0, 800
Remote Config [candidate] (746.881 µs) : 0, 747
Telemetry [baseline] (9.406 ms) : 0, 9406
Telemetry [candidate] (9.349 ms) : 0, 9349
Flare Poller [baseline] (3.789 ms) : 0, 3789
Flare Poller [candidate] (3.739 ms) : 0, 3739
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (792.162 ms) : 0, 792162
BytebuddyAgent [candidate] (794.405 ms) : 0, 794405
GlobalTracer [baseline] (256.143 ms) : 0, 256143
GlobalTracer [candidate] (256.835 ms) : 0, 256835
IAST [baseline] (27.103 ms) : 0, 27103
IAST [candidate] (27.188 ms) : 0, 27188
AppSec [baseline] (34.422 ms) : 0, 34422
AppSec [candidate] (33.684 ms) : 0, 33684
Debugger [baseline] (65.637 ms) : 0, 65637
Debugger [candidate] (66.607 ms) : 0, 66607
Remote Config [baseline] (547.929 µs) : 0, 548
Remote Config [candidate] (590.333 µs) : 0, 590
Telemetry [baseline] (8.398 ms) : 0, 8398
Telemetry [candidate] (8.557 ms) : 0, 8557
Flare Poller [baseline] (3.614 ms) : 0, 3614
Flare Poller [candidate] (3.672 ms) : 0, 3672
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (707.44 ms) : 0, 707440
BytebuddyAgent [candidate] (700.597 ms) : 0, 700597
GlobalTracer [baseline] (221.623 ms) : 0, 221623
GlobalTracer [candidate] (219.875 ms) : 0, 219875
AppSec [baseline] (32.509 ms) : 0, 32509
AppSec [candidate] (32.07 ms) : 0, 32070
Debugger [baseline] (67.544 ms) : 0, 67544
Debugger [candidate] (67.875 ms) : 0, 67875
Remote Config [baseline] (658.86 µs) : 0, 659
Remote Config [candidate] (643.681 µs) : 0, 644
Telemetry [baseline] (8.721 ms) : 0, 8721
Telemetry [candidate] (8.644 ms) : 0, 8644
Flare Poller [baseline] (3.627 ms) : 0, 3627
Flare Poller [candidate] (3.616 ms) : 0, 3616
ProfilingAgent [baseline] (96.178 ms) : 0, 96178
ProfilingAgent [candidate] (97.275 ms) : 0, 97275
Profiling [baseline] (96.753 ms) : 0, 96753
Profiling [candidate] (97.852 ms) : 0, 97852
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.027 ms) : 2991, 3063
. : milestone, 3027,
iast_FULL (5.841 ms) : 5783, 5899
. : milestone, 5841,
iast_GLOBAL (3.456 ms) : 3406, 3506
. : milestone, 3456,
profiling (1.99 ms) : 1973, 2008
. : milestone, 1990,
tracing (1.782 ms) : 1767, 1797
. : milestone, 1782,
section candidate
no_agent (1.176 ms) : 1165, 1187
. : milestone, 1176,
iast (3.251 ms) : 3210, 3292
. : milestone, 3251,
iast_FULL (5.925 ms) : 5865, 5985
. : milestone, 5925,
iast_GLOBAL (3.624 ms) : 3563, 3684
. : milestone, 3624,
profiling (2.062 ms) : 2043, 2080
. : milestone, 2062,
tracing (1.786 ms) : 1771, 1802
. : milestone, 1786,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (18.975 ms) : 18781, 19170
. : milestone, 18975,
appsec (18.567 ms) : 18376, 18758
. : milestone, 18567,
code_origins (17.902 ms) : 17722, 18082
. : milestone, 17902,
iast (18.64 ms) : 18451, 18829
. : milestone, 18640,
profiling (18.586 ms) : 18400, 18772
. : milestone, 18586,
tracing (17.54 ms) : 17368, 17712
. : milestone, 17540,
section candidate
no_agent (18.098 ms) : 17912, 18284
. : milestone, 18098,
appsec (18.373 ms) : 18188, 18559
. : milestone, 18373,
code_origins (17.678 ms) : 17503, 17854
. : milestone, 17678,
iast (17.777 ms) : 17600, 17955
. : milestone, 17777,
profiling (19.639 ms) : 19440, 19837
. : milestone, 19639,
tracing (17.606 ms) : 17430, 17782
. : milestone, 17606,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (15.551 s) : 15551000, 15551000
. : milestone, 15551000,
appsec (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
iast (18.265 s) : 18265000, 18265000
. : milestone, 18265000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
profiling (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
tracing (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
section candidate
no_agent (14.822 s) : 14822000, 14822000
. : milestone, 14822000,
appsec (14.658 s) : 14658000, 14658000
. : milestone, 14658000,
iast (18.005 s) : 18005000, 18005000
. : milestone, 18005000,
iast_GLOBAL (17.993 s) : 17993000, 17993000
. : milestone, 17993000,
profiling (14.723 s) : 14723000, 14723000
. : milestone, 14723000,
tracing (14.53 s) : 14530000, 14530000
. : milestone, 14530000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~84ec8a69dd, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.728 ms) : 3509, 3948
. : milestone, 3728,
iast (2.196 ms) : 2131, 2260
. : milestone, 2196,
iast_GLOBAL (2.254 ms) : 2189, 2319
. : milestone, 2254,
profiling (2.087 ms) : 2033, 2142
. : milestone, 2087,
tracing (2.04 ms) : 1989, 2091
. : milestone, 2040,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.655 ms) : 3440, 3871
. : milestone, 3655,
iast (2.21 ms) : 2145, 2275
. : milestone, 2210,
iast_GLOBAL (2.259 ms) : 2193, 2324
. : milestone, 2259,
profiling (2.072 ms) : 2018, 2126
. : milestone, 2072,
tracing (2.029 ms) : 1978, 2079
. : milestone, 2029,
|
What Does This Do
Captures were not added if captureSnapshot=false. using isFullSnapshot method to determine if we adding them or not
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DEBUG-4929