Skip to content

chore(internal/civisibility): reduce civisibility gotesting tests verbosity #3862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 12, 2025
Merged

chore(internal/civisibility): reduce civisibility gotesting tests verbosity #3862

merged 3 commits into from
Aug 12, 2025

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR reduce the logs verbosity in the gotesting tests. It also execute the test in serial mode to reduce the chance of the git shallow lock warning message to happen.

Motivation

When something fails it's hard to read the CI logs due too much logs entries.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo requested a review from a team as a code owner August 11, 2025 09:36
@pr-commenter
Copy link

pr-commenter bot commented Aug 11, 2025 •
edited
Loading

Benchmarks

Benchmark execution time: 2025-08-11 10:48:26

Comparing candidate commit 54fa0b2 in PR branch tony/reduce-civisibility-gotesting-tests-verbosity with baseline commit a99b459 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 1 unstable metrics.

hannahkm
hannahkm approved these changes Aug 11, 2025
View reviewed changes
internal/civisibility/integrations/gotesting/testcontroller_test.go
fmt.Printf("\n**** [SCENARIO %s IS DONE]\n\n", v)
if err != nil {
if exiterr, ok := err.(*exec.ExitError); ok {
fmt.Printf("\n===========================================\n**** [SCENARIO %s FAILED WITH EXIT CODE: %d]\n", v, exiterr.ExitCode())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! One comment: any reason why we're using fmt.Printf here but log.Debug below? We also have the log.Info function if we need to print regardless of debug mode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm just wanted to make a differentiation between launching the scenarios to test, and the test itself, is more visual than anything. So when I'm testing a scenario all logs within the scenarios uses the internal logger, but here I'm still outside of a testing scenario. As I said, it's only affects visually when I'm debugging.

@tonyredondo
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-11 13:48:00 UTC ℹ️ Start processing command /merge

2025-08-11 13:48:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-11 17:49:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@tonyredondo
Copy link
Member Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 12, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-12 11:58:45 UTC ℹ️ Start processing command /merge

2025-08-12 11:58:52 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-12 12:12:22 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 66aa2dd into main Aug 12, 2025
224 checks passed
@dd-mergequeue dd-mergequeue bot deleted the tony/reduce-civisibility-gotesting-tests-verbosity branch August 12, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahkm hannahkm hannahkm approved these changes

@daniel-mohedano daniel-mohedano daniel-mohedano approved these changes

@ManuelPalenzuelaDD ManuelPalenzuelaDD Awaiting requested review from ManuelPalenzuelaDD ManuelPalenzuelaDD is a code owner automatically assigned from DataDog/ci-app-libraries

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyredondo @hannahkm @daniel-mohedano